From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0F8DC3DA7F for ; Mon, 5 Aug 2024 11:38:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eXUv4vhwwDrlK6OrMkKD/adJ3fBSeeUSyzbCZQ61tL0=; b=0n7XbC+i3HCphxKRVpufHtgnVI JLgSig+ch91p0f4HEPGUWQA0LTKWQlkN2PIA3/gaTql7+4DPWrH9nE3WZXZiFVXtNA8SVnDDKPpQY 1YbCIdRcjMWjZDjQtwmZOH8CFumM3+EWfhH3GlRnaHrIqVBR87ko8qk6945bNNE49mNzfZlsgo1v3 nxE8QCU9tgMfXn/dObMJqWUZ/J+31SN1rYuFpXfEuEitKy4PqvwRNoiBfkMTbpaZd1FAC9pX7moyb cdvc05DyIFPhvregGWOXDDrtQkaWTy9FLAitS62/L8I5/mb3RgjTZhSpAuuxqsWDMp84FQdtIOzQJ xTbsbrSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1saw2A-0000000FheQ-09sY; Mon, 05 Aug 2024 11:37:50 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1saw1d-0000000FhW6-2vBh; Mon, 05 Aug 2024 11:37:19 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1722857833; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eXUv4vhwwDrlK6OrMkKD/adJ3fBSeeUSyzbCZQ61tL0=; b=qUUlxRPT1IMSC952YYeidmM0KBYMvEOIsbrWjX5Wcam1Tqn5KVnFKpwl8kQOgxOCNf+9fx 9WLIi3gt00vx7CwV0DbX2hhKD2/5mp3ir3ZOmOHaJ4c58zU5kLXPWjNpnyxsRtlnvi4u/7 WOrr4TD7UFyOEH3loM4VszSqwDGpAVOAwdgwD6fWnzOv1sRs+Dru7PRIW9byugYmu5pgVG 3I09LAldrwTsabdPnpYCVcgJ+eLOWKhToSd0N94QN/YwU39dCX5wjobRLuloLLMtT1vOFY 7Pp89kj2kr/0co2oV38y7Di/ruP30FVWjRab2fOwVxzjFQQRK4qtsK99Hdl4vg== Date: Mon, 05 Aug 2024 13:37:11 +0200 From: Dragan Simic To: Yao Zi Cc: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Greg Kroah-Hartman , Jiri Slaby , Chris Morgan , Jonas Karlman , Tim Lunn , Andy Yan , Muhammed Efe Cetin , Jagan Teki , Ondrej Jirman , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH 3/4] arm64: dts: rockchip: Add base DT for rk3528 SoC In-Reply-To: References: <20240803125510.4699-2-ziyao@disroot.org> <20240803125510.4699-5-ziyao@disroot.org> <56bd1478-ce8c-4c1d-ab16-afe4ad462bf5@kernel.org> Message-ID: <82e7e3a78f784b3ad63094c8a0ab1932@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240805_043718_230686_F830CC92 X-CRM114-Status: GOOD ( 15.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-08-05 12:59, Yao Zi wrote: > On Sun, Aug 04, 2024 at 04:05:24PM +0200, Krzysztof Kozlowski wrote: >> On 04/08/2024 15:20, Yao Zi wrote: >> >> >> >>> + compatible = "fixed-clock"; >> >>> + #clock-cells = <0>; >> >>> + clock-frequency = <24000000>; >> >>> + clock-output-names = "xin24m"; >> >>> + }; >> >>> + >> >>> + gic: interrupt-controller@fed01000 { >> >> >> >> Why this all is outside of SoC? >> > >> > Just as Heiko says, device tree for all other Rockchip SoCs don't have >> > a "soc" node. I didn't know why before but just follow the style. >> > >> > If you prefer add a soc node, I am willing to. >> >> Surprising as usually we expect MMIO nodes being part of SoC to be >> under >> soc@, but if that's Rockchip preference then fine. >> > > Okay, then I would leave it as is. > > For the fixed-clock node, I think "xin24m: clock-24m { }" is okay and > follows the new rule? I find "xin24m: clock-xin24m { }" better, because keeping the "xin24m" part in /sys listing(s), for example, can only be helpful.