From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D536C4332F for ; Mon, 6 Nov 2023 10:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SJJ99mmnLcPhCg/lDCNHPGnEHtA4s3nDujDaZuPwBOY=; b=WSsNFPIgRXRENu fUwJ+xqKfBZWjZf8+NJZloavnySE3gmjGisuFe75oMWBUE5wysr41l+6Q3tHNt3eWe7VUUFkGJr8K u/5vNJE9hUKJLOZQH+nn9oBWjb3hr0ivDy+zKoPtWNuW/QrwFOfqXxQnZXuftp2rOqIGfOqIY5ADc MacTtlUSsPw1AZ/gcSJXYsn+MsB8ERh+WuCQgWyKTHM79MVrknoDKEHYoChoF5JOnQh7Vb0Kf7k1g lqGniUodSFuTzSg3DiuNMNGWmfuQPFRi0llzVWZYnlXW4WBLP0YnjJr6oEQ7+k0Mti+va6LxANtuG HIggekUJbhE3vXvE8XJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qzxAY-00GHLg-30; Mon, 06 Nov 2023 10:49:22 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qzxAV-00GHKf-0n for linux-arm-kernel@lists.infradead.org; Mon, 06 Nov 2023 10:49:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1699267759; x=1730803759; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3ClLqCe2MPe30BlSuDnNn0P7ZITlkrf+aHuvKtDI/Mc=; b=q2fXyPiFOqPkVKudnmf3sZDMb7RRMuvJb271IRJCvoaJEH9OSWAnQ9NH WQMWVgGv9ShwZ/RcCzJCBocCpntV6tBg0zl4gMiB55zFQ7GL2biYs+pml EK84BlQvjssGiRuKnmvUNFhNoPfMntu65kRNUkxg5Cr03iV6PI9uKOalz fni9h6x0hnKLMFv9fVLqC3mWaV4HD5/1SPqVxau32rqOrMVAlnZ49UEi0 NMNXgfe++OKlkMbvfS2niXmuHyg9lsZvwoPJ3UrCqG4B5oIxb69HDH7Bg maIaNeu1hQuMHhzXYil7l0Z/9giJrVGxKergx8bdTWACnd7XWHlmRqMtF w==; X-IronPort-AV: E=Sophos;i="6.03,281,1694728800"; d="scan'208";a="33824773" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 06 Nov 2023 11:49:17 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 9727928007F; Mon, 6 Nov 2023 11:49:16 +0100 (CET) From: Alexander Stein To: Uwe =?ISO-8859-1?Q?Kleine=2DK=F6nig?= Cc: Thierry Reding , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] dt-bindings: pwm: imx-pwm: Add constraints for #pwm-cells Date: Mon, 06 Nov 2023 11:49:19 +0100 Message-ID: <8300676.T7Z3S40VBb@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20231106103621.2fh6fkpdafpz4toa@pengutronix.de> References: <20231106095205.231210-1-alexander.stein@ew.tq-group.com> <20231106095205.231210-2-alexander.stein@ew.tq-group.com> <20231106103621.2fh6fkpdafpz4toa@pengutronix.de> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231106_024919_676718_A383CE03 X-CRM114-Status: GOOD ( 17.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Uwe, Am Montag, 6. November 2023, 11:36:21 CET schrieb Uwe Kleine-K=F6nig: > Hello, > = > [dropped Philippe Schenker from Cc as his email bounced in the past] > = > On Mon, Nov 06, 2023 at 10:52:03AM +0100, Alexander Stein wrote: > > Only fsl,imx1-pwm comptabile devices use #pwm-cells =3D <2>. Newer SoCs > > supportinverted PWM output, thus #pwm-cells needs to be set to 3. > > = > > Signed-off-by: Alexander Stein > > --- > > = > > .../devicetree/bindings/pwm/imx-pwm.yaml | 20 ++++++++++++++++--- > > 1 file changed, 17 insertions(+), 3 deletions(-) > > = > > diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml index > > c01dff3b7f843..59a981c0f39ab 100644 > > --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml > > @@ -9,9 +9,6 @@ title: Freescale i.MX PWM controller > > = > > maintainers: > > - Philipp Zabel > > = > > -allOf: > > - - $ref: pwm.yaml# > > - > > = > > properties: > > "#pwm-cells": > > description: | > > = > > @@ -74,6 +71,23 @@ required: > > additionalProperties: false > > = > > +allOf: > > + - $ref: pwm.yaml# > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: fsl,imx1-pwm > > + then: > > + properties: > > + "#pwm-cells": > > + enum: [2] > = > Given that arch/arm/boot/dts/nxp/imx/imx1.dtsi has: > = > pwm: pwm@208000 { > #pwm-cells =3D <3>; > compatible =3D "fsl,imx1-pwm"; > ... > = > this looks wrong. Indeed, something i doesn't match. Checking with [1] section 22.4.1 there a= re = no bits regarding output inversion. Also pwm_imx1_apply returns -EINVAL if = state->polarity !=3D PWM_POLARITY_NORMAL. So IMO "#pwm-cells =3D <3>" is wrong for imx1. If fixed to 2, this also mat= ches = the description for the value of #pwm-cells in imx-pwm.yaml. Best regards, Alexander [1] https://www.nxp.com/docs/en/reference-manual/MC9328MX1RM.pdf > = > Best regards > Uwe -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel