From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4797AC05027 for ; Sun, 19 Feb 2023 12:38:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cwU39+RwTYJno7NPOzki/RKBpKXUGC5ZAQVzPYlEpUs=; b=4W23dO4Vsgrp9N NGujNsK/m5w601IAevfYX4wU8C47avN5yvkyWFh0gahumi2mAANrIiyfbV0CWzuQYmMwMI17wJP2W HCG1ZiVHZ+HasvZSjB5xb5f2RfjbUOTirhfcKFf5horBYW5o8zbKlIGg3ecRmECUZ628R76l6m1/8 MbkpouzxTtT9a8wos3/F2fBNMaEpBFKbejSPqsVuRzA/LPkUs3Slhm9I1fgZEuQvnuDMt8PxIt+DD gdeyzHwe8dBv24+faOANv07Bhr3GXY9cf1zyOAk1ida4Sz83vp5kyuBIYTToBx9gctZ9NNKFYQfh2 UuhYEKLLWBp4uL+n3yRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTiw4-001V59-OW; Sun, 19 Feb 2023 12:36:56 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pTiw0-001V3I-Ur for linux-arm-kernel@lists.infradead.org; Sun, 19 Feb 2023 12:36:54 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 2127832000D9; Sun, 19 Feb 2023 07:36:45 -0500 (EST) Received: from imap47 ([10.202.2.97]) by compute5.internal (MEProxy); Sun, 19 Feb 2023 07:36:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1676810204; x=1676896604; bh=dQ HYQiUC3rK1Tk9ToEOCzWhq7C7C8mrinV1UbDHRWOw=; b=Gh0F6m1mWS9gqpKYhh NfTUbMzOWFxbOnzAPvbQ/f9n6SdJoBBTrl01zCgjWjFwgXB+oTl4N7rZlFl1pl04 0Wo+S5HXycooUsxpTYezHx8HpR14pgkhFwU+NNmnxA6N7lNHYGzmYiSwprUt4EjE I/3ERhY4IA9qxatauf9QYcYvpapiNTeZXknuHemeuZOLwI4hTFivg4BFtJGtntW7 VAN8H3iKMbT3hNdFF7y0LMbqucFac6lyBGwFOvhPoxUc3+p8MegLPpCjDYY0HbZ6 WPT7IKq6JFzRHr9ugi5ysxHCsktMLmhgNYPkARajtdSEwzP7O5AsBvB4MUtNldIM edZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676810204; x=1676896604; bh=dQHYQiUC3rK1Tk9ToEOCzWhq7C7C 8mrinV1UbDHRWOw=; b=mRv6O+2uKIzV80nzsJPaB37VvG1QqK7ORuJnpaOQwxWa 11hg+VQwZNFpeIbnOwvIRqPyKt3GW5ryDpAzckNteLPAiDUrTKaKP91KFY+mz+NL ypwy30sKWMHfCcGNa5tPSuUfNb4/tMFLvENsZH6w2BrSOYJstdRtxomFdi/90nUQ CDq8kJk/ap4c4xeZdfPeMBV2VThxappTORQGyyHcSrggfubPtl+3h/ZoWIf+0O9R qCNH2HlLvIc94HY1TrpMSGLllQ1RehuDyPMw22iVWVDZfoTsPSbTHrUZj9rArXF2 Txk72C9eAXBQLb6oMsAG98Vsvsy/ZQmOa5FVbXHdoA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejfedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedfufhv vghnucfrvghtvghrfdcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrf grthhtvghrnhepleevgfegffehvedtieevhfekheeftedtjeetudevieehveevieelgffh ieevieeunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshhvvghnsehsvhgvnhhpvghtvghrrdguvghv X-ME-Proxy: Feedback-ID: i51094778:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 01900A6007C; Sun, 19 Feb 2023 07:36:42 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-156-g081acc5ed5-fm-20230206.001-g081acc5e Mime-Version: 1.0 Message-Id: <8303bbae-2f98-49fb-8fd6-550ecb272bae@app.fastmail.com> In-Reply-To: <20230202-asahi-t8112-dt-v2-16-22926a283d92@jannau.net> References: <20230202-asahi-t8112-dt-v2-0-22926a283d92@jannau.net> <20230202-asahi-t8112-dt-v2-16-22926a283d92@jannau.net> Date: Sun, 19 Feb 2023 13:36:22 +0100 From: "Sven Peter" To: "Janne Grunau" , "Hector Martin" , "Alyssa Rosenzweig" , "Rob Herring" , "Krzysztof Kozlowski" , "Mark Kettenis" Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 16/16] arm64: dts: apple: t8112: Initial t8112 (M2) device trees X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230219_043653_050055_A995EBC3 X-CRM114-Status: GOOD ( 19.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Tue, Feb 14, 2023, at 12:03, Janne Grunau wrote: > From: Hector Martin > > This adds device trees for the following devices: > - Macbook Air (M2, 2022) > - Macbook Pro 13" (M2, 2022) > - Mac mini (M2, 2023) > > Signed-off-by: Hector Martin > Co-developed-by: Janne Grunau > Signed-off-by: Janne Grunau > --- > arch/arm64/boot/dts/apple/Makefile | 3 + > arch/arm64/boot/dts/apple/t8112-j413.dts | 63 ++ > arch/arm64/boot/dts/apple/t8112-j473.dts | 54 ++ > arch/arm64/boot/dts/apple/t8112-j493.dts | 52 ++ > arch/arm64/boot/dts/apple/t8112-jxxx.dtsi | 81 ++ > arch/arm64/boot/dts/apple/t8112-pmgr.dtsi | 1141 +++++++++++++++++++++++++++++ > arch/arm64/boot/dts/apple/t8112.dtsi | 912 +++++++++++++++++++++++ > 7 files changed, 2306 insertions(+) > > diff --git a/arch/arm64/boot/dts/apple/Makefile > b/arch/arm64/boot/dts/apple/Makefile > index 5a7506ff5ea3..aec5e29cdfb7 100644 > --- a/arch/arm64/boot/dts/apple/Makefile > +++ b/arch/arm64/boot/dts/apple/Makefile > @@ -10,3 +10,6 @@ dtb-$(CONFIG_ARCH_APPLE) += t6000-j316s.dtb > dtb-$(CONFIG_ARCH_APPLE) += t6001-j316c.dtb > dtb-$(CONFIG_ARCH_APPLE) += t6001-j375c.dtb > dtb-$(CONFIG_ARCH_APPLE) += t6002-j375d.dtb > +dtb-$(CONFIG_ARCH_APPLE) += t8112-j413.dtb > +dtb-$(CONFIG_ARCH_APPLE) += t8112-j473.dtb > +dtb-$(CONFIG_ARCH_APPLE) += t8112-j493.dtb > diff --git a/arch/arm64/boot/dts/apple/t8112-j413.dts > b/arch/arm64/boot/dts/apple/t8112-j413.dts > new file mode 100644 > index 000000000000..9e758edeaa82 > --- /dev/null > +++ b/arch/arm64/boot/dts/apple/t8112-j413.dts > @@ -0,0 +1,63 @@ > +// SPDX-License-Identifier: GPL-2.0+ OR MIT > +/* > + * Apple MacBook Air (M2, 2022) > + * > + * target-type: J413 > + * > + * Copyright The Asahi Linux Contributors > + */ > + > +/dts-v1/; > + > +#include "t8112.dtsi" > +#include "t8112-jxxx.dtsi" > + > +/ { > + compatible = "apple,j413", "apple,t8112", "apple,arm-platform"; > + model = "Apple MacBook Air (13-inch, M2, 2022)"; > + > + aliases { > + bluetooth0 = &bluetooth0; > + wifi0 = &wifi0; > + }; > +}; > + > +/* > + * Force the bus number assignments so that we can declare some of the > + * on-board devices and properties that are populated by the bootloader > + * (such as MAC addresses). > + */ > +&port00 { > + bus-range = <1 1>; > + wifi0: wifi@0,0 { > + compatible = "pci14e4,4433"; I'm not sure how these pci compatibles are usually handled. Do they have to be added to the dt-bindings Documentation as well or is it fine to just have them here since they're not really used to match anything? Otherwise this looks good to me, Reviewed-by: Sven Peter Best, Sven _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel