From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D91BCA100D for ; Tue, 5 Sep 2023 20:33:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UYXfPVHk0WCWavcE6BMC9Jb6CssfEQCdYPV46ezE2jc=; b=JzuArdiy9udT4Y sf5OMA80P5cuy8OQdJ1ByglWLZoGL/I2xFJ0eOIHhrGcMU17c7Xd2uQCavDHMrTZUWAbDm0Il9+b3 FejrKuEqqWU5g8bHP3AufA9CqdCkcJDbFUspspeuQ1o3WMfmkauwrZ4wi3KnSnDcZZ9U+bw3hpluE kgaYUdfV7dH5K8Kbwm5rxBCR9XwpVE4JftCtq1mHg4fnu7bCF0tLdg8POW+z+udCrmo+VJKX5/OXK 5ilcRNOLb+uSW3gIeOJL/Gqxm1hLXtnj/GZJ9VOTYPioh6+xgBDC9pvTT9ocRwLag1FjhuyGkctRk wn/PKA9cw9X7v4kdHbIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdcjk-006h6P-0s; Tue, 05 Sep 2023 20:33:24 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdcji-006h4n-0P for linux-arm-kernel@lists.infradead.org; Tue, 05 Sep 2023 20:33:23 +0000 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-99c3d3c3db9so459696366b.3 for ; Tue, 05 Sep 2023 13:33:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693945996; x=1694550796; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kGd37heVkKpNeW2/JaXN+6U9D28h1iXnKKCdvuTuCX4=; b=iyZGuEGc0FWMVzosZ+WTHWiSzHXervD1SKJDrSthLvrCo2JxFck0G8Ps6ZXvsq/ndm AQVixPdcQFMFkt7pz5DHmCbkPyIw2fAZTJqFiUXt/YWWxhRxUD+FQWyTUgg6gx5o20TD iq7tfc+AU3jpKUsGt2YHrFNxNeaz5qboYJQ5dEbj+hAo4Iil4IfzEddPE/TM+5jnpyNy 5ZJQqfXvsBFqf1n5joQ5nWRJHTq7e30nBpxZVte+E4+fVN2xFdHRPNH05EMogqBL8olS mrBmO4LoBgi1a8M29YEiWb1CsBpODnPBWZF2bqOnd9hu6XwlgFP+wSGOal0dvVyCK9Ze chTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693945996; x=1694550796; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kGd37heVkKpNeW2/JaXN+6U9D28h1iXnKKCdvuTuCX4=; b=SCK4YTwsgGDvkYggRB/bdCXKP635DkaVeCLkQNJU3CfORjMq0aSqIORp1gQYimVfTs fwnBYTQ7DlZas1Fo93uhGSLpi+v/yrT7GQJZkLC1JzLrXtNF5tXzzk0ypvhrR6bSVePu TYd1dLLbmvklBtbUqq9y9ctn/8uOGeSZ2zcCqaGp+C7pdSlfFx7N1D2+wpHY4NsAg7WQ oMp7EMG+Q4/Mx3AG6l0PkZ1VdebyW/W+khPztBY9mCkxSfcpl6NL84gqy7gbn1mt8d9h axVxEWrKW+8vrackykux9u7fDlzabhrdsZAiU3eVpZwgzPujV0lSXn/xZOB2PyWPfKJt h+Ig== X-Gm-Message-State: AOJu0YxoDIobctZ90fWtitQaRVAGy9qvT/bw+oe4wR5FKFxarIRGbCHA 5dmvc5CuZv1bqJBu5/66gTY= X-Google-Smtp-Source: AGHT+IENZGk26Bm3PR5lydcBmGnBLfg4yzMPCxRYm/sOmVPlXgIH6rG0SRwq7IEeS0NdXyk/8TrfhA== X-Received: by 2002:a17:906:314f:b0:9a1:fc1e:19ac with SMTP id e15-20020a170906314f00b009a1fc1e19acmr714243eje.33.1693945995700; Tue, 05 Sep 2023 13:33:15 -0700 (PDT) Received: from archlinux.localnet (82-149-12-148.dynamic.telemach.net. [82.149.12.148]) by smtp.gmail.com with ESMTPSA id k23-20020a1709061c1700b00992b71d8f19sm7964262ejg.133.2023.09.05.13.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Sep 2023 13:33:15 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: samuel@sholland.org, wens@csie.org, Yang Li Cc: daniel.lezcano@linaro.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Yang Li Subject: Re: [PATCH -next] clocksource/drivers/sun5i: Remove surplus dev_err() when using platform_get_irq() Date: Tue, 05 Sep 2023 22:33:14 +0200 Message-ID: <8307837.NyiUUSuA9g@archlinux> In-Reply-To: <20230831041414.66434-1-yang.lee@linux.alibaba.com> References: <20230831041414.66434-1-yang.lee@linux.alibaba.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230905_133322_168668_EEF89EC7 X-CRM114-Status: GOOD ( 19.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thursday, August 31, 2023 6:14:14 AM CEST Yang Li wrote: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/clocksource/timer-sun5i.c:260:2-9: line 260 is redundant because > platform_get_irq() already prints an error > > Signed-off-by: Yang Li Acked-by: Jernej Skrabec Best regards, Jernej > --- > drivers/clocksource/timer-sun5i.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/clocksource/timer-sun5i.c > b/drivers/clocksource/timer-sun5i.c index 69fee3540d37..0d229a9058da 100644 > --- a/drivers/clocksource/timer-sun5i.c > +++ b/drivers/clocksource/timer-sun5i.c > @@ -256,10 +256,8 @@ static int sun5i_timer_probe(struct platform_device > *pdev) } > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "Can't get IRQ\n"); > + if (irq < 0) > return irq; > - } > > clk = devm_clk_get_enabled(dev, NULL); > if (IS_ERR(clk)) { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel