From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77825C00A8F for ; Tue, 24 Oct 2023 06:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AyvgXnwBqhrDCAytkQLYYatuLp3XZNYpEaS4u7zt5OQ=; b=qvp2zixtuJM/Ba jdWSQebP/ppEuhC9OhsTV0Xgv8barGOS/7Fs3+RlTiZ2gubM04x4HW5k6S7kpZsGZ9mPb7hDPPhZW GcPf+J42IedAIferODV1ocbfqYyVEWffCorQHVop5MtGIMAr2WEsBXOaPxpHb4i943a4B/NxEormU MPimMifCwbZ8QCs1B3WPSjkPhkoI9snU0m924bWrzwEqt3zZX3cyjKtXyNXMvuKy1h+mfxq51N0W6 moiHAoLta9SX8e42D9tkDgsxzQYBbgQebznjw5vizj32iXdyPyLrwPHYXXquqvazsLzfWNDJ/kPno zHZpcfILeoMCo0sCHUag==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qvAvl-008zRU-1q; Tue, 24 Oct 2023 06:30:21 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qvAvi-008zQb-1V for linux-arm-kernel@lists.infradead.org; Tue, 24 Oct 2023 06:30:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1698129018; x=1729665018; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9AUC3WlKvozWisL0AjNz7g2p54DmQxQY/G1iKkNelTY=; b=ayZ33IWcir0ipr3rI/K2pM8/bl1OYj8+UGBE8xDyVcre03Qgr+qY6Aeq emaETEG1i/t57ru61/zRB+zSQpekIGcR15JD1uNjIdtEY7SETj63a7Y46 HLpkP74mzXl7M00Ty7v2kEHpIwQn3J/a43v9kND+0PFw1dyUGSebZzyqB JC/HYsfnIWutsqJl584BQ++w5iLXtUrObAcVrbT06bBpPomJSfyo/JJwO HEldd132/CuETmA86xRMyQOhbz5/weVtkKvRC960qrMy5/t5G/usQ/4Xv ApgUsQ5uKMrz+ibcHT9OUfeGuWdyvnx/EAqTpoeU7oRB5zXeT+kz9DeMA w==; X-IronPort-AV: E=Sophos;i="6.03,246,1694728800"; d="scan'208";a="33614186" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 24 Oct 2023 08:30:14 +0200 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id B490B28007F; Tue, 24 Oct 2023 08:30:13 +0200 (CEST) From: Alexander Stein To: Conor Dooley Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , Ulf Hansson , Marek Vasut , Pengutronix Kernel Team , NXP Linux Team , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 2/5] dt-bindings: soc: imx93-media-blk-ctrl: Add LDB subnode into schema and example Date: Tue, 24 Oct 2023 08:30:16 +0200 Message-ID: <8331331.NyiUUSuA9g@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20231023-quote-wrongly-ed07265e12ac@spud> References: <20231020130019.665853-1-alexander.stein@ew.tq-group.com> <5986192.lOV4Wx5bFT@steina-w> <20231023-quote-wrongly-ed07265e12ac@spud> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231023_233018_914792_3F15414D X-CRM114-Status: GOOD ( 27.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Montag, 23. Oktober 2023, 18:37:29 CEST schrieb Conor Dooley: > On Mon, Oct 23, 2023 at 08:27:20AM +0200, Alexander Stein wrote: > > Am Sonntag, 22. Oktober 2023, 19:39:12 CEST schrieb Conor Dooley: > > > On Fri, Oct 20, 2023 at 03:00:15PM +0200, Alexander Stein wrote: > > > > Document the LDB bridge subnode and add the subnode into the exampl= e. > > > > For the subnode to work, the block control must scan its subnodes a= nd > > > > bind drivers to them, do not misuse either simple-bus or simple-mfd > > > > here. > > > > = > > > > Signed-off-by: Alexander Stein > > > > --- > > > > = > > > > .../soc/imx/fsl,imx93-media-blk-ctrl.yaml | 44 > > > > +++++++++++++++++++ > > > > 1 file changed, 44 insertions(+) > > > > = > > > > diff --git > > > > a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctr= l.y > > > > aml > > > > b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctr= l.y > > > > aml > > > > index b3554e7f9e76..5ba66dfb0e05 100644 > > > > --- > > > > a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctr= l.y > > > > aml > > > > +++ > > > > b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-media-blk-ctr= l.y > > > > aml> > > > > = > > > > @@ -24,6 +24,12 @@ properties: > > > > reg: > > > > maxItems: 1 > > > > = > > > > + '#address-cells': > > > > + const: 1 > > > > + > > > > + '#size-cells': > > > > + const: 1 > > > > + > > > > = > > > > '#power-domain-cells': > > > > const: 1 > > > > = > > > > @@ -46,9 +52,16 @@ properties: > > > > - const: csi > > > > - const: dsi > > > > = > > > > + bridge@20: > > > > + type: object > > > > + $ref: /schemas/display/bridge/fsl,ldb.yaml# > > > > + unevaluatedProperties: false > > > > + > > > > = > > > > required: > > > > - compatible > > > > - reg > > > > = > > > > + - '#address-cells' > > > > + - '#size-cells' > > > = > > > It seems to make little sense to me that these would become required > > > when the bridge is optional. Is it valid to have one of these > > > media-blk-ctrls without the ldb subnode? > > = > > fsl,imx93-media-blk-ctrl privides several power-domains (DSI, CSI, ISI, > > PXP > > and LCDIF), currently unused. This series introduces the usage for LCDIF > > power domain. LDB is the LVDS display bridge. So there are several power > > domains which don't requires the usage of ldb. > > On the other hand I prefer consistency, so I opted to keep things simil= ar > > to commit 1cb0c87d27dc. If it shall not be added here, it should be > > removed in > > Documentation/devicetree/bindings/soc/imx/fsl,imx8mp-media-blk-ctrl.yaml > > as well. > = > IIRC the tooling will complain if you have an enabled node containing > #address-cells and/or #size-cells but no child nodes, so making > #address-cells or #size-cells required will cause problems. Looks like > the only user has the child node, so it didn't crop up yet. I was not able to raise a warning with enabled media_blk_ctrl having #addre= ss- cells/#size-cells being set but no subnode. I don't have a strong opinion on this, but I prefer having both bindings as = similar as possible. best regards, Alexander -- = TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel