From: Krzysztof Kozlowski <krzk@kernel.org>
To: Richard Hu <richard.hu@technexion.com>,
sascha.hauer@pengutronix.de, Shawn Guo <shawnguo@kernel.org>
Cc: imx@lists.linux.dev, ray.chang@technexion.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: imx8mp: Add TechNexion EDM-G-IMX8M-PLUS SoM on WB-EDM-G carrier board
Date: Fri, 9 May 2025 15:58:32 +0200 [thread overview]
Message-ID: <83401d0a-ca96-4cfd-9016-13a8604beb9c@kernel.org> (raw)
In-Reply-To: <8173a798-b5d7-485c-8ce3-b46f4a097d83@kernel.org>
On 09/05/2025 15:21, Krzysztof Kozlowski wrote:
>
> No, that's not a spi controller.
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
>
>> + compatible = "rohm,dh2228fv";
>
> I doubt that. Drop the node or fix the compatible.
... especially that dh2228fv does not exist. There is no such device
from ROHM. If you claim otherwise, please share this imaginary device
datasheet.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-09 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 7:12 [PATCH 2/2] arm64: dts: imx8mp: Add TechNexion EDM-G-IMX8M-PLUS SoM on WB-EDM-G carrier board Richard Hu
2025-05-09 13:21 ` Krzysztof Kozlowski
2025-05-09 13:22 ` Krzysztof Kozlowski
2025-05-09 13:58 ` Krzysztof Kozlowski [this message]
2025-05-09 15:44 ` Conor Dooley
2025-05-09 14:29 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83401d0a-ca96-4cfd-9016-13a8604beb9c@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.chang@technexion.com \
--cc=richard.hu@technexion.com \
--cc=sascha.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox