From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3E82606A31C for ; Mon, 16 Nov 2026 22:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=GJPLGqzm; dkim=pass (2048-bit key, unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm2 header.b=ZAEZsjJp; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=Q9DTKFid DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:References:In-Reply-To:Message-Id:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=OcAgC0vPJKwVGXFjWubBy/YnWKV2HmzIb3LAukpGicE=; b=GJPLGqzman4j/+ X4r9bNwWNsYKbLAR0vTk/v+z3dih6JI0YnDGi748lMJ3rdjkOQxz2mvJUMEfNJCe4Pyra1EOOK8bn 0DhPT1br201mDI/l4yOT732GFv/v7Fw7GtLcKapt2pkt1SAdtqYMlXloNv0UTNvuL3vVYCqyZiNdG XYxV7Cb80Lu9I6dPPugk7+d4HD5Y1mVED5pOlpRTMH5+VePifT5Y1bm9vx6rbY7gK5hIJFfjKf7U9 0tMcrH7sflxl26Vt0k94E4L9QKAdCYt4+WQAGAE6d5rjYvT5EIQ5mNjn9ujWWf7MHc+NVUo2uH8Jt CuZiajEiiAb7+ySw+Vsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xT5b8-000000045MO-2fQD; Mon, 16 Nov 2026 22:54:51 +0000 Received: from fhigh-a7-smtp.messagingengine.com ([103.168.172.158]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xT5b5-000000045M2-2DZe for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2026 22:54:49 +0000 Received: from ams-compute-02.internal (ams-compute-02.internal [10.64.2.62]) by mailfhigh.phl.internal (Postfix) with ESMTP id AD12A14000B7 for ; Mon, 16 Nov 2026 17:54:45 -0500 (EST) Received: from ams-imap-03 ([10.64.2.23]) by ams-compute-02.internal (MEProxy); Mon, 16 Nov 2026 17:54:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1794869676; x=1794956076; bh=OcAgC0vPJKwVGXFjWubBy/YnWKV2HmzIb3LAukpGicE=; b= ZAEZsjJpuRQxEFpNlUZgnShZrgORqdVNh9DyAVrLzb30qXR61XfYqoRaMrobLuH7 zynLG+rLBei2d6LgTseF6/Qsv0f0k1bSxFNPhydlhTdo/E9jaEWpZr6jf2snhjJs p0PpdLtt2tVJhmRpWzkyXLsm8oFMA6LSBx1DIh5f5tytnmoUCfswTljpraIgofMx qnZ0sXkBEg3LeqYbdeM8Xg13BM0yd86FTDqd8f4Mv/KE3QWnlWRJfSmsD01uU/1H JunDVoj1Br6H+nLAhOO8aw4xRwlI9knNWnRUBQ3rRPBPMTP8YYfPZrVCep0r1l+S J1Eq2NaURUS3F4BmXDxbug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1794869676; x= 1794956076; bh=OcAgC0vPJKwVGXFjWubBy/YnWKV2HmzIb3LAukpGicE=; b=Q 9DTKFidW8SGMQlcttnyM4KM7l8Rlgdl9JoiGLBTw6vGhuH8Hfvif5fJcsK4bxJjB 3JnDCurQWCL01lfJmu8Cf+xXWjlRixgLbKW8ghg0iAw0TvBpR++etMHvXWbQD8bh 4/WKFb3GuG31YwtYvfsoNpmB3P3/ANhmuRyqtPuBwfOC8j3xN/26CXSVqH+SrO5p O+/xL7q7fBGdD4UVk99LKvPfMrkuhR7MUQeX/LQvkdnYSkl+BCLGKvSzl17iTAuk hzAYTGHTC/YUqlqxDn/mlX1L2RhqbypIjTpxRAxj3FT49uj24+M3VOXay7eWdo4n XWRpG/d3k259KP5mbuBrg== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=arndb.de a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794869676; d=arndb.de; mf=PGFybmRAYXJuZGIuZGU+; rt=PGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZz4=; s=fm2:rsa-sha256:jbM9GCBxo/DEnqTGRlr92d5U8hzZcpg202Hnn5JKbpnG5GS ssnHibf+Kh2Igv+8M04CbJRxaZJ842G9/Trwd5Ijflr3qKPAX/2f+2MHbEU476La MD9lZTV7DwC07xKST7GZNHdh/D21c216GWK40/dZezjK7t5huHQCe/f9+EXnW9vv UsO9qCnD12rK6kDD1xleuYdT5CJuP6/sbcTPNP1ey5cNBQDkPPo3wvvo7K/ORio7 r+9rwXPVOIChiPhQOJOOScT8lmA17wP4qHpy7QY5z9R+6VoWqtUNWHNYY/p302GX zmA+z7+3QGznx4R5TaUL94/hBl7+whCPMKpEMKA==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-transfer-encoding,content-type,date,feedback-id, from,in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:1FLIZhGqarwOJSnywNEf9XRvfjOg2CpkcYCnEGQdU5s=:upc1O8MhVk6W6DXMUXoKnCzT5vlTeKI3ptx/dGWzRao=; X-ME-Sender: X-ME-Proxy-Cause: dmFkZTGYHYRRTDjHLNMRLa12I41RV/zEUX5WZz+wz6jwGtrJt9YQLDiiD2umaL7QU8Y/qB iECjbl6aYU3q/0J7B2Zv7XwkLq2NTuAEl2lYzsFFfzHWIDRX7QGqZ1wrfNYzqWAAcxs3UP zvZ+yvxg01oDoRtpjdbpnQ5iFomwiYQpkHZLDJfw2rM0QquV3UEg8Lu+BITL/63EjH/G0L 9qX9B5G+BCW0tG+4+s9LQPza5D6BLo+3wbITjCE9Rcy4y29konmMAOurewxT6Tr++S90dq cPHsImnluo8UikP6vG7g8wbS+eVlCp2LkEpHP56AJbqT3gqaj++5oFCkPJUPgxaZwLqpI8 o00H6vIP2RSQYTyqnEalaSnYha3EWtY6uexVC8QlipwsgATE2m+gKnCgbyJDNbuipj3G8w SmwWpamBMJcnBAQF/lbbPBnnFP/wgmf16VVFk6brqBLtE8xqQY+s+i22wcrHn8BTOv79ac j/NZa7vV/IHjryko7kye/LXI7qW6XF7hZtp6gP2Uu19TYjVFBoVo3EondqK0SPD4vg1u3i guWhisYm11KjBFmyjpxNcXvaOST6ywxyTQycc8dB3YRWh7j5pHwlNFCuzfRYoY3WBr9MsW tlZrbtmDiKz6ymb9We4Cdj8O9Mq1lm4HDsHp9Xg9gqmHT3qq4J6qZY2GbJBQ X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.ams.internal (Postfix, from userid 501) id 373F832A009F; Mon, 16 Nov 2026 17:54:23 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface X-Archived-By: MIME-Version: 1.0 X-ThreadId: AwZDIwU2rPTF Date: Mon, 16 Nov 2026 23:54:02 +0100 From: "Arnd Bergmann" To: "Christophe Leroy" , "Arnd Bergmann" , linux-mm@kvack.org Cc: "Andreas Larsson" , "Andrew Morton" , "Dave Hansen" , "David Hildenbrand (Red Hat)" , "H. Peter Anvin" , "Ingo Molnar" , "Jason Gunthorpe" , "Linus Walleij" , "Lorenzo Stoakes" , "Lucas Stach" , "Madhavan Srinivasan" , "Malin Jonsson" , "Matthew Wilcox" , "Michael Ellerman" , "Michal Simek" , "Mike Rapoport" , "Nicholas Piggin" , "Nishanth Menon" , "Richard Weinberger" , "Russell King" , "Thomas Gleixner" , linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org Message-Id: <83495d02-4e09-40f0-94fe-e57a1e73d1a3@app.fastmail.com> In-Reply-To: References: <20261116124832.662455-1-arnd@kernel.org> <20261116124832.662455-5-arnd@kernel.org> Subject: Re: [PATCH v3 04/10] powerpc: kvm: allow flexible PAGE_OFFSET Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261116_145448_041418_C0CF1BE3 X-CRM114-Status: GOOD ( 19.72 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On Mon, Nov 16, 2026, at 14:38, Christophe Leroy (CS GROUP) wrote: > Le 16/11/2026 =C3=A0 13:48, Arnd Bergmann a =C3=A9crit=C2=A0: >> diff --git a/arch/powerpc/kvm/book3s_32_sr.S b/arch/powerpc/kvm/book3= s_32_sr.S >> index 6cfcd20d4668..0d8a7857f2bd 100644 >> --- a/arch/powerpc/kvm/book3s_32_sr.S >> +++ b/arch/powerpc/kvm/book3s_32_sr.S >> @@ -113,8 +113,8 @@ >> =20 >> li r0, 4 >> mtctr r0 >> - LOAD_REG_IMMEDIATE(r3, 0x20000000 | (0x111 * 0xc)) >> - lis r4, 0xc000 >> + LOAD_REG_IMMEDIATE(r3, 0x20000000 | (0x111 * (PAGE_OFFSET >> 28))) >> + lis r4, (PAGE_OFFSET >> 16) > > This is not enough I think. You need to load ctr with the number of=20 > segments you want to populate. Here above it is hardcoded to 4. Ok, trying this one now --- a/arch/powerpc/kvm/book3s_32_sr.S +++ b/arch/powerpc/kvm/book3s_32_sr.S @@ -107,14 +107,12 @@ KVM_LOAD_BAT(2, r9, r10, r11) KVM_LOAD_BAT(3, r9, r10, r11) =20 - /* Restore Segment Registers */ - - /* 0xc - 0xf */ - - li r0, 4 + /* Restore Segment Registers, assumes PAGE_OFFSET is segment ali= gned */ + li r0, (0x100000000 - PAGE_OFFSET) >> 28 mtctr r0 - LOAD_REG_IMMEDIATE(r3, 0x20000000 | (0x111 * 0xc)) - lis r4, 0xc000 + LOAD_REG_IMMEDIATE(r3, 0x20000000 | (0x111 * (PAGE_OFFSET >> 28)= )) + + lis r4, PAGE_OFFSET@h 3: mtsrin r3, r4 addi r3, r3, 0x111 /* increment VSID */ addis r4, r4, 0x1000 /* address of next segment */ >> /* Restore host IVPR before re-enabling interrupts. We cheat and k= now >> - * that Linux IVPR is always 0xc0000000. */ >> - lis r3, 0xc000 >> + * that Linux IVPR is always PAGE_OFFSET. */ >> + lis r3, PAGE_OFFSET >> 16 > > Maybe use PAGE_OFFSET@h instead of PAGE_OFFSET >> 16. > >> mtspr SPRN_IVPR, r3 > > That's probably valid but wouldn't it be more correct to use=20 > interrupt_base@h as in head_44x.S and head_85xx.S : > > lis r4,interrupt_base@h /* IVPR only uses the high 16-bits */ > mtspr SPRN_IVPR,r4 Ok, copying that version now: --- a/arch/powerpc/kvm/booke_interrupts.S +++ b/arch/powerpc/kvm/booke_interrupts.S @@ -229,9 +229,8 @@ _GLOBAL(kvmppc_resume_host) mtspr SPRN_PID1, r3 #endif =20 - /* Restore host IVPR before re-enabling interrupts. We cheat and= know - * that Linux IVPR is always PAGE_OFFSET. */ - lis r3, PAGE_OFFSET >> 16 + /* Restore host IVPR before re-enabling interrupts. */ + lis r3, interrupt_base@h /* IVPR only uses the high 16-bi= ts */ mtspr SPRN_IVPR, r3 =20 /* Switch to kernel stack and jump to handler. */ >> @@ -115,7 +115,8 @@ static u32 get_host_mas0(unsigned long eaddr) >> mtspr(SPRN_MAS6, 0); >> mas4 =3D mfspr(SPRN_MAS4); >> mtspr(SPRN_MAS4, mas4 & ~MAS4_TLBSEL_MASK); >> - asm volatile("tlbsx 0, %0" : : "b" (eaddr & ~CONFIG_PAGE_OFFSET)); >> + asm volatile("tlbsx 0, %0" : >> + : "b" (eaddr & (rounddown_pow_of_two(PAGE_OFFSET)-1))); > > I think this is not valid. > > With PAGE_OFFSET equal to 0xc0000000, > > Before: > > eaddr & 0x3fffffff > > Now: > > eaddr & (0x80000000 - 1) =3D eaddr & 0x7fffffff I'm probably still misunderstanding the intention of this code then, my reading of the comment was that both 0x3fffffff and 0x7fffffff would be valid choices here as both are below PAGE_OFFSET and large enough to alias the correct set. What are the actual requirements for the mask? Thanks for looking at these bits in detail, I'm quite out of my comfort zone here, especially with the book-e stuff. Arnd