From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Alexey Klimov" <alexey.klimov@linaro.org>,
olivia@selenic.com, herbert@gondor.apana.org.au,
sehi.kim@samsung.com, linux-samsung-soc@vger.kernel.org,
peter.griffin@linaro.org,
"Łukasz Stelmach" <l.stelmach@samsung.com>
Cc: alim.akhtar@samsung.com, linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-team@android.com,
andre.draszik@linaro.org, willmcvicker@google.com,
saravanak@google.com, elder@linaro.org, tudor.ambarus@linaro.org,
klimov.linux@gmail.com
Subject: Re: [PATCH REVIEW] hwrng: add exynos Secure World RNG device driver
Date: Thu, 28 Mar 2024 18:01:11 +0100 [thread overview]
Message-ID: <83607b46-56e4-45eb-ac69-9bc5be5bdee4@linaro.org> (raw)
In-Reply-To: <6b691a48-ca97-4f23-a09f-69b9254f0c11@linaro.org>
On 28/03/2024 14:36, Krzysztof Kozlowski wrote:
>> +
>> +static UNIVERSAL_DEV_PM_OPS(exyswd_rng_pm_ops, exyswd_rng_suspend,
>> + exyswd_rng_resume, NULL);
>> +
>> +static struct platform_driver exyswd_rng_driver = {
>> + .probe = exyswd_rng_probe,
>> + .remove = exyswd_rng_remove,
>> + .driver = {
>> + .name = DRVNAME,
>> + .owner = THIS_MODULE,
>
> So this was fixed ~8-10 years ago. Yet it re-appears. Please do not use
> downstream code as template.
>
> Take upstream driver and either change it or customize it.
Alex Elder pointed out that some of my comments might not be precise or
not helping enough. Let me clarify then:
Please run all standard, open-source tools when submitting new driver,
which is:
1. Coccinelle, which points to this specific line since 2014,
2. smatch,
3. sparse,
4. checkpatch,
5. If changing bindings: dt_binding_check,
6. If changing DTS or bindings: dtbs_check.
I still did not point to specific error I see, because I would like you
to setup the tools and find it. This way you will have toolset ready for
any other submissions. I hope this will be helpful.
Thank you for your contribution.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-03-28 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 12:50 [PATCH REVIEW] hwrng: add exynos Secure World RNG device driver Alexey Klimov
2024-03-28 13:36 ` Krzysztof Kozlowski
2024-03-28 17:01 ` Krzysztof Kozlowski [this message]
2024-03-28 17:05 ` Krzysztof Kozlowski
2024-03-29 7:55 ` Gowthami Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83607b46-56e4-45eb-ac69-9bc5be5bdee4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexey.klimov@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=elder@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-team@android.com \
--cc=klimov.linux@gmail.com \
--cc=l.stelmach@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olivia@selenic.com \
--cc=peter.griffin@linaro.org \
--cc=saravanak@google.com \
--cc=sehi.kim@samsung.com \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox