From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F788C3ABC3 for ; Mon, 12 May 2025 12:10:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wdJlzktGGrJqFesVqic51nFN+xlPwzqlSYZMp8S0TxI=; b=w1aePPCpjV5S3mHk0rRxyRxChe SDAqeAN6JPyPSFERTB0mQH0ecJ9LXvj/O0jpEn/4VNz/LPAV6InV/TdZV8wE7VJgeClg1/FohXZq2 lT3IVJawvH3TWbyavk0nXGbfQtAKGNLWxhoGIcC9AhmqFgZFszM+F36H+UgT19RWToPB7+VWpoLdb CUApO6XeZp8ljF9wnFiz1FQ+YCoGcchukeqxYnAgEgRkNxw8pMl7GQO8kt2rVdjp7W4tzVciTI9We ybMmUVkExnYk8Mlfe6j4ToIGCnCwkDxHWyp9gwaeQCqLUp9VsYLxbK3yqtDS8l0aupvbwYrBamJTD 61zBUY+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uERyt-00000009Lfx-079a; Mon, 12 May 2025 12:10:03 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uERup-00000009KqB-3UW6 for linux-arm-kernel@lists.infradead.org; Mon, 12 May 2025 12:05:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747051550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wdJlzktGGrJqFesVqic51nFN+xlPwzqlSYZMp8S0TxI=; b=ga3hbYI0WOQkoVq+oUOKoATenGHOHkeqv2IN2WpJRdDX6qpy8sL0PwnDzs7V0GKb1YEAqJ Xo5p0YrAQdbcOLXgaJEmrqyrgb2/Bcd7yEEVxL1v6nMEHXP7cUY9EkOFx8W6zQ0GSE+fAF qU4IOOEt/y9fJHu45+OaLbR0eKMpVBQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-uyn6xxrXNReCTOuDDcFZOg-1; Mon, 12 May 2025 08:05:48 -0400 X-MC-Unique: uyn6xxrXNReCTOuDDcFZOg-1 X-Mimecast-MFC-AGG-ID: uyn6xxrXNReCTOuDDcFZOg_1747051547 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a0b7ceaa20so1392775f8f.1 for ; Mon, 12 May 2025 05:05:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747051547; x=1747656347; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=wdJlzktGGrJqFesVqic51nFN+xlPwzqlSYZMp8S0TxI=; b=g1nJ/X62gkPveij23mJu4sQDd6ukk1QhHmzVqjhj8u6dNNprYZvjUPl/SqVnQ8mkyW YCeDby4yLmGmNPDX7rFjAYwhHt9CdWtV99Gv/IRNXaZycrDZ9KG9aivGd7mgb7okBKYX zceVA06FsNG4mv97ZtuZiGVHB/Ok4xDrm+w3F6BmGKi0/0dYru5ozqXIt4FYhmwO5qoU dtj53F8UZR0TT6F1tjvPWWZ1Fhx5X4zxIb5GfRdsOd2cXyEkZZcPK/TjMjOScecxCnph nzMFCL5n7KN9RxL21AVjqDHUHsAwY9LivYqxHchuCjQ1hBPBOxo5+x57lOduTELPOnDy uU/A== X-Gm-Message-State: AOJu0YzH4W7QaZ0Uq0NZpj3SBAByPcxqNiSjAMwajxandJkWYDUo6w1M WkCLIC39JA8yZQmR29vnlD4Iw+DwvxncNF76EwuWnHqvEY5ufrgUU9w+bQQe9ctgI8wXYC8MG1t Mm7jE3HSuXLxaBSSOcKEJ/4xvpyJ83coy+TlBhGGVgtlcYHGf7PyKBekTNGjFCZ1GLkDgRBI3 X-Gm-Gg: ASbGncu9Jm/Zm2n7Y3NhKhDPA+Ia5S4YdqLbvCQ91yefuLDHuChenZOpCjqHZpxSqwl NhwOckADrB4TtCD/W8OnU1bstUjJ6kip0949Gdh7wVp8DguuRIgGafhYY92fphfU9pl6Z+dWPQ9 9te90u32wRNFD+RYFUkCDVKup+pU82R+ugM43wsAnD0NMDt1dIpeoiN2UqMLavZfGCN/G2bTFZY Dd37ggfwsks3hbBgbjqToPFEvsPimyE0HPAEQBe1a08NHlfFtgucUYyzKp3qSXbhybP7wLy0Cdt j00uV20g8L7XSMjA4PO2oCllxnnVzjg33rwIvqKAWUJ5eCdqGKmDrH+Q/NiS3R+PIsS2gsjzeTa fSGBc5SDIF7OPkVzmMAC0KMiwh5I9ts7vQbff1y0= X-Received: by 2002:a05:6000:2a1:b0:3a0:b733:f262 with SMTP id ffacd0b85a97d-3a1f64ab58bmr10472085f8f.51.1747051547081; Mon, 12 May 2025 05:05:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFASPPotExaPDA1hbZyCJdrcf7Y8GXHdAS7ODG1uszxEfWE0IHpAxbF5G0Tk+V/yx8Uk0/lbA== X-Received: by 2002:a05:6000:2a1:b0:3a0:b733:f262 with SMTP id ffacd0b85a97d-3a1f64ab58bmr10472042f8f.51.1747051546618; Mon, 12 May 2025 05:05:46 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4a:5800:f1ae:8e20:d7f4:51b0? (p200300d82f4a5800f1ae8e20d7f451b0.dip0.t-ipconnect.de. [2003:d8:2f4a:5800:f1ae:8e20:d7f4:51b0]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f57de100sm12085800f8f.2.2025.05.12.05.05.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 May 2025 05:05:46 -0700 (PDT) Message-ID: <836f2574-cb60-44c5-865c-7f13a90779ec@redhat.com> Date: Mon, 12 May 2025 14:05:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64/mm: Disable barrier batching in interrupt contexts To: Ryan Roberts , Catalin Marinas , Will Deacon , Pasha Tatashin , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzbot+5c0d9392e042f41d45c5@syzkaller.appspotmail.com References: <20250512102242.4156463-1-ryan.roberts@arm.com> <001dfd4f-27f2-407f-bd1c-21928a754342@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: miyjuWzpP57grYyBJTPivkyUW9J2_JIblSwl-f85H88_1747051547 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250512_050551_942416_0D46C1DD X-CRM114-Status: GOOD ( 22.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >>>   static inline void arch_leave_lazy_mmu_mode(void) >>>   { >>> +    if (in_interrupt()) >>> +        return; >>> + >>>       arch_flush_lazy_mmu_mode(); >>>       clear_thread_flag(TIF_LAZY_MMU); >>>   } >> >> I guess in all cases we could optimize out the in_interrupt() check on !debug >> configs. > > I think that assumes we can easily and accurately identify all configs that > cause this? We've identified 2 but I'm not confident that it's a full list. Agreed. I was wondering if we could convert the ones to use different pte helpers, whereby these helpers would not be available without CONFIG_WHATEVER. Then, make these features select CONFIG_WHATEVER. VM_WARN_ON_* would be used to catch any violations / wrong use of pte helpers. > Also, KFENCE isn't really a debug config (despite me calling it that in the > commit log) - it's supposed to be something that can be enabled in production > builds. Agreed. Even Fedora has it. > >> >> Hm, maybe there is an elegant way to catch all of these "problematic" users? > > I'm all ears if you have any suggestions? :) > > > It actaully looks like x86/XEN tries to solves this problem in a similar way: Heh, yes. Good old xen ... > > enum xen_lazy_mode xen_get_lazy_mode(void) > { > if (in_interrupt()) > return XEN_LAZY_NONE; > > return this_cpu_read(xen_lazy_mode); > } > > Although I'm not convinced it's fully robust. It also has: > > static inline void enter_lazy(enum xen_lazy_mode mode) > { > BUG_ON(this_cpu_read(xen_lazy_mode) != XEN_LAZY_NONE); > > this_cpu_write(xen_lazy_mode, mode); > } > > which is called as part of its arch_enter_lazy_mmu_mode() implementation. If a > task was already in lazy mmu mode when an interrupt comes in and causes the > nested arch_enter_lazy_mmu_mode() that we saw in this bug report, surely that > BUG_ON() should trigger? Hm, good point. But that code is old, so probably something seems to be preventing that? In any case, just a thought on the in_interrupt() check, I think this commit is good enough as is. -- Cheers, David / dhildenb