From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BDDAC48292 for ; Mon, 5 Feb 2024 18:27:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CEda3UU1Fpw6QIkBISWSWQ6SgcRSl8JyHVdNNnCwX4Y=; b=DuMij0ZYYcTpoG Ojta/ieC+ar4YvyWUXkYD5hZvsPDKIoSN/AlHjG0Y7ki1JMz5Vbi5vvpTaYx+Q7ZHIKlwnmgK8vXc jO+rMMR/NmfoMaYhmfyH0YMij12t1MoOUifZGprp9qUqbtETTLh+CyC0qkANfgeJ1IB7RfIl1/KGp FI+UxYGBzyJ5KBii0aqXl/Anp3govswIGGWssC/A3JGMHvluVnsykVJkcm2eFUjkng4m1f2NG+pmJ EitQ7/Z3bs4rsNuAgYsjmjGp7FyBn8xOMUH2xBfGKfUQS+JqvzmaLYTV0wQWochS0CwoRFK7ChGtM N+oRG/aSFdZUt+6uXa6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rX3gA-00000004MTQ-2rna; Mon, 05 Feb 2024 18:26:50 +0000 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rX3g7-00000004MSf-21AX for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 18:26:48 +0000 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-40fdb18ffc7so11565905e9.1 for ; Mon, 05 Feb 2024 10:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707157606; x=1707762406; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=htnHzi3tYpUcAcax9Oehk8o5es8Q9nPqVSuo3cjUUGU=; b=CwDPB0ScOVp4HKnhmoUF3yqMDb58veai9uA25ect/VeGXcixcLdnph+zwD0VPzIB7k 9GSD4WollM3iUrMngMwbcu8m4i+ax6Q+/p4IHfUMXlpkvZQQMh0tCPU+tkM5OM60jzEO Sy4VzogahYmHUH8aT70dtXknM1e3BSi1pM6v2tdQ8v4PPFj1tvMsyvuCJppwsUuUJk70 +7avvfncq4KdUGKMu7exNRzOLGj8icg1/cmKCNicDRrP4USU0IqmSUNHO6xsptH2yZji hoGVYJ8vTCMvnN3TjhTPkbqm8FyLWCflRmADJVIcw/NTABDhfwzenktmsgQmay2x4DiO zh9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707157606; x=1707762406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=htnHzi3tYpUcAcax9Oehk8o5es8Q9nPqVSuo3cjUUGU=; b=PLz2UVFfuP/weaC4lepSSXp/1Qbrnx2xOWBNYva5ZHaZsEKmcelM52ecuPIhtMLzb+ Up4rlXWVid3+NioMROcIHZJRom6/hPIDkjduTPR1FeT1xdNJFdSdz9+zmdZ507t9VpcO JjdYKyOgRkQT/3K/bSqVsQM/wntswkD6JEq4vQPfuLPJfRTNZFFqrxd+KFNDWSjIneAo 0MOTeNUCraZh097jO360nlde+DcASSqgBd6Y3vaYZ9UbDOJl03azPBQ+iO+YuJpcc8Ie kZ7DNB8CxmFGxzFM8j/FnseddEhAsgRKbEiuyBxCbHMuxhkwDpsgQLBCDF5htPdm/5OX wiiw== X-Gm-Message-State: AOJu0YxYtd2KuGNDAuVgUkDq2BtqBM8ecWGwJsCwWg1+90d7sa+cR0Xo S58OsDetnzIRFn8miBo9DZiv3YDDypEdPJlvHDzZSqi1sWEuKR+a X-Google-Smtp-Source: AGHT+IH6pzS+IInTWVn7w59ky+Wlg99QOSRBzzf1n7yhhA/HlTNk3TE1U1UHdYIHMwb4Ko/p8+4j6Q== X-Received: by 2002:a05:600c:34c1:b0:40f:afe1:c9f8 with SMTP id d1-20020a05600c34c100b0040fafe1c9f8mr417092wmq.12.1707157606004; Mon, 05 Feb 2024 10:26:46 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUflLI3w/4X1P/D7ar2lgRwUSNe/Xru+Ga7BxWIpMyTmzBj5kwxROHOXKM18YZtZwbJgY3rzK/dojaOKtjV/Qf/XWKPSTMiDYnH+sxUL7c7o8AfriEYr8vBxr5hLlKrhHFhe1/0iB6S19mf7QoPFLNfNN0WiyaswQ4ZLhK77Qj6dqL4KgAz7Krkl6odaQInzbUvFKFIrHgrWJDIMsXeWNARhA515HjaYCZ+c3Lr5GpaI4pwFl/yGBqv/Q829+Pu0wkV54kTdzPRHIMonSr+IIQ2p9cSiPIjn7/gXC5rJ8wmYbTOvIznvSbLPrBOIk+4Cs06JZm4sFWEmDfeX+kgyykqrw== Received: from jernej-laptop.localnet (82-149-13-182.dynamic.telemach.net. [82.149.13.182]) by smtp.gmail.com with ESMTPSA id y8-20020adffa48000000b0033af670213dsm178914wrr.110.2024.02.05.10.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 10:26:45 -0800 (PST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andre Przywara Cc: linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Nick Alilovic Subject: Re: [PATCH 2/2] arm64: dts: allwinner: Transpeed 8K618-T: add WiFi nodes Date: Mon, 05 Feb 2024 19:26:44 +0100 Message-ID: <8371906.NyiUUSuA9g@jernej-laptop> In-Reply-To: <20240204093255.148972-3-andre.przywara@arm.com> References: <20240204093255.148972-1-andre.przywara@arm.com> <20240204093255.148972-3-andre.przywara@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_102647_555007_0F79ECD0 X-CRM114-Status: GOOD ( 17.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dne nedelja, 04. februar 2024 ob 10:32:55 CET je Andre Przywara napisal(a): > In contrast to other devices using Allwinner SoCs, the Transpeed 8K618-T > TV box uses a mainline supported WiFi chip: it's a Broadcom 4335 > compatible, packaged by a company called Murata. > It works nicely with the Linux driver, when providing the respective > firmware files. > > Add the required DT nodes to let the kernel find the SDIO device. Can you reword message in a way to omit Linux? > > Signed-off-by: Andre Przywara > --- > .../sun50i-h618-transpeed-8k618-t.dts | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts b/arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts > index 8ea1fd41aeba..7ec4098e707b 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h618-transpeed-8k618-t.dts > @@ -16,6 +16,7 @@ / { > > aliases { > serial0 = &uart0; > + ethernet1 = &sdio_wifi; > }; > > chosen { > @@ -39,6 +40,15 @@ reg_vcc3v3: vcc3v3 { > regulator-max-microvolt = <3300000>; > regulator-always-on; > }; > + > + wifi_pwrseq: wifi_pwrseq { > + compatible = "mmc-pwrseq-simple"; > + clocks = <&rtc CLK_OSC32K_FANOUT>; > + clock-names = "ext_clock"; > + pinctrl-0 = <&x32clk_fanout_pin>; > + pinctrl-names = "default"; > + reset-gpios = <&pio 6 18 GPIO_ACTIVE_LOW>; /* PG18 */ > + }; > }; > > &ehci0 { > @@ -60,6 +70,19 @@ &mmc0 { > status = "okay"; > }; > > +&mmc1 { > + vmmc-supply = <®_dldo1>; > + vqmmc-supply = <®_aldo1>; > + mmc-pwrseq = <&wifi_pwrseq>; > + bus-width = <4>; > + non-removable; > + status = "okay"; > + > + sdio_wifi: wifi@1 { > + reg = <1>; > + }; I don't think this node and alias are useful in any way. SDIO scan will find device regardless and potential mac property set up by bootloader will be ignored anyway. Best regards, Jernej > +}; > + > &mmc2 { > vmmc-supply = <®_dldo1>; > vqmmc-supply = <®_aldo1>; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel