Re: [PATCH v2 3/7] scsi: ufs: core: Fix mcq nr_hw_queues

From: "Powen Kao (高伯文)" <Powen.Kao@mediatek.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"quic_ziqichen@quicinc.com" <quic_ziqichen@quicinc.com>,
	"jejb@linux.ibm.com" <jejb@linux.ibm.com>,
	"avri.altman@wdc.com" <avri.altman@wdc.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Cc: "Peter Wang (王信友)" <peter.wang@mediatek.com>,
	"Eddie Huang (黃智傑)" <eddie.huang@mediatek.com>,
	"Jiajie Hao (郝加节)" <jiajie.hao@mediatek.com>,
	"CC Chou (周志杰)" <cc.chou@mediatek.com>,
	"Alice Chao (趙珮均)" <Alice.Chao@mediatek.com>,
	wsd_upstream <wsd_upstream@mediatek.com>,
	"Chun-Hung Wu (巫駿宏)" <Chun-hung.Wu@mediatek.com>,
	"quic_asutoshd@quicinc.com" <quic_asutoshd@quicinc.com>,
	"Chaotian Jing (井朝天)" <Chaotian.Jing@mediatek.com>,
	"Naomi Chu (朱詠田)" <Naomi.Chu@mediatek.com>,
	"Stanley Chu (朱原陞)" <stanley.chu@mediatek.com>,
	"Mason Zhang (章辉)" <Mason.Zhang@mediatek.com>,
	"quic_cang@quicinc.com" <quic_cang@quicinc.com>
Subject: Re: [PATCH v2 3/7] scsi: ufs: core: Fix mcq nr_hw_queues
Date: Thu, 23 Feb 2023 14:43:20 +0000	[thread overview]
Message-ID: <83980495ec156da33ca8e394c193cf3cb15aa318.camel@mediatek.com> (raw)
In-Reply-To: <58244768-33ad-21d6-d88d-93e7fdd0ba27@quicinc.com>

Okay, I will add a comment here in next update. :)

On Thu, 2023-02-23 at 18:32 +0800, Ziqi Chen wrote:
> Hi Po-Wen,
> 
> On 2/22/2023 11:04 AM, Po-Wen Kao wrote:
> > Need to add one to MAXQ to obtain number of hardware queue.
> > 
> > Signed-off-by: Po-Wen Kao <powen.kao@mediatek.com>
> > ---
> >   drivers/ufs/core/ufs-mcq.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-
> > mcq.c
> > index a39746b2a8be..5d5bc0bc6e88 100644
> > --- a/drivers/ufs/core/ufs-mcq.c
> > +++ b/drivers/ufs/core/ufs-mcq.c
> > @@ -150,7 +150,7 @@ static int ufshcd_mcq_config_nr_queues(struct
> > ufs_hba *hba)
> >   	u32 hba_maxq, rem, tot_queues;
> >   	struct Scsi_Host *host = hba->host;
> >   
> > -	hba_maxq = FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities);
> > +	hba_maxq = FIELD_GET(MAX_QUEUE_SUP, hba->mcq_capabilities) + 1
> > ;
> 
> Can we add one line comment why need to  add one to hba_maxq  here or
> in 
> commit message?
> >   
> >   	tot_queues = UFS_MCQ_NUM_DEV_CMD_QUEUES + read_queues +
> > poll_queues +
> >   			rw_queues;
> 
> Best Regards.
> 
> Ziqi
> 
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel