From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23798C52D6F for ; Wed, 21 Aug 2024 08:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=me2bazh1+XWM3oC6fY5BIO7VytdUgoc5JECJvjoPUzo=; b=gpkXJnkUENGNJanUaItJvwiiDS WW1fq1YE0/bGAPigk56IcEaYic4AFwJxnBcE/QzIJVF+vjUXeo+Bens+qMs75fz4Jjpc/pIYawXmt 2MSZmU27n00DjfuixMo6YsxpRWfFwb/g9FuiC6MBKM4hBIhv2XOtq9rlCiuDWhx8VUg7pLd90wU4z GgLsHs3Onr1gLhCaz8tbavaNUSiDuwCYUKXvplmz0/eRncBmTtUbLs2w0L3+JWlnR6lkcFuH3Tq23 khpm7C4vQ5rXA4cZnD45BjVtOF88hKGIBx8BumRZ2I52GEj95p+8JySxktCcblEkyIj9MN6Xdl6RR JNZgMszQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgh74-000000089zz-144r; Wed, 21 Aug 2024 08:54:42 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgh5h-000000089fA-21yz; Wed, 21 Aug 2024 08:53:19 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1724230395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=me2bazh1+XWM3oC6fY5BIO7VytdUgoc5JECJvjoPUzo=; b=ULWCheHThawcPG+AyC/53aQI+sHKckvEBHPdwDjlQDS3N7u4edYLeuV2XTFididXOS2f8O mCeDJS5Q3Buf3Yj/s0AxkoIMPZEagEqboFqCVnd6QijhF8JVGToQs07waDJ7yacEmiFWSz 9jptrljyfbl5a7AbH8neI8Rk962fOEuXhT+VJNStlqb6lpBWe/AuamKmzRJUueMzlddf9C 0XOatZ2wb48e5ML3NmdNRn7vLu1bETbQjK4N8WWj+2OlfEISqswUNLrqqPd53ev4GhNtEY sQaXMAnVPpJo/B0VHpbM98QqERp4ildDkw4inNxaQ55nNypq+MyYQVHZr6q2Lw== Date: Wed, 21 Aug 2024 10:53:14 +0200 From: Dragan Simic To: =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, vkoul@kernel.org, kishon@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] phy: phy-rockchip-inno-usb2: Perform trivial code cleanups In-Reply-To: <5307900.6fTUFtlzNn@diego> References: <14167d6b025e18d2a06ee429feea6551ef6f9c44.1724225528.git.dsimic@manjaro.org> <5307900.6fTUFtlzNn@diego> Message-ID: <83a33b5ad6dd13668b6d8733f5546725@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240821_015317_987009_644E67C6 X-CRM114-Status: GOOD ( 11.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Heiko, On 2024-08-21 10:39, Heiko Stübner wrote: > Am Mittwoch, 21. August 2024, 09:37:53 CEST schrieb Dragan Simic: >> Perform a few trivial code cleanups, e.g. to obey the reverse >> Christmas tree >> rule, to avoid use of "{ ... }" code blocks where they aren't really >> needed, >> or to avoid line wrapping by using the 100-column width better. >> >> No intended functional changes are introduced by these code cleanups. >> >> Signed-off-by: Dragan Simic > >> @@ -445,7 +445,6 @@ static int rockchip_usb2phy_extcon_register(struct >> rockchip_usb2phy *rphy) >> } >> >> rphy->edev = edev; >> - >> return 0; >> } > > depending on how nitpicky we want to be, I'm not very fond of this > change. > Assigning the extcon-dev and returning "0" are two different actions, > and > I think most drivers do actually use a blank line between those. > > But that really is just a style preference for me, so anyway > > Reviewed-by: Heiko Stuebner Thanks for your review; I had similar thoughts, believe it or not. :) If there will be v3, I'll bring the empty separator line back.