From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DACDCC282DD for ; Mon, 10 Jun 2019 11:07:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0955206C3 for ; Mon, 10 Jun 2019 11:07:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tiZH9emd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0955206C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EBPmK07Xr4zy/10ok4sDPxd1hrMSwjfgcJ9C1Ms75ps=; b=tiZH9emdwBK5BD 6jJBLSTBtH7amxw4BzUc4/c56CR3taSgUXhYg94QpoBBQUdMzxMX2+26KUqH6tbw6353Gie1pojMg 5bLqnh8ZFS4NsV2YUnK0FViGEi+RlTXIRH/ldbdt8bcz+b5F2Jfx/cXhFQc2rgX3evi2aQQA6GdMA ebeLjkHQHzui92zNseqR/h6/iXm560fEJA+pGTYyxlPWrDLU6olW6Je+eb2mwn0rv7ypc0VcMQnJ6 22zXcvK4SAnc1yaLrmMcaVtZXCLzcxjz9QTIv9fSsv9AjSkCKVo2cdMU0a1Pn/A3hmo3JzEplj0Uz XoEroRxv1mh+4PGpu0dQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haI9Y-0000Sb-Mf; Mon, 10 Jun 2019 11:07:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1haI9V-0000SF-SH for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2019 11:07:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C949C337; Mon, 10 Jun 2019 04:07:48 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3D22E3F557; Mon, 10 Jun 2019 04:09:28 -0700 (PDT) Subject: Re: [PATCH v6 01/19] kernel: Standardize vdso_datapage To: Huw Davies References: <20190530141531.43462-1-vincenzo.frascino@arm.com> <20190530141531.43462-2-vincenzo.frascino@arm.com> <20190610092751.GA11076@merlot.physics.ox.ac.uk> <58cedde2-0d54-7d2d-f519-77cb71f543fd@arm.com> <20190610103151.GD11076@merlot.physics.ox.ac.uk> From: Vincenzo Frascino Message-ID: <83ab2758-0e8c-35d5-906a-0338bcee3310@arm.com> Date: Mon, 10 Jun 2019 12:07:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190610103151.GD11076@merlot.physics.ox.ac.uk> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190610_040749_959871_5292CEF8 X-CRM114-Status: GOOD ( 16.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Shuah Khan , Arnd Bergmann , Catalin Marinas , Daniel Lezcano , Will Deacon , linux-kernel@vger.kernel.org, Ralf Baechle , linux-mips@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Paul Burton , linux-kselftest@vger.kernel.org, Rasmus Villemoes , Russell King , Thomas Gleixner , Mark Salyzyn , Peter Collingbourne , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Huw, On 10/06/2019 11:31, Huw Davies wrote: > On Mon, Jun 10, 2019 at 11:17:48AM +0100, Vincenzo Frascino wrote: >> On 10/06/2019 10:27, Huw Davies wrote: >>> On Thu, May 30, 2019 at 03:15:13PM +0100, Vincenzo Frascino wrote: >>>> --- /dev/null >>>> +++ b/include/vdso/datapage.h >>>> @@ -0,0 +1,91 @@ >>>> +/* SPDX-License-Identifier: GPL-2.0 */ >>>> +#ifndef __VDSO_DATAPAGE_H >>>> +#define __VDSO_DATAPAGE_H >>>> + >>>> +#ifdef __KERNEL__ >>>> + >>>> +#ifndef __ASSEMBLY__ >>>> + >>>> +#include >>>> +#include >>>> +#include >>>> + >>>> +#define VDSO_BASES (CLOCK_TAI + 1) >>>> +#define VDSO_HRES (BIT(CLOCK_REALTIME) | \ >>>> + BIT(CLOCK_MONOTONIC) | \ >>>> + BIT(CLOCK_BOOTTIME) | \ >>>> + BIT(CLOCK_TAI)) >>>> +#define VDSO_COARSE (BIT(CLOCK_REALTIME_COARSE) | \ >>>> + BIT(CLOCK_MONOTONIC_COARSE)) >>>> +#define VDSO_RAW (BIT(CLOCK_MONOTONIC_RAW)) >>>> + >>>> +#define CS_HRES_COARSE 0 >>>> +#define CS_RAW 1 >>> >>> CS_HRES_COARSE seems like a confusing name choice to me. What you >>> really mean is not RAW. >>> >>> How about CS_ADJ to indicate that its updated by adjtime? >>> CS_XTIME might be another option. >>> >> >> I divided the timers in 3 sets (HRES, COARSE, RAW), CS_HRES_COARSE refers to the >> first two and CS_RAW to the third. I will ad a comment to explain the logic in >> the next iteration. > > I'm thinking ahead about a possible CLOCK_MONOTONIC_RAW_COARSE (which > would be useful at least for Wine). In that case you'd have four clock > types non-raw and raw, each with either hres or coarse. > Thanks for this, I was not aware of CLOCK_MONOTONIC_RAW_COARSE. I tried to find, though, some details, but I could not find any. Could you please provide some reference? > Huw. > -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel