From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8403AC282C8 for ; Mon, 28 Jan 2019 16:58:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FDDC20844 for ; Mon, 28 Jan 2019 16:58:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F41m+4Gc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="a1/6DBmz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FDDC20844 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LexPqhNKqxpuGn8wJ3QAxFZOx9mDBbGc9a90M4PSqhY=; b=F41m+4GcaFThvy o8KCV3uqhRFGXFATT5/lRI1a/jVbXvmCHNSdfip5KE/1XOo7/LtqBl/O8f4glc2rHVZOhfOgWIpkn /areaiOZQNMGIEqK8nS262O+STs6yhVZsxRhqLU41IPjtnBbwYIwjJUryWZR3QnfWwRtmmx2KhQAX buJfPWVYrUQq+//g2HeqsX48yhvS7nNOzhEdmm98f9LIqHCE7nO/Je/7gUoS6huR0eIb4C8vTOV+m nApzCrtGoZjYGk99IAeUL/yxgP/EZSlzXSKI+LGtpZ/yWHO/QcCDV5giRuRjx3+RQmJKqf0XRX/nU evKdHrC7OlgF7NN7MrzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1goAFE-0003qX-3S; Mon, 28 Jan 2019 16:58:48 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1goAE8-0001bs-3q for linux-arm-kernel@lists.infradead.org; Mon, 28 Jan 2019 16:58:14 +0000 Received: by mail-wr1-x442.google.com with SMTP id p7so18933861wru.0 for ; Mon, 28 Jan 2019 08:57:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rS+wAcs7Bm9avy47VNmDitmIRYGpaJ2bjTxZr6/JDT4=; b=a1/6DBmzwfklGZu4CiYz1qm0dTUW3dVYXKYbq1cpqfR9zs1eWHbMQ98T6Y3zTOgTxH DozADrfGsN79RbRa1xJusVor5jnGmKM3wKBcYpDwh0DPSbmvqcEeAj1t0g+axmRbnLJr Sqprrjb2gh7Bg1ibtLfWI1qepyxURoR5oJbQc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rS+wAcs7Bm9avy47VNmDitmIRYGpaJ2bjTxZr6/JDT4=; b=CoHAGAnDbU+zTmAb9JHx5dcPK7jRQwv3m9ZM9jiL6Bt70Uduy7fU0JRxWgtsIP7xNl 2cyVsPPAZqb2stPqkq0sRLlvwCPlRlizBzoAa8jZBmde61x9Tsq7vzv2BOiHulvhLjMc PpJrehKXOuOmubLwrW4JEx7q0AS02GdDrFRr8n+15A9Zyub9fCoL6GB1/0HyZw9I+pIv hxuXB4Q8wPgzUR2as1I/RXXDsTbM9/me45olwbojrdWILSdEmI9Gu2eXp6O7roIOrDYi XTpVPZOux7GtWFJYnehRMdtLJMBgkQJIAU27R//mPGg4z/OI7FLQD9f/hnYG5RnM4o7I CpXQ== X-Gm-Message-State: AJcUukc5cIABwWVPGd3zxQrnN3x2wDXPQOfx+9dnsm/8OKSrkAVAA4Di WFs4bk+KQOqMhORoW3eGAzr7EQ== X-Google-Smtp-Source: ALg8bN46w/im9vnt3w51h8H3F9beOiY2dF5/R6IfM2kVdIBnGJhaSCV07YLaO+dmBjToens7DlXRpg== X-Received: by 2002:adf:e78f:: with SMTP id n15mr22889580wrm.115.1548694658292; Mon, 28 Jan 2019 08:57:38 -0800 (PST) Received: from [192.168.1.2] (233.red-81-47-145.staticip.rima-tde.net. [81.47.145.233]) by smtp.gmail.com with ESMTPSA id m4sm170300wmi.3.2019.01.28.08.57.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 08:57:37 -0800 (PST) Subject: Re: [PATCH 04/13] dt-bindings: mailbox: qcom: Add clock-name optional property To: Bjorn Andersson References: <1545039990-19984-1-git-send-email-jorge.ramirez-ortiz@linaro.org> <1545039990-19984-5-git-send-email-jorge.ramirez-ortiz@linaro.org> <20190117064411.GK25498@builder> From: Jorge Ramirez Message-ID: <83e77b69-9a22-641f-ada9-7dac565160e1@linaro.org> Date: Mon, 28 Jan 2019 17:57:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190117064411.GK25498@builder> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190128_085740_627134_8AC5D9C0 X-CRM114-Status: GOOD ( 21.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, heiko@sntech.de, mturquette@baylibre.com, will.deacon@arm.com, david.brown@linaro.org, linux-clk@vger.kernel.org, jassisinghbrar@gmail.com, jagan@amarulasolutions.com, andy.gross@linaro.org, sibis@codeaurora.org, devicetree@vger.kernel.org, arnd@arndb.de, niklas.cassel@linaro.org, robh+dt@kernel.org, horms+renesas@verge.net.au, linux-arm-kernel@lists.infradead.org, olof@lixom.net, sboyd@kernel.org, linux-kernel@vger.kernel.org, amit.kucheria@linaro.org, vkoul@kernel.org, enric.balletbo@collabora.com, georgi.djakov@linaro.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/17/19 07:44, Bjorn Andersson wrote: > On Mon 17 Dec 01:46 PST 2018, Jorge Ramirez-Ortiz wrote: > >> When the APCS clock is registered (platform dependent), it retrieves >> its parent names from hardcoded values in the driver. >> >> The following commit allows the DT node to provide such clock names to >> the platform data based clock driver therefore avoiding having to >> explicitly embed those names in the clock driver source code. >> >> Co-developed-by: Niklas Cassel >> Signed-off-by: Niklas Cassel >> Signed-off-by: Jorge Ramirez-Ortiz >> --- >> .../bindings/mailbox/qcom,apcs-kpss-global.txt | 21 +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt >> index 1232fc9..f252439 100644 >> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt >> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.txt >> @@ -23,6 +23,10 @@ platforms. >> Value type: >> Definition: phandle to the input PLL, which feeds the APCS mux/divider >> >> + Usage: required if #clock-names property is present >> + Value type: >> + Definition: phandles to the two parent clocks of the clock driver. > > I presume you meant to replace the existing definition of "clocks"? I am sorry didn't reply to this earlier. Yes this is not very clear. This is required as an extension to the apcs-msm8916.c driver also used on the qcs404; since it is an extension, the previous definition should still be applicable. In the case of the msm8916 the #clock-names property is NOT necessary (it would be ignored by the driver), so having it should not mean that we need to have #clocks. In the case of the qcs404, having clock-names means that we do need to have #clocks (hence the additional if) and not quite sure how to word this condition in the bindings.. I am going to post v2 with some updates and if required will post a v3 with more clarifications. > > I think the purpose of "required if #clock-cells" comes from that > meaning that it represents a clock-controller if #clock-cells is > specified, in which case it requires the upstream clock(s). > > Regards, > Bjorn > >> + >> - #mbox-cells: >> Usage: required >> Value type: >> @@ -33,6 +37,12 @@ platforms. >> Value type: >> Definition: as described in clock.txt, must be 0 >> >> +- clock-names: >> + Usage: required if the platform data based clock driver needs to >> + retrieve the parent clock names from device tree. >> + This will requires two mandatory clocks to be defined. >> + Value type: >> + Definition: must be "aux" and "pll" >> >> = EXAMPLE >> The following example describes the APCS HMSS found in MSM8996 and part of the >> @@ -65,3 +75,14 @@ Below is another example of the APCS binding on MSM8916 platforms: >> clocks = <&a53pll>; >> #clock-cells = <0>; >> }; >> + >> +Below is another example of the APCS binding on QCS404 platforms: >> + >> + apcs_glb: mailbox@b011000 { >> + compatible = "qcom,qcs404-apcs-apps-global", "syscon"; >> + reg = <0x0b011000 0x1000>; >> + #mbox-cells = <1>; >> + clocks = <&gcc GCC_GPLL0_AO_OUT_MAIN>, <&apcs_hfpll>; >> + clock-names = "aux", "pll"; >> + #clock-cells = <0>; >> + }; >> -- >> 2.7.4 >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel