From: Paolo Bonzini <pbonzini@redhat.com>
To: Jianyong Wu <jianyong.wu@arm.com>,
netdev@vger.kernel.org, yangbo.lu@nxp.com,
john.stultz@linaro.org, tglx@linutronix.de,
sean.j.christopherson@intel.com, maz@kernel.org,
richardcochran@gmail.com, Mark.Rutland@arm.com,
Will.Deacon@arm.com, suzuki.poulose@arm.com
Cc: justin.he@arm.com, kvm@vger.kernel.org, Steve.Capper@arm.com,
linux-kernel@vger.kernel.org, Kaly.Xin@arm.com, nd@arm.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm.
Date: Wed, 18 Sep 2019 10:25:37 +0200 [thread overview]
Message-ID: <83ed7fac-277f-a31e-af37-8ec134f39d26@redhat.com> (raw)
In-Reply-To: <20190918080716.64242-5-jianyong.wu@arm.com>
On 18/09/19 10:07, Jianyong Wu wrote:
> + case ARM_SMCCC_VENDOR_HYP_KVM_PTP_FUNC_ID:
> + getnstimeofday(ts);
This is not Y2038-safe. Please use ktime_get_real_ts64 instead, and
split the 64-bit seconds value between val[0] and val[1].
However, it seems to me that the new function is not needed and you can
just use ktime_get_snapshot. You'll get the time in
systime_snapshot->real and the cycles value in systime_snapshot->cycles.
> + get_current_counterval(&sc);
> + val[0] = ts->tv_sec;
> + val[1] = ts->tv_nsec;
> + val[2] = sc.cycles;
> + val[3] = 0;
> + break;
This should return a guest-cycles value. If the cycles values always
the same between the host and the guest on ARM, then okay. If not, you
have to apply whatever offset exists.
Thanks,
Paolo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-18 8:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 8:07 [RFC PATCH v3 0/6] Enable ptp_kvm for arm64 Jianyong Wu
2019-09-18 8:07 ` [RFC PATCH v3 1/6] psci: Export psci_ops.conduit symbol as modules will use it Jianyong Wu
2019-09-18 8:07 ` [RFC PATCH v3 2/6] ptp: Reorganize ptp_kvm modules to make it arch-independent Jianyong Wu
2019-09-18 8:07 ` [RFC PATCH v3 3/6] timekeeping: Expose API allowing retrival of current clocksource and counter value Jianyong Wu
2019-09-18 8:29 ` Paolo Bonzini
2019-09-18 8:07 ` [RFC PATCH v3 4/6] psci: Add hvc call service for ptp_kvm Jianyong Wu
2019-09-18 8:25 ` Paolo Bonzini [this message]
2019-09-18 9:57 ` Jianyong Wu (Arm Technology China)
2019-09-18 10:23 ` Paolo Bonzini
2019-09-19 9:46 ` Jianyong Wu (Arm Technology China)
2019-09-19 11:07 ` Paolo Bonzini
2019-09-19 11:39 ` Marc Zyngier
2019-09-19 12:13 ` Paolo Bonzini
2019-09-23 3:19 ` Jianyong Wu (Arm Technology China)
2019-10-09 5:21 ` Jianyong Wu (Arm Technology China)
2019-10-09 6:36 ` Paolo Bonzini
2019-10-09 8:18 ` Jianyong Wu (Arm Technology China)
2019-10-09 9:13 ` Paolo Bonzini
2019-10-09 16:05 ` John Stultz
2019-10-09 16:05 ` John Stultz
2019-10-09 20:56 ` Paolo Bonzini
2019-10-14 5:50 ` Jianyong Wu (Arm Technology China)
2019-10-14 6:58 ` Paolo Bonzini
2019-09-23 4:57 ` Jianyong Wu (Arm Technology China)
2019-09-24 14:20 ` Paolo Bonzini
2019-09-25 10:27 ` Jianyong Wu (Arm Technology China)
2019-09-18 8:07 ` [RFC PATCH v3 5/6] ptp: arm64: Enable ptp_kvm for arm64 Jianyong Wu
2019-09-18 8:07 ` [RFC PATCH v3 6/6] kvm: arm64: Add capability check extension for ptp_kvm Jianyong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ed7fac-277f-a31e-af37-8ec134f39d26@redhat.com \
--to=pbonzini@redhat.com \
--cc=Kaly.Xin@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=Steve.Capper@arm.com \
--cc=Will.Deacon@arm.com \
--cc=jianyong.wu@arm.com \
--cc=john.stultz@linaro.org \
--cc=justin.he@arm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=nd@arm.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=sean.j.christopherson@intel.com \
--cc=suzuki.poulose@arm.com \
--cc=tglx@linutronix.de \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).