From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Claudiu Beznea <claudiu.beznea@microchip.com>,
mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor.dooley@microchip.com,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/5] dt-bindings: clocks: atmel,at91rm9200-pmc: convert to yaml
Date: Wed, 17 May 2023 16:21:58 +0200 [thread overview]
Message-ID: <83f484ff-f170-6f32-f4b4-9743eb6d0b4c@linaro.org> (raw)
In-Reply-To: <20230517094119.2894220-3-claudiu.beznea@microchip.com>
On 17/05/2023 11:41, Claudiu Beznea wrote:
> Convert Atmel PMC documentation to yaml. Along with it clock names
> were adapted according to the current available device trees as
> different controller versions accept different clock (some of them
> have 3 clocks as input, some has 2 clocks as inputs and some with 2
> input clocks uses different clock names).
Thank you for your patch. There is something to discuss/improve.
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - atmel,at91rm9200-pmc
> + - atmel,at91sam9260-pmc
> + - atmel,at91sam9g20-pmc
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + maxItems: 2
> + clock-names:
> + items:
> + - const: slow_xtal
> + - const: main_xtal
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - atmel,sama5d2-pmc
> + - atmel,sama5d3-pmc
> + - atmel,sama5d4-pmc
> + then:
> + properties:
> + clocks:
> + minItems: 2
> + maxItems: 2
> + clock-names:
> + items:
> + - const: slow_clk
> + - const: main_xtal
This and previous if, should be squashed. You have exactly the same then:.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-17 14:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 9:41 [PATCH v5 0/5] dt-bindings: clocks: at91: convert to yaml Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 1/5] ARM: dts: at91: use clock-controller name for PMC nodes Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 2/5] dt-bindings: clocks: atmel,at91rm9200-pmc: convert to yaml Claudiu Beznea
2023-05-17 12:42 ` Conor Dooley
2023-05-17 14:21 ` Krzysztof Kozlowski [this message]
2023-05-18 6:03 ` Claudiu.Beznea
2023-05-18 7:05 ` Krzysztof Kozlowski
2023-05-17 9:41 ` [PATCH v5 3/5] ARM: dts: at91: at91sam9n12: witch sckc to new clock bindings Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 4/5] ARM: dts: at91: use clock-controller name for sckc nodes Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 5/5] dt-bindings: clocks: at91sam9x5-sckc: convert to yaml Claudiu Beznea
2023-05-17 14:15 ` Krzysztof Kozlowski
2023-05-18 8:31 ` Claudiu.Beznea
2023-05-18 12:11 ` Krzysztof Kozlowski
2023-05-22 13:04 ` [PATCH v5 0/5] dt-bindings: clocks: at91: " Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83f484ff-f170-6f32-f4b4-9743eb6d0b4c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).