From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0EF1CD37AA for ; Tue, 3 Sep 2024 19:49:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject: References:In-Reply-To:Content-Transfer-Encoding:MIME-Version:Content-Type: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wdwXxPmaKM1eVSmmrqNmkgAa7UAnMa1LOrMs5NgX4tU=; b=NXWTcD07Lu6SBq/5CNQAqIcNbg yU2Hmh9hQR9HnWYvKd/wNBwMRuG7Du9PmzFtF8H8RkX8HeEiDFUhhPGQwosQEHVG+gI6ihgB63ER/ pSXT/ROUnyh0rIoPHx5woWXl3EaClWhg8NUtS75R0YZmTsxkHkRX3W+n1Vf+VsovVkSd6AW1A6vke x/QBEn3HBo9hbD6J2Jt23Osph8cIrYyDTctVNFOWMuKGepXZXftLh3qQrTM+Sp9XOHndLyRbxng6A AuEP2xR2DX72jv+47Tx8pOStTC14iODwgW2BlpwyN/h4KpWbRL1kftDaeY348uc7H1G4HfyHCIcH7 4QLjHZNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slZWS-00000001f4i-2wzH; Tue, 03 Sep 2024 19:49:04 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1slZVX-00000001etm-3s1u for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2024 19:48:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AD8965C5440; Tue, 3 Sep 2024 19:48:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6D6BC4CEC4; Tue, 3 Sep 2024 19:48:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725392885; bh=3p0g7g5p3i50KQ2x/lFG1FmicesjihiO7bM0HYwDHBY=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=WaOiBXY/KVKWzml45UCJb+WWIBSw0lvuhE0Mv7k/zWUsAqIsb4Mma5kz3NxWBQ0bq Q5p2ZfbrI+3zDeagmBF4/6SsbBGUnCt9Gb07whtcTgm+Yn9V4kqIHjm2WRtzTCL3Ti etT4gj82eXuH2jyWUUA61XPuxMAYeWXuCztfUklSF0l/KuB+auXZVOC2lwBBoR2ulI 5OnSKLo0z4pYiY++tp1dAgKItd46IXo+cd8RZ7GM6DotjLox9rxNPM1u2FKZ9vOsj6 WrMHdMs4peE8U35yOBAcPUURlOazdQiP08efgujoHR0JylWzVrkkfqi+wYLOQtSJYs z+Y3lm9vigyDA== Message-ID: <83fac884d749bda0cf0b346e4e869bc8.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20240830130218.3377060-8-claudiu.beznea.uj@bp.renesas.com> References: <20240830130218.3377060-1-claudiu.beznea.uj@bp.renesas.com> <20240830130218.3377060-8-claudiu.beznea.uj@bp.renesas.com> Subject: Re: [PATCH v3 07/12] arm64: dts: renesas: r9a08g045: Add VBATTB node From: Stephen Boyd Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea To: Claudiu , alexandre.belloni@bootlin.com, conor+dt@kernel.org, geert+renesas@glider.be, krzk+dt@kernel.org, magnus.damm@gmail.com, mturquette@baylibre.com, p.zabel@pengutronix.de, robh@kernel.org Date: Tue, 03 Sep 2024 12:48:03 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240903_124808_034421_5AC2DA3D X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Claudiu (2024-08-30 06:02:13) > diff --git a/arch/arm64/boot/dts/renesas/r9a08g045.dtsi b/arch/arm64/boot= /dts/renesas/r9a08g045.dtsi > index 067a26a66c24..247fa80a4f53 100644 > --- a/arch/arm64/boot/dts/renesas/r9a08g045.dtsi > +++ b/arch/arm64/boot/dts/renesas/r9a08g045.dtsi > @@ -160,6 +160,18 @@ i2c3: i2c@10090c00 { > status =3D "disabled"; > }; > =20 > + vbattb: vbattb@1005c000 { > + compatible =3D "renesas,r9a08g045-vbattb"; > + reg =3D <0 0x1005c000 0 0x1000>; > + interrupts =3D ; > + clocks =3D <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&= vbattb_xtal>; > + clock-names =3D "bclk", "rtx"; > + #clock-cells =3D <1>; > + power-domains =3D <&cpg>; > + resets =3D <&cpg R9A08G045_VBAT_BRESETN>; > + status =3D "disabled"; > + }; > + > cpg: clock-controller@11010000 { > compatible =3D "renesas,r9a08g045-cpg"; > reg =3D <0 0x11010000 0 0x10000>; > @@ -425,4 +437,11 @@ timer { > interrupt-names =3D "sec-phys", "phys", "virt", "hyp-phys= ", > "hyp-virt"; > }; > + > + vbattb_xtal: vbattb-xtal { The node name should be something like clock- but if the frequency is different per-board then I don't know what should happen here. Can you leave the vbattb_xtal phandle up above and then require the node to be defined in the board with the proper frequency after the dash? > + compatible =3D "fixed-clock"; > + #clock-cells =3D <0>; > + /* This value must be overridden by the board. */ > + clock-frequency =3D <0>;