From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] serial: sirf: make uart register info static
Date: Sat, 25 Jun 2016 23:07:43 +0200 [thread overview]
Message-ID: <8401626.hVVxvI31N9@wuerfel> (raw)
In-Reply-To: <20160625210150.GA3305@kroah.com>
On Saturday, June 25, 2016 2:01:50 PM CEST Greg Kroah-Hartman wrote:
> On Tue, Jun 07, 2016 at 07:06:12PM +0100, Ben Dooks wrote:
> > The driver does not export the two structures that
> > define the uart register mappings outside of the
> > driver, so make them static to avoid the following
> > warnings:
> >
> > drivers/tty/serial/sirfsoc_uart.h:124:30: warning: symbol 'sirfsoc_usp' was not declared. Should it be static?
> > drivers/tty/serial/sirfsoc_uart.h:190:30: warning: symbol 'sirfsoc_uart' was not declared. Should it be static?
> >
> > Note, we don't move these into the driver .c file as this would
> > be a larger change. However they really should not belong in the
> > header file like this.
>
> Please do the correct thing here and move them into the .c file.
I guess the entire sirfsoc_uart.h file can just get moved in there,
nothing else includes it (obviously, as the symbols above would
otherwise clash).
Arnd
next prev parent reply other threads:[~2016-06-25 21:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 18:06 [PATCH 1/2] serial: sirf: make fifo functions static Ben Dooks
2016-06-07 18:06 ` [PATCH 2/2] serial: sirf: make uart register info static Ben Dooks
2016-06-25 21:01 ` Greg Kroah-Hartman
2016-06-25 21:07 ` Arnd Bergmann [this message]
2016-06-27 9:25 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8401626.hVVxvI31N9@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox