From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09FD0C0218D for ; Wed, 29 Jan 2025 10:46:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yWrkOMQp0EgA1n2/2fll/3eIYbXZEI0l3kIseupr1do=; b=f+liir3mSYCzlD u3CtqtQcmeklRxPr8j90OUtu9zAU/5BS5g9zTxoUsZgx2yPBm+/KKKVu1Rjf3GdtNPCeMqtmkcsOy gQb2FaTonT/stXMKaMrKz9PLkPutqvYdyNTEU8cHXY+W0ZErkeudeh9KI3EHiEprEPlPUWtmVnaaX xQ4ve5aeNuIMqAWcoSQViNsaoXU9X96CZERAzzFyFdietNsr7E+lsm3ERlNa9FAZNP0KsNAYwEVW6 JKiMpEikZubUtgDMXJn5BlA+LMMVETmGHKAB5otDG8ONWMbbjstuZjzLDdyoYROMu038Q3UJ5uODL PHZ5FmHCBYhp1MLRrl+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1td5aZ-00000006lek-0DlX; Wed, 29 Jan 2025 10:46:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1td5YS-00000006lOc-136H for linux-arm-kernel@lists.infradead.org; Wed, 29 Jan 2025 10:44:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738147457; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yWrkOMQp0EgA1n2/2fll/3eIYbXZEI0l3kIseupr1do=; b=DT1Mli4vvSphGLWtdulCl2AC1Y2EEPXg1HhiJ3fQ6E0ygcsOwMIGIlJtY5+NWbrR/hv/Yo fSBrhiTvGLmKAwFHBSagp3vN1l1Ugpl4bQj2iwhel7ySuNJv4dNH2RknBITZmgG54GrqWi er+IjrCLRAEOxHUhyEMAkwxCCPy5IP4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-V4dU5a6gNWmGhdAMCuqevA-1; Wed, 29 Jan 2025 05:44:16 -0500 X-MC-Unique: V4dU5a6gNWmGhdAMCuqevA-1 X-Mimecast-MFC-AGG-ID: V4dU5a6gNWmGhdAMCuqevA Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-436219070b4so31446835e9.1 for ; Wed, 29 Jan 2025 02:44:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738147455; x=1738752255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yWrkOMQp0EgA1n2/2fll/3eIYbXZEI0l3kIseupr1do=; b=N8GkWWiTkpJQ7sEebiXpXUFa0cyhhsY1wjKT/MCjplpTf5HGZFiuKPXD48c1ayue5X wuGB/7KyXM1A2Mz8/SUzuoWtMWKHf+iLrtNgKw+5LHoS9bs1AKxfe+zmnzClyeO1uwL8 ybtNT25z9qH9pp4/ZqazIXyuaUgwgYVkhR7m2Mc2Z6rm45NVeWG26VvXMU+Jlk99km// 5WzYbo0kT7EzmVCFF5cr0V4W5HTnD+cwmpgAaoLDyUPEoQibDBGZ/qp7X7vTt4JMS+bp 1ujN4AULoGs3xMW0zuYt4cMmbdfBAoMXtAxhstzQI7k7afy1h6ujvxYp1u9z0MjeJOTh PwKw== X-Forwarded-Encrypted: i=1; AJvYcCXaHs6GS5aqwBR1SzuCx3G0qYkU4txkkKGX4lFZiZgBKgSIlicbh2NVDZR8x+nJrvAGRXjZmQiJJ+0QJwY1twx5@lists.infradead.org X-Gm-Message-State: AOJu0YyOZXyGUNe4o79h1E3MaYJT16Ga6i1e3EwWy6d71NRK/MfZq03n BszCLXM63s4URk8lTurJK11w5hbEsZcf07XlpeRU0UiZv5XB9e0FODTlZCURO6+UN8NbKCsvIqB 6MfOVJ2BgPVDNLQeIn7qvB7LOmNJMDDvgNGVqm7nRfgn/31nieDiWHo5v/mDH0/AoR/ZqgPyq X-Gm-Gg: ASbGncs1N9ppEGQbzsA+qpX/CnEwDYFyBlkh3xlqV7k2jmDpsIeB07VZdQan4fkEw8p 3qDzR7/SVmkjUQyymtFXuAeSCXXQKbLpAI4IC+nprqkbkaLI8NmicMelPamAMa4mXPpF1lAvje9 eBhFfDDRBVgOdFTVvA5cKTo2ZhWVbizYJhuEirRS0wMH3XAVnmF/tmG7KcbmW6ty2QLlQ4Ha76J HDmYrN7IgYZSs5w/wDVGpQ89RpBeNXCbGXWnxjqn4BOI90Lxq7wsGuFT/9ZVxyVoeUxdVAXzvBy T5+MCET8tmik8Y30gw+dqoBIk51hAs5YIkp2sw57ZOvzNZTt7AO0 X-Received: by 2002:a05:600c:3d9b:b0:434:ff08:202b with SMTP id 5b1f17b1804b1-438dc3c360dmr20853615e9.12.1738147454877; Wed, 29 Jan 2025 02:44:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzPWEOLliL6813Vkt1ndANuVcfYh0Tyo6krKSjX7AbgdnEUM8NRt3/67xnxrixA9ILfXf4Jg== X-Received: by 2002:a05:600c:3d9b:b0:434:ff08:202b with SMTP id 5b1f17b1804b1-438dc3c360dmr20853365e9.12.1738147454482; Wed, 29 Jan 2025 02:44:14 -0800 (PST) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438dcc2f73asm18251195e9.24.2025.01.29.02.44.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2025 02:44:13 -0800 (PST) Message-ID: <840e41b8-15c7-4c4f-a503-818fb4729913@redhat.com> Date: Wed, 29 Jan 2025 11:44:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFCv2 02/13] genirq/msi: Rename iommu_dma_compose_msi_msg() to msi_msg_set_msi_addr() To: Jason Gunthorpe Cc: Nicolin Chen , will@kernel.org, robin.murphy@arm.com, kevin.tian@intel.com, tglx@linutronix.de, maz@kernel.org, alex.williamson@redhat.com, joro@8bytes.org, shuah@kernel.org, reinette.chatre@intel.com, yebin10@huawei.com, apatel@ventanamicro.com, shivamurthy.shastri@linutronix.de, bhelgaas@google.com, anna-maria@linutronix.de, yury.norov@gmail.com, nipun.gupta@amd.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, patches@lists.linux.dev, jean-philippe@linaro.org, mdf@kernel.org, mshavit@google.com, shameerali.kolothum.thodi@huawei.com, smostafa@google.com, ddutile@redhat.com References: <242034456c0bfcd7ecf75cb29d8e5c99db0675d6.1736550979.git.nicolinc@nvidia.com> <20250123185002.GV5556@nvidia.com> From: Eric Auger In-Reply-To: <20250123185002.GV5556@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: XD84rGbt7gNMYMXiiB6L-iRzp1alxX-yCONEVm82dcw_1738147455 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250129_024420_366195_889F8FB5 X-CRM114-Status: UNSURE ( 9.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: eric.auger@redhat.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jason, On 1/23/25 7:50 PM, Jason Gunthorpe wrote: > On Thu, Jan 23, 2025 at 06:10:54PM +0100, Eric Auger wrote: > >>> -/** >>> - * iommu_dma_compose_msi_msg() - Apply translation to an MSI message >>> - * @desc: MSI descriptor prepared by iommu_dma_prepare_msi() >>> - * @msg: MSI message containing target physical address >>> - */ >>> -static inline void iommu_dma_compose_msi_msg(struct msi_desc *desc, >>> - struct msi_msg *msg) >>> +static inline void msi_msg_set_msi_addr(struct msi_desc *desc, >>> + struct msi_msg *msg, u64 msi_addr) >> nit: msi_msg_set_addr(ess) may be enough as the populated fields are >> address_lo/hi > Not sure I follow, you suggest to use msi_msg_set_addr() as the > function name? Seems Ok Yes my minor point was just about removing the "msi" redundancy Eric > > Jason >