From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1847CCD1284 for ; Tue, 9 Apr 2024 11:32:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KA8YG6Vc8UVcL1HsLl+lZmo8Regr0HgYWBTYaRO9eIU=; b=suavxOGilybk9q cxQvvu5l2EOpxyVYJOnbT4e7bhVXVFRUvowYm5eQgQSB6MTSG8o8CWKaHlEL8I2Q0DzAey+IK/+J6 0kL4OTRCVa6nXtWK8GJ4DfQTVlkbRUvRGUNNV2BFaK0R1jp70saHy8EHFQqCHUmh6XZnsgE8c3Afn w0OwV3mMKY2MGbmXQsnBg4iyn921CfEzL48gT/yv/weapGfXri7ln76yZj+A9LacdnSq5KijJJU0I FpOcTgQRRS/oKx4W/lHgRPs9qFBeAPWRnaiKo1nbm/IU17anL57xtzgbGZJlqWzUT2+zznlU7SsGR tiSY/E4/wWIOzTuGbK5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru9ht-00000001fYh-2nmv; Tue, 09 Apr 2024 11:32:05 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ru9hj-00000001fVE-1tsp for linux-arm-kernel@lists.infradead.org; Tue, 09 Apr 2024 11:31:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 54853CE1E08; Tue, 9 Apr 2024 11:31:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F946C433F1; Tue, 9 Apr 2024 11:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712662311; bh=l0bizUbI1uFq+/2K0w1QbeBH9cHRDMhCMHsAdShn0ps=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Q2IgQfOn5TyDR2PC/KrBOG+X9FUXgM9mt/2eSxCk6bIYm9CSpYVkQ5MvocSZlN5Mb 2pONDTBP9TbwZtLuaqr5QHDb9muTnWnexkjxe+SPFuzUtu419MTq3qqdWu9Jh42s4A GM5J25nF51rk4d069hNAhCAk+X1fYuOixNGyyzrVG+weJAjQ0eBStsAs7omvnrKrsD xeCCZXfIXiOafh2Tv4IRjPya0RA7X1isLaVz5c1WsjlFpiRecPD1a7vipdAisl2zEH 6Rz2ltaxNXQyVfOpE7BLvKocnURptf9XQFNRUmwRqX5xFMge0D/SAJ+iTkXhxE0/Cz psdw4n4ldhiTA== Message-ID: <8415e2f4065ede19c6999708d64e8619.sboyd@kernel.org> MIME-Version: 1.0 In-Reply-To: <20240120100711.2832897-1-cristian.marussi@arm.com> References: <20240120100711.2832897-1-cristian.marussi@arm.com> Subject: Re: [PATCH] clk: Check ops are available in clk_gate_restore_context From: Stephen Boyd Cc: sudeep.holla@arm.com, peng.fan@oss.nxp.com, Cristian Marussi , Michael Turquette , linux-clk@vger.kernel.org To: Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 09 Apr 2024 04:31:49 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240409_043155_850392_1D13FA0B X-CRM114-Status: UNSURE ( 8.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Cristian Marussi (2024-01-20 02:07:11) > Add a check in clk_gate_restore_context() to assure that the clock enable > and disable ops are available before calling them. > > CC: Michael Turquette > CC: Stephen Boyd > CC: linux-clk@vger.kernel.org > Fixes: 9be766274db4 ("clk: Clean up suspend/resume coding style") > Signed-off-by: Cristian Marussi > --- > Spotted this by code inspection. > I may be missing something, though, given my limited familiarity with CLK. It assumes this is for a gate clk, which has enable/disable clk ops. Also, only TI uses this code and I suggest you don't use it. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel