From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3988C04AAB for ; Wed, 8 May 2019 16:26:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4DBC208C3 for ; Wed, 8 May 2019 16:26:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oyZslinH"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Oz/n5KHG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4DBC208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7isFvNz3NU1Ar0HimL7C8Mn10U6SUnMDDDYUhub3ym0=; b=oyZslinHdLm3RF p0NvjY1JUOS0odCM6NTBNnFLVbSrK7CwpMoW6WMx/t85YChd9ttRqrYDgwHf6Tuf+fnqJosdlXp2T bPj5kXe8lJ7ohLL++0BRP69Cn5LBbySI6/NKXPEze/SS/xqULa/eOZzqGV2RIK7iORsOtEziHgCqh X86lLG8hMRmcb2GmJkesq7xEMtLqtkbUISmBBD1qIVHZ5yX67dQg4V68rmb2/dlRv+bpO3FCfaoH4 8Aiz1DF/TDeFbao/K5zxDvygwb4ZFotum1Tk1yd8rUvlvp+qH53lvukZ55SYlWmYBU7SxdyTtDIX0 fVLNOmviiqrrPXv0zb/Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOPOh-0007np-00; Wed, 08 May 2019 16:26:23 +0000 Received: from mail-yw1-xc42.google.com ([2607:f8b0:4864:20::c42]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOPOd-0007nP-Ok for linux-arm-kernel@lists.infradead.org; Wed, 08 May 2019 16:26:21 +0000 Received: by mail-yw1-xc42.google.com with SMTP id o65so14938753ywd.8 for ; Wed, 08 May 2019 09:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=COGsxPZjUhLDqGdr7q/DmiwA6MML/opnJexaPWSMAV4=; b=Oz/n5KHGiJj1yQhnpzgj4gJvy1f1V4PIUD89BreZW3A4vTgm8jWmbMMckrZ3QloFXH RPr4C5Bn+2OS8AS4Y+pF8lp1mbHpEBNdG1Q6s+v8NLjpac+ZJw/2oByVjqPXKeembhbm p0j8/qAIAf//Mqa/L2mHyfEsdnLWeHDaUJaFsBIn1IKbGb6YCPg1YJ+nqgF7OcF6bKZT V3IH1H/bkxGv78JA4BCk7dk55jrjCoMBljh+cQ/C3h24EZUOK6Bz339giULjFaX6w5R3 vJivP9zaNZxu27966ZVFyziSrYVjorTqHIa/A8mQ/vqzKjJ8y2PIaP0kxBsBf371xrdr Qabg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=COGsxPZjUhLDqGdr7q/DmiwA6MML/opnJexaPWSMAV4=; b=DaXx3TQjhkPuxbQj81ZOeXuRMq6ZmKjr6McnIxF+mW+kkDlpDTCjxT2Ld22qCx+9yg ew5rJj7J6fCL+9Zhs608AH/p2n2Q1U40M5cMbWACOtB6bBLE+vlvhl4axsuSIT7dQ1Mn VzIBSRcy2cVxzl7eZaMsBCrfrS5pe0YiUlqu4gph02LcqBEiUHjBJ2MxNBOWFhLhaa/q 4kGgorH2S3CCSwh4i8BWSM2nSrqiSPdG95Pp+GhQgwPFri5EpK2rciG5fEjgR41kr6Vq UBjZR8Z8CtTHgVeJtqN5TNHxrQbNCnv1YM1rNxr7NrXV8eAQ/B96BExPb/c7qb/4AHmp Mniw== X-Gm-Message-State: APjAAAWGg7cquMfqdHKpHmtMXyLIJQsoWTihyMrDzqyFUTHrYcTE3s90 lnmkIeUpoLdA17fJ/22pQR0= X-Google-Smtp-Source: APXvYqxhrmayItqQkdsRPVr/08teowVTcdqoqt0teDPgiEhGVdzfVVUK+W3jLzx76ghQ5NJnVsLDvg== X-Received: by 2002:a0d:ef85:: with SMTP id y127mr19372581ywe.471.1557332778392; Wed, 08 May 2019 09:26:18 -0700 (PDT) Received: from [10.67.49.27] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id i64sm2466437ywa.11.2019.05.08.09.26.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 May 2019 09:26:17 -0700 (PDT) Subject: Re: [PATCH v3 0/2] hwmon: scmi: Scale values to target desired HWMON units To: Sudeep Holla , Florian Fainelli References: <20190507230917.21659-1-f.fainelli@gmail.com> <20190508113452.GA27209@e107155-lin> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <8421b37b-5d20-ab0d-3ae8-b6f63048c156@gmail.com> Date: Wed, 8 May 2019 09:26:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190508113452.GA27209@e107155-lin> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190508_092619_841776_1619A2EB X-CRM114-Status: GOOD ( 20.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:HARDWARE MONITORING" , Jean Delvare , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Guenter Roeck , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/8/19 4:35 AM, Sudeep Holla wrote: > On Tue, May 07, 2019 at 04:09:15PM -0700, Florian Fainelli wrote: >> Hi Sudeep, Guenter, >> >> This patch series adds support for scaling SCMI sensor values read from >> firmware. Sudeep, let me know if you think we should be treating scale >> == 0 as a special value to preserve some firmware compatibility (not >> that this would be desired). > > So are we providing raw values from sensors.c and handling conversion > in hwmon layer ? I was thinking of just providing converted values > to hwmon just in case if the scaling thing change in future with > newer versions of SCMI. These are the reasons why I went with doing the scaling in scmi-hwmon.c: - scmi-hwmon.c is where we know the target units that should be matching the HWMON conventions, if we put that scaling into sensors.c that would be a layering violation IMHO - within sensors.c we don't have a struct scmi_sensor_info to work with when called with reading_get, we have a sensor_id, so we would have to look up the id to struct scmi_sensor_info which is an additional loop, doing this in scmi-hwmon.c gives us access to that structure directly - scmi-sensors.c is also the location where the mapping between SCMI sensor type to HWMON sensor type is done, so if we need to update the scale from one to the other, we would rather do that where the mapping is already done, which goes back to the first item. > I am fine either way, just trying to keep > hwmon-scmi simpler. I will check if scale = 0 needs to be treated as > special(I don't think so, but will read the spec) My concern is not so much with the spec but with assumptions SCMI firmware writes might have made while populating sensor values. The spec does not indicate any special treatment about a particular unit power of 10 scale being done or not, and a power of 0 = 1, so that should work okay. Thanks for taking a look! -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel