From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2448DCD37B4 for ; Wed, 4 Sep 2024 12:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PzRpGWmOUix4GzvJgR42aKUg/d33bVXixR5pEp0iclU=; b=c/smDEivzV6e22sAEi0jAEN1kf 3cXQx/9kzKw1aniYO3YXR2+llge8dTCtzpV3kZH8WhWP4F7X5WmthTKSTFY3CM9FlIvrCg0wWvHZP OZgv5HEJBO8TlL6hAvCHZX6UnRRd7fBcXgkiJY6tONMhzKvZ/JAMPAICCi7cgZOZyQKucxeEaYP5T 6LqekASk+lhkotoJbLKYsaaZCprIMO8wheks0GD/8PrkjqiruxFthq6prrD1WluXVYkK/+WucZoD9 +eGGk6GrC18phNO84HtESpgN/BCFwDUyADytyTWhblOUIYF0/Q/KaQioe2rWov4pG3YnkrxsG3IWD nEYVp55g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1slokr-00000004GuP-30Wt; Wed, 04 Sep 2024 12:04:57 +0000 Received: from mx1.tq-group.com ([93.104.207.81]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sloVT-00000004E92-2sMl for linux-arm-kernel@lists.infradead.org; Wed, 04 Sep 2024 11:49:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1725450543; x=1756986543; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PzRpGWmOUix4GzvJgR42aKUg/d33bVXixR5pEp0iclU=; b=EfU+h0TOKO1MfBXgpvc0Xn51d+GBtFud0E1ua+VgaN81O4B9VdaLd4b5 GtktPLGD3A58VwnLFi+WBL6zT9cU/lhKy6nQYQIMDmqGP2ffTzSiSyq6X gN2dSrO4YNW1y8YZrKU5JlQOzKY/e6xVxhHes26s9JXj+bq8QVBk+ZNJR kCaTWvl7Liau3v/gCVej33PaYpNZd+1bvhGJkWWjBncVKjlMb5abVvNKV PFW+7LKToYUIsmNO9kFlTgikNtj9ihoN+kxYA4vtSuQP5zgp/H+HoXmUc j0UD20Ds+HhlBMH9zrNmC/KZDYsdu/rdaXzOWZLnsZXY3xMkjjjl07Bno w==; X-CSE-ConnectionGUID: 9/WIsxHeSR2jvPm7H/3/kg== X-CSE-MsgGUID: sap4pEGZRByHLhM8G9AR7g== X-IronPort-AV: E=Sophos;i="6.10,201,1719871200"; d="scan'208";a="38761957" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 04 Sep 2024 13:49:01 +0200 X-CheckPoint: {66D8492D-2E-5FF8EC80-F6CEE9F8} X-MAIL-CPID: FAD731A5A9D3F1B35E470B14FF3F3207_0 X-Control-Analysis: str=0001.0A782F24.66D8492D.0165,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id CEE15168F91; Wed, 4 Sep 2024 13:48:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1725450537; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=PzRpGWmOUix4GzvJgR42aKUg/d33bVXixR5pEp0iclU=; b=RW47dMR4CCCZ6YbXSUgNtokRaSoNQb0UAB6xzuEfd3TxrUPNps1B3PI+dbYayXq2QwRRtZ 32roHomfmXWZcoKFDZ0Dh06NvEEdbCMaDIyEMrMPfamxMRQ40I3aDbZFLBWktgP2jE1Jqo QrE3u+AgGmXZi+atF+wisomNM9mgCOYBtU9WaaRtwse75qkHni+WkTyABW8SOQi2Ve7JqD 8iQTkUW+1COaBFyTnlpFxthng6s7mngHuGlrLHctW338i8jp7vYNViPHJ6uTfn/6EREZ+X iHeUtCKunTlMyOVC7Mi0DOLeu60AwPZuSnvU8wxeIdtLgAQIBU38A7+KGxLBew== From: Alexander Stein To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] thermal/drivers/imx_sc_thermal: Use dev_err_probe Date: Wed, 04 Sep 2024 13:48:55 +0200 Message-ID: <8423953.T7Z3S40VBb@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240717085517.3333385-1-alexander.stein@ew.tq-group.com> References: <20240717085517.3333385-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240904_044904_082651_3A548F2A X-CRM114-Status: GOOD ( 13.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Am Mittwoch, 17. Juli 2024, 10:55:16 CEST schrieb Alexander Stein: > This adds the error code to the error message and also stores that > message in case of probe deferral. >=20 > Signed-off-by: Alexander Stein > --- > drivers/thermal/imx_sc_thermal.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/thermal/imx_sc_thermal.c b/drivers/thermal/imx_sc_th= ermal.c > index 7224f8d21db97..88558ce588807 100644 > --- a/drivers/thermal/imx_sc_thermal.c > +++ b/drivers/thermal/imx_sc_thermal.c > @@ -111,8 +111,7 @@ static int imx_sc_thermal_probe(struct platform_devic= e *pdev) > if (ret =3D=3D -ENODEV) > continue; > =20 > - dev_err(&pdev->dev, "failed to register thermal zone\n"); > - return ret; > + return dev_err_probe(&pdev->dev, ret, "failed to register thermal zon= e\n"); > } > =20 > devm_thermal_add_hwmon_sysfs(&pdev->dev, sensor->tzd); >=20 Ping! Any feedback? Thanks, Alexander =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/