From: Krzysztof Kozlowski <krzk@kernel.org>
To: Kevin Chen <kevin_chen@aspeedtech.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"andrew@codeconstruct.com.au" <andrew@codeconstruct.com.au>,
"lee@kernel.org" <lee@kernel.org>,
"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"olof@lixom.net" <olof@lixom.net>,
"soc@kernel.org" <soc@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"quic_bjorande@quicinc.com" <quic_bjorande@quicinc.com>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"nfraprado@collabora.com" <nfraprado@collabora.com>,
"u-kumar1@ti.com" <u-kumar1@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: 回覆: [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree
Date: Mon, 7 Oct 2024 13:05:07 +0200 [thread overview]
Message-ID: <843b411f-8a71-4766-a657-70d326676f9c@kernel.org> (raw)
In-Reply-To: <PSAPR06MB4949B860119DCC42C9BC0E42897D2@PSAPR06MB4949.apcprd06.prod.outlook.com>
On 07/10/2024 11:26, Kevin Chen wrote:
>>>>> diff --git a/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
>>>>> b/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
>>>>> new file mode 100644
>>>>> index 000000000000..858ab95251e4
>>>>> --- /dev/null
>>>>> +++ b/arch/arm64/boot/dts/aspeed/aspeed-g7.dtsi
>>>>> @@ -0,0 +1,217 @@
>>>>> +// SPDX-License-Identifier: GPL-2.0-or-later #include
>>>>> +<dt-bindings/clock/aspeed,ast2700-clk.h>
>>>>> +#include <dt-bindings/reset/aspeed,ast2700-reset.h>
>>>>> +#include <dt-bindings/interrupt-controller/arm-gic.h>
>>>>> +#include <dt-bindings/interrupt-controller/aspeed-scu-ic.h>
>>>>> +
>>>>> +/ {
>>>>> + model = "Aspeed BMC";
>>>>
>>>> Model of what? No, drop.
>>> Can I change to "model = "AST2700 EVB""
>>
>> Model of what? No, it does not make sense here.
> Should I change to model = "Aspeed BMC SoC";
SoCs do not have models. Please take a look how *every* other SoC is doing.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-10-07 11:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 11:03 [PATCH v1 00/10] Introduce ASPEED AST27XX BMC SoC Kevin Chen
2024-07-26 11:03 ` [PATCH v1 01/10] dt-binding: mfd: aspeed,ast2x00-scu: Add binding for ASPEED AST2700 SCU Kevin Chen
2024-07-26 11:10 ` Krzysztof Kozlowski
2024-08-16 4:06 ` Kevin Chen
[not found] ` <PSAPR06MB494964BEE33B160EE5E2159289802@PSAPR06MB4949.apcprd06.prod.outlook.com>
2024-10-07 11:03 ` 回覆: " Krzysztof Kozlowski
2024-10-07 11:03 ` Krzysztof Kozlowski
2024-07-26 11:03 ` [PATCH v1 02/10] dt-binding: clk: ast2700: Add binding for Aspeed AST27xx Clock Kevin Chen
2024-07-26 11:11 ` Krzysztof Kozlowski
2024-08-16 4:06 ` Kevin Chen
2024-07-26 11:03 ` [PATCH v1 03/10] clk: ast2700: add clock controller Kevin Chen
2024-07-26 11:13 ` Krzysztof Kozlowski
2024-08-16 4:06 ` Kevin Chen
2024-07-26 11:03 ` [PATCH v1 04/10] dt-bindings: reset: ast2700: Add binding for ASPEED AST2700 Reset Kevin Chen
2024-07-26 11:13 ` Krzysztof Kozlowski
2024-08-16 4:07 ` Kevin Chen
2024-07-26 11:03 ` [PATCH v1 05/10] dt-bindings: arm: aspeed: Add maintainer Kevin Chen
2024-07-26 11:14 ` Krzysztof Kozlowski
2024-08-16 4:07 ` Kevin Chen
2024-07-26 11:03 ` [PATCH v1 06/10] dt-bindings: arm: aspeed: Add aspeed,ast2700-evb compatible string Kevin Chen
2024-07-26 11:15 ` Krzysztof Kozlowski
2024-08-16 4:08 ` Kevin Chen
2024-08-16 5:17 ` Krzysztof Kozlowski
2024-10-07 9:26 ` Kevin Chen
2024-07-26 11:03 ` [PATCH v1 07/10] arm64: aspeed: Add support for ASPEED AST2700 BMC SoC Kevin Chen
2024-07-26 11:16 ` Krzysztof Kozlowski
2024-08-16 4:07 ` Kevin Chen
2024-07-26 11:03 ` [PATCH v1 08/10] arm64: dts: aspeed: Add initial AST27XX device tree Kevin Chen
2024-07-26 11:19 ` Krzysztof Kozlowski
2024-08-16 4:07 ` Kevin Chen
[not found] ` <PSAPR06MB4949EC0D0E0DA16F50BBF40489802@PSAPR06MB4949.apcprd06.prod.outlook.com>
2024-08-16 5:08 ` 回覆: " Krzysztof Kozlowski
2024-10-07 9:26 ` Kevin Chen
2024-10-07 11:05 ` Krzysztof Kozlowski [this message]
2024-07-26 11:03 ` [PATCH v1 09/10] arm64: dts: aspeed: Add initial AST2700 EVB " Kevin Chen
2024-07-26 11:16 ` Krzysztof Kozlowski
2024-08-16 4:07 ` Kevin Chen
2024-07-26 11:03 ` [PATCH v1 10/10] arm64: defconfig: Add ASPEED AST2700 family support Kevin Chen
2024-07-26 13:09 ` [PATCH v1 00/10] Introduce ASPEED AST27XX BMC SoC Rob Herring (Arm)
2024-07-26 13:33 ` Krzysztof Kozlowski
2024-08-16 4:06 ` Kevin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=843b411f-8a71-4766-a657-70d326676f9c@kernel.org \
--to=krzk@kernel.org \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=geert+renesas@glider.be \
--cc=joel@jms.id.au \
--cc=kevin_chen@aspeedtech.com \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=olof@lixom.net \
--cc=p.zabel@pengutronix.de \
--cc=quic_bjorande@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
--cc=u-kumar1@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).