From: Heiko Stuebner <heiko@sntech.de>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Suniel Mahesh <sunil@amarulasolutions.com>,
William Wu <william.wu@rock-chips.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
linux-amarula <linux-amarula@amarulasolutions.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] ARM: dts: rockchip: Add usb host0 ohci node for rk3288
Date: Wed, 22 Jul 2020 20:34:18 +0200 [thread overview]
Message-ID: <8444056.acRTkLjuym@phil> (raw)
In-Reply-To: <20200720105846.367776-1-jagan@amarulasolutions.com>
Hi Jaganm
Am Montag, 20. Juli 2020, 12:58:46 CEST schrieb Jagan Teki:
> rk3288 and rk3288w have a usb host0 ohci controller.
>
> Although rk3288 ohci doesn't actually work on hardware, but
> rk3288w ohci can work well.
>
> So add usb host0 ohci node in rk3288 dtsi and the quirk in
> ohci platform driver will disable ohci on rk3288.
If I remember the discussion correctly, we expect the board dts
or the bootloader to enable the ohci, right?
So that block go away ... just making sure, I don't remember
untrue stuff ;-)
Heiko
> Cc: William Wu <william.wu@rock-chips.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v3:
> - none
>
> arch/arm/boot/dts/rk3288.dtsi | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index 0cd88774db95..f0774d9afb67 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -614,7 +614,16 @@ usb_host0_ehci: usb@ff500000 {
> status = "disabled";
> };
>
> - /* NOTE: ohci@ff520000 doesn't actually work on hardware */
> + /* NOTE: doesn't work on RK3288, but fixed on RK3288W */
> + usb_host0_ohci: usb@ff520000 {
> + compatible = "generic-ohci";
> + reg = <0x0 0xff520000 0x0 0x100>;
> + interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru HCLK_USBHOST0>;
> + phys = <&usbphy1>;
> + phy-names = "usb";
> + status = "disabled";
> + };
>
> usb_host1: usb@ff540000 {
> compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-22 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 10:58 [PATCH v3] ARM: dts: rockchip: Add usb host0 ohci node for rk3288 Jagan Teki
2020-07-22 18:34 ` Heiko Stuebner [this message]
2020-07-22 18:46 ` Jagan Teki
2020-07-22 18:49 ` Heiko Stuebner
2020-07-22 19:21 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8444056.acRTkLjuym@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael@amarulasolutions.com \
--cc=robh+dt@kernel.org \
--cc=sunil@amarulasolutions.com \
--cc=william.wu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).