From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D493C43217 for ; Thu, 20 Oct 2022 18:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PYiOttpVgwOYJGLZDl3J1H855rE9wmupUf58DkclVB8=; b=e7See+FWbp+0bSLPAmdx7Vj1/y bDXuMr5a/R1RdolT6k1KonCAK28CHq4k1P2xVijiYdYJb+pWgoDUzP/Q4Px/BEKERr2qKTXOneSHG Ie4pZ5rty3CWFwf0FYxBjtSgtLDM89gjxzNl8Y6QNDSbR78ZlV7UZXPX9pOv+ZREctdDC4iWLbHzF ow7JvYBhY5KbHQSNTwuQNCMDSbj6PDUt6AR6qg2Q4gGHrv3eCfDYWSd+yZEvFraP1Ip2/Yu9W0SdK TC/+YJhN5nTbyI2KPcVZVyZ2cMaZB3Z2SBtSg9+rlz0t8Q438W4kikuV4iBlCj3HM6HEky4fn3A2b WrNTi1Cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olac5-001Bx8-P0; Thu, 20 Oct 2022 18:49:53 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olac2-001BZF-LN; Thu, 20 Oct 2022 18:49:52 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id 56E301884CB9; Thu, 20 Oct 2022 18:47:39 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id 4421F25001FA; Thu, 20 Oct 2022 18:47:39 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id 38C139EC0005; Thu, 20 Oct 2022 18:47:39 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Thu, 20 Oct 2022 20:47:39 +0200 From: netdev@kapio-technology.com To: Vladimir Oltean Cc: Ido Schimmel , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 net-next 05/12] net: dsa: propagate the locked flag down through the DSA layer In-Reply-To: <20221020133506.76wroc7owpwjzrkg@skbuf> References: <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-1-netdev@kapio-technology.com> <20221018165619.134535-6-netdev@kapio-technology.com> <20221018165619.134535-6-netdev@kapio-technology.com> <20221020130224.6ralzvteoxfdwseb@skbuf> <20221020133506.76wroc7owpwjzrkg@skbuf> User-Agent: Gigahost Webmail Message-ID: <8456155b8e0f6327e4fb595c7a08399b@kapio-technology.com> X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221020_114950_897481_A199DE74 X-CRM114-Status: GOOD ( 25.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-10-20 15:35, Vladimir Oltean wrote: > On Thu, Oct 20, 2022 at 04:24:16PM +0300, Ido Schimmel wrote: >> On Thu, Oct 20, 2022 at 04:02:24PM +0300, Vladimir Oltean wrote: >> > On Tue, Oct 18, 2022 at 06:56:12PM +0200, Hans J. Schultz wrote: >> > > @@ -3315,6 +3316,7 @@ static int dsa_slave_fdb_event(struct net_device *dev, >> > > struct dsa_port *dp = dsa_slave_to_port(dev); >> > > bool host_addr = fdb_info->is_local; >> > > struct dsa_switch *ds = dp->ds; >> > > + u16 fdb_flags = 0; >> > > >> > > if (ctx && ctx != dp) >> > > return 0; >> > > @@ -3361,6 +3363,9 @@ static int dsa_slave_fdb_event(struct net_device *dev, >> > > orig_dev->name, fdb_info->addr, fdb_info->vid, >> > > host_addr ? " as host address" : ""); >> > > >> > > + if (fdb_info->locked) >> > > + fdb_flags |= DSA_FDB_FLAG_LOCKED; >> > >> > This is the bridge->driver direction. In which of the changes up until >> > now/through which mechanism will the bridge emit a >> > SWITCHDEV_FDB_ADD_TO_DEVICE with fdb_info->locked = true? >> >> I believe it can happen in the following call chain: >> >> br_handle_frame_finish >> br_fdb_update // p->flags & BR_PORT_MAB >> fdb_notify >> br_switchdev_fdb_notify >> >> This can happen with Spectrum when a packet ingresses via a locked >> port >> and incurs an FDB miss in hardware. The packet will be trapped and >> injected to the Rx path where it should invoke the above call chain. > > Ah, so this is the case which in mv88e6xxx would generate an ATU > violation interrupt; in the Spectrum case it generates a special > packet. > Right now this packet isn't generated, right? > > I think we have the same thing in ocelot, a port can be configured to > send "learn frames" to the CPU. > > Should these packets be injected into the bridge RX path in the first > place? They reach the CPU because of an FDB miss, not because the CPU > was the intended destination. Just to add to it, now that there is a u16 for flags in the bridge->driver direction, making it easier to add such flags, I expect that for the mv88e6xxx driver there shall be a 'IS_DYNAMIC' flag also, as authorized hosts will have their authorized FDB entries added with dynamic entries... Now as the bridge will not be able to refresh such authorized FDB entries based on unicast incoming traffic on the locked port in the offloaded case, besides we don't want the CPU to do such in this case anyway, to keep the authorized line alive without having to reauthorize in like every 5 minutes, the driver needs to do the ageing (and refreshing) of the dynamic entry added from userspace. When the entry "ages" out, there is the HoldAt1 feature and Age Out Violations that should be used to tell userspace (plus bridge) that this authorization has been removed by the driver as the host has gone quiet. So all in all, there is the need of another flag from userspace->bridge->driver, telling that we want a dynamic ATU entry (with mv88e6xxx it will start at age 7). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel