linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: rockchip: enable Rockchip IO domain support
Date: Fri, 15 Dec 2017 16:55:17 +0100	[thread overview]
Message-ID: <8456682.qhFfChmmK7@diego> (raw)
In-Reply-To: <DB44D3E4-2CB5-452E-BE79-982225CB9E8F@theobroma-systems.com>

Am Freitag, 15. Dezember 2017, 16:51:39 CET schrieb klaus.goger at theobroma-
systems.com:
> > On 15.12.2017, at 16:33, Heiko St?bner <heiko@sntech.de> wrote:
> > 
> > Am Freitag, 15. Dezember 2017, 13:20:10 CET schrieb Klaus Goger:
> >> Make sure the IO domain support is active. This requires to enable
> >> Adaptive Voltage Scaling class support too.
> >> 
> >> Without Rockchip IO domain support the internal level shifter on the
> >> RK3399
> >> will be misconfigured if used in the other voltage domain then the
> >> default.
> >> 
> >> Signed-off-by: Klaus Goger <klaus.goger@theobroma-systems.com>
> >> 
> >> ---
> >> 
> >> arch/arm64/Kconfig.platforms | 2 ++
> >> 1 file changed, 2 insertions(+)
> >> 
> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> >> index 2401373565ff..7c0b0ab12f18 100644
> >> --- a/arch/arm64/Kconfig.platforms
> >> +++ b/arch/arm64/Kconfig.platforms
> >> @@ -150,6 +150,8 @@ config ARCH_ROCKCHIP
> >> 
> >> 	select GPIOLIB
> >> 	select PINCTRL
> >> 	select PINCTRL_ROCKCHIP
> >> 
> >> +	select POWER_AVS
> >> +	select ROCKCHIP_IODOMAIN
> > 
> > I'm not sure if we really want this in the default arch Kconfig or if
> > there
> > are cases where the iodomain driver is not necessary.
> > 
> > On arm32 it just gets selected in the regular defconfig [0]
> 
> At least all currently supported 64bit Rockchip SoCs do have matching VSEL
> GRF settings. For me it looked essential enough to enable for all as not
> setting the correct I/O voltage will result in no output signal at all.
> But I?m fine with a defconfig change if that?s the way to go.
> Should I resend a patch or wait for other opinions?

Personally I would go with a defconfig change. I'd really like to keep the 
kconfig stuff minimal and at least all arm64 Rockchip boards can at least
boot without the iodomain driver.


Heiko

  parent reply	other threads:[~2017-12-15 15:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-15 12:20 [PATCH] arm64: rockchip: enable Rockchip IO domain support Klaus Goger
2017-12-15 15:33 ` Heiko Stübner
     [not found]   ` <DB44D3E4-2CB5-452E-BE79-982225CB9E8F@theobroma-systems.com>
2017-12-15 15:55     ` Heiko Stübner [this message]
2017-12-15 16:03       ` klaus.goger at theobroma-systems.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8456682.qhFfChmmK7@diego \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).