From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B549CC61DA4 for ; Fri, 24 Feb 2023 12:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=h4GLYNwEnsvS6lhQxB4R+MUr2lTbXdJzk93zLOoKTc8=; b=MDnxwQ/OvWRZg7 OKz2ZQ/2pSjFDk6Llk7H9klzUGSePkT6gQstOCXbKrs9LHpWMiihwPn/2iYi/ocpAoNnhnWYATgml t/9gxA7mtU8WSrIbUtVfBMuuYjJSM48ipMoUJgmScQYankpOFBpwLfJv97OpZAgHhhnHL+Xpeq31G WsX6HrDaZ2LH0uyz4hcq+GBaRUC98mE4qTTFrNnTnUDcetr3QYC2kQjo8N6isJNkh2Jewv3Lb4kQl p8wtzzMToUIrOhyTH3tiISjs6wPvdMP++yqHcgFlzw/eqW9HqlLnjjnQL91jDtXTytl3ZOlVBTMSF s1S/8ELIO8BAkhkSCu2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVWsg-002LH9-0B; Fri, 24 Feb 2023 12:08:54 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVWsd-002LDH-4d for linux-arm-kernel@lists.infradead.org; Fri, 24 Feb 2023 12:08:52 +0000 Received: from [127.0.0.1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 12D1785777; Fri, 24 Feb 2023 13:08:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1677240524; bh=Tqv7hJjJOTMH5eRLWXqviJQ747Cp4wMhiFEWOAhcnN4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jQZwKivCg03+1nHpUTIOhIVBpygvshov4iqy2afTg7cNkCsQ5PM8Kb2F3uhNQ7s/M caAOcYAHxmukRypy+JC+2bHbZaVMGKskTFxOk7noqZuwAjyigsCsS6hqsDZLlnhRhd VKIr3yT6zJS6KAns1/e+6XkU7MuXh42QUU53jX+GFGubXsf2/7vm1HQctOUQUQwcUW YgNM5If3mQipE1mjAaqwTIEIKkbk1t/lnwhdkvMNZnJL5UyQdZEb2HEdXwxa6jElLJ dLt3jE7PX7q4YrLQUuXsDJRfewXBtnV4UhFuNg5uTgF7tBIIW1NZ4kyGd8TcYREkUy ZKpMHiagR6dNA== Message-ID: <8477c32f-28e6-96f2-a4ec-b378b142d234@denx.de> Date: Fri, 24 Feb 2023 13:08:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 3/4] soc: imx: imx8m-blk-ctrl: Scan subnodes and bind drivers to them To: Lucas Stach , linux-arm-kernel@lists.infradead.org Cc: Alexander Stein , Fabio Estevam , Krzysztof Kozlowski , Laurent Pinchart , NXP Linux Team , Paul Elder , Peng Fan , Pengutronix Kernel Team , Richard Cochran , Richard Zhu , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org References: <20230223151043.41548-1-marex@denx.de> <20230223151043.41548-3-marex@denx.de> Content-Language: en-US From: Marek Vasut In-Reply-To: X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230224_040851_477658_88A288C6 X-CRM114-Status: GOOD ( 13.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/24/23 10:08, Lucas Stach wrote: Hi, >> diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c >> index 399cb85105a18..77e7dc4eb8cff 100644 >> --- a/drivers/soc/imx/imx8m-blk-ctrl.c >> +++ b/drivers/soc/imx/imx8m-blk-ctrl.c >> @@ -310,7 +310,7 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev) >> >> dev_set_drvdata(dev, bc); >> >> - return 0; >> + return devm_of_platform_populate(dev); > > You need to handle the return value, not simply pass it through as the > return value of the probe function. When devm_of_platform_populate > fails you miss to clean up the genpd provider and detach from the power > domains. Hmmm, but then I cannot use the devm_ variant, can I ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel