From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8CD52CA101F for ; Fri, 12 Sep 2025 16:06:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ql/dFA6zzdQLfAJ85mqvQ9yW60NoAl65r0V8dC9FamU=; b=hVenyp23LaM5bQA9zsugUYWBP0 NM0mQW18+cF+LGUEnR2NCoFk5CyoxVcPIt44wOq2A3JEdnsDwKsDDJ9ga3p07a7p1/76o6IE1htel RC0oIFDFrCg1zE0GFYiNYq9MjwQVKG2Dnp8WUjq+MXbEkQ2Rwb/IHaRCBiK1rhA9PSRSVyRYKFDyo /aQNDDCidx4bz6F3lQmKQyxKvo01F3J9ACbGpCDrioiyuDIG2VpIJOSTZd6KbZRLQ7Sr44CCX3C5/ xcLqEUjnQ/ab7O/YiEnWnwbN14lwJ89IYS1UWXy6NGCyuW/bnQhGCGxfdUut3PQXgwZg2mmuNtwOj D9KbYpPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ux6I7-0000000AS46-2rLR; Fri, 12 Sep 2025 16:06:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ux6I5-0000000AS3O-3ao2 for linux-arm-kernel@lists.infradead.org; Fri, 12 Sep 2025 16:06:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E28B31515; Fri, 12 Sep 2025 09:06:16 -0700 (PDT) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1DEF83F66E; Fri, 12 Sep 2025 09:06:19 -0700 (PDT) Message-ID: <848050b3-65d7-4caf-b093-7145eb782a7c@arm.com> Date: Fri, 12 Sep 2025 17:06:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 28/29] arm_mpam: Add kunit test for bitmap reset To: James Morse , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-29-james.morse@arm.com> From: Ben Horgan Content-Language: en-US In-Reply-To: <20250910204309.20751-29-james.morse@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250912_090625_942308_8B5D6DAA X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, On 9/10/25 21:43, James Morse wrote: > The bitmap reset code has been a source of bugs. Add a unit test. > > This currently has to be built in, as the rest of the driver is > builtin. > > Suggested-by: Jonathan Cameron > Signed-off-by: James Morse > --- > drivers/resctrl/Kconfig | 10 +++++ > drivers/resctrl/mpam_devices.c | 4 ++ > drivers/resctrl/test_mpam_devices.c | 68 +++++++++++++++++++++++++++++ > 3 files changed, 82 insertions(+) > create mode 100644 drivers/resctrl/test_mpam_devices.c > > diff --git a/drivers/resctrl/Kconfig b/drivers/resctrl/Kconfig > index c30532a3a3a4..ef59b3057d5d 100644 > --- a/drivers/resctrl/Kconfig > +++ b/drivers/resctrl/Kconfig > @@ -5,10 +5,20 @@ menuconfig ARM64_MPAM_DRIVER > MPAM driver for System IP, e,g. caches and memory controllers. > > if ARM64_MPAM_DRIVER > + Nit: add the empty line in an earlier patch Reviewed-by: Ben Horgan Thanks, Ben