From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Neal Liu <neal_liu@aspeedtech.com>,
Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Cai Huoqing <caihuoqing@baidu.com>,
Tao Ren <rentao.bupt@gmail.com>,
Julia Lawall <julia.lawall@inria.fr>,
kernel test robot <lkp@intel.com>,
Sasha Levin <sashal@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org
Cc: BMC-SW@aspeedtech.com
Subject: Re: [PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor
Date: Tue, 30 Nov 2021 10:40:59 +1100 [thread overview]
Message-ID: <84b2d2c6b530d0a3a9b86b0ffcbfa70935bdb0a9.camel@kernel.crashing.org> (raw)
In-Reply-To: <20211126110954.2677627-2-neal_liu@aspeedtech.com>
On Fri, 2021-11-26 at 19:09 +0800, Neal Liu wrote:
>
> @@ -417,10 +435,9 @@ enum std_req_rc ast_vhub_std_hub_request(struct ast_vhub_ep *ep,
>
> /* GET/SET_CONFIGURATION */
> case DeviceRequest | USB_REQ_GET_CONFIGURATION:
> - return ast_vhub_simple_reply(ep, 1);
> + return ast_vhub_simple_reply(ep, vhub->current_config);
> case DeviceOutRequest | USB_REQ_SET_CONFIGURATION:
> - if (wValue != 1)
> - return std_req_stall;
> + vhub->current_config = wValue;
> return std_req_complete;
This is odd.. why should we support arbitrary SET_CONFIGURATION for
configs we don't support ?
Otherwise looks good.
Cheers,
Ben.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-29 23:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 11:09 [PATCH 0/3] Refactor Aspeed USB vhub driver Neal Liu
2021-11-26 11:09 ` [PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor Neal Liu
2021-11-29 23:40 ` Benjamin Herrenschmidt [this message]
2021-11-30 9:30 ` Neal Liu
2021-11-26 11:09 ` [PATCH 2/3] usb: aspeed-vhub: support remote wakeup feature Neal Liu
2021-11-29 23:45 ` Benjamin Herrenschmidt
2021-11-30 9:47 ` Neal Liu
2021-11-30 23:37 ` Benjamin Herrenschmidt
2021-12-02 3:03 ` Neal Liu
2021-12-02 5:34 ` Neal Liu
2021-12-06 0:08 ` Benjamin Herrenschmidt
2021-11-26 11:09 ` [PATCH 3/3] usb: aspeed-vhub: fix ep0 OUT ack received wrong length issue Neal Liu
2021-11-29 23:48 ` Benjamin Herrenschmidt
2021-11-30 9:49 ` Neal Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84b2d2c6b530d0a3a9b86b0ffcbfa70935bdb0a9.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=balbi@kernel.org \
--cc=caihuoqing@baidu.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=julia.lawall@inria.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=neal_liu@aspeedtech.com \
--cc=rentao.bupt@gmail.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).