From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FFD0C433EF for ; Mon, 29 Nov 2021 23:47:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SCJv1h1z3U8qByPmRp33OJ9vpXef6mqGrMR/Rq0JdrQ=; b=Dsw67VFGT4ZVe/ yMnODAgAvWFdPufGIRXr6iHhD2N+D4MZ27+LbK0wjrd2aa2w49uAPH70pGYlRoplVf8YVcyLTCgPc J1hzByM1N1FXVkZendU76PakSdJi0Y9bnwuXNHJQE/4gSZ561ukM4BtKPc7RRMpdXi1zYhuj8Mp4/ mtftpJldIeI0FZcMZTt5viLgppa5FGwMREbLd842dDyz9ptk30/3pj/4lfeowbWwKP8vdPQmeA7/b YPQhnAWLBA2FnTBVGFfHsGU6d1n9B22+x3UQ4XYu9rk1FloDyflLHkFC6p4a6t7wL1lXmSZDWZZ6i KpU7wAWk1nBlobzp0foQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrqL6-0038EP-JK; Mon, 29 Nov 2021 23:45:40 +0000 Received: from gate.crashing.org ([63.228.1.57]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrqL2-0038Dn-A2 for linux-arm-kernel@lists.infradead.org; Mon, 29 Nov 2021 23:45:37 +0000 Received: from ip6-localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 1ATNf0UG024811; Mon, 29 Nov 2021 17:41:01 -0600 Message-ID: <84b2d2c6b530d0a3a9b86b0ffcbfa70935bdb0a9.camel@kernel.crashing.org> Subject: Re: [PATCH 1/3] usb: aspeed-vhub: add qualifier descriptor From: Benjamin Herrenschmidt To: Neal Liu , Felipe Balbi , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , Cai Huoqing , Tao Ren , Julia Lawall , kernel test robot , Sasha Levin , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org Cc: BMC-SW@aspeedtech.com Date: Tue, 30 Nov 2021 10:40:59 +1100 In-Reply-To: <20211126110954.2677627-2-neal_liu@aspeedtech.com> References: <20211126110954.2677627-1-neal_liu@aspeedtech.com> <20211126110954.2677627-2-neal_liu@aspeedtech.com> User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_154536_572872_423C779C X-CRM114-Status: UNSURE ( 9.13 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2021-11-26 at 19:09 +0800, Neal Liu wrote: > > @@ -417,10 +435,9 @@ enum std_req_rc ast_vhub_std_hub_request(struct ast_vhub_ep *ep, > > /* GET/SET_CONFIGURATION */ > case DeviceRequest | USB_REQ_GET_CONFIGURATION: > - return ast_vhub_simple_reply(ep, 1); > + return ast_vhub_simple_reply(ep, vhub->current_config); > case DeviceOutRequest | USB_REQ_SET_CONFIGURATION: > - if (wValue != 1) > - return std_req_stall; > + vhub->current_config = wValue; > return std_req_complete; This is odd.. why should we support arbitrary SET_CONFIGURATION for configs we don't support ? Otherwise looks good. Cheers, Ben. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel