From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86E84C25B76 for ; Wed, 5 Jun 2024 13:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uThFjT9XWoGJWSBN6yJd402806LyAboU+G9HMBYcJVM=; b=ov3vSSRkJR3JYO qNVi8rluIwVGtasEMuCH0fpyOZNO08Ed65kLyFnya0SH4cWXQhYyVw1cNfw/3FTSoXx7S/SZ41k5w kGIFyKlmeuv2qfPjJbkcY52V7dPHgXkeAa2VI2JbLpeHPJ4okE3tEBPgLOF7h+wOO6MaaXN/Oe/FW GKc2yLGYNEA7MVGFWV+REJPax2GlMYj0yPkzDEecPJyNDbB4jabDV5lhEiTR5wNcIPnv+jJOAYJmJ xrg53VYh78IL2YLFakDzW0dC7nun9whkB6fQckmhIOUtrPFCHrI09pHzOpWdgv6L2tCNpaCUgPh3J VU6hOLbwvhormB48+gUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEqhk-00000006F6g-19r1; Wed, 05 Jun 2024 13:29:28 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEqhg-00000006F5a-3Qf6 for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2024 13:29:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717594162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TimOra3HeHNfMn31Geb/c2jkUkP/9ZajHiQ70UJM4mU=; b=iEo6b0L8417Z2toK5OYqO4ZnopYxsUMmWF7vmxzuz/XAh0g2ww2gDtuN5LQvq2lAXTQkcO Iut5pnksGHR3GGl9yy2jlHCpj2PtdAMGodnfBF4YTdznhKDbbAtjCbDKatlrSLhx+byVQD bdza9JDPHPe/XP1xxmW44kiwMqcDf+U= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-3yRsrL0tMwyhVTFClgtQNA-1; Wed, 05 Jun 2024 09:29:18 -0400 X-MC-Unique: 3yRsrL0tMwyhVTFClgtQNA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-421580a28d1so4710215e9.0 for ; Wed, 05 Jun 2024 06:29:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717594158; x=1718198958; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TimOra3HeHNfMn31Geb/c2jkUkP/9ZajHiQ70UJM4mU=; b=wPxcGOmpSDYJlC6IXjELkeoKKVdS11yqzo6Y30sQwCL3cUaWxFBJTPXcIQNKhguMth i4hJL0icIXs0aLqWK3MNgreULhbh3vsxKmHQLkc1lTr1LP/hyhw9v7UGcW0Wqyjp5Ho0 941NQ7UPMlTI97HMRqg03W/vhGh+tq6b2YHa9dAYhPA0OfJGhK2nIyqBCFWU5v8FapnS 0tAjm2//HTen9CTJ2wxnp7KvqeEL65neNlgJ6WwB3lRFUKMgfcJZZY6PwvJTOjghtppn ReH2h5jjbF7bNbuia8vBYTMCpbnZ9GVC/NPDLRLc8R2pssHKfq/Lwj5wjbCZ1j77CWlX ZWcQ== X-Forwarded-Encrypted: i=1; AJvYcCWKHE6b6HboFjbUpIYaYYdJ632+y3J96coD9TSFLLOFMy30vD4bGdNCrvHkQDU0ZyxS7XLSRbAp5REfLREqUsqNOIFO8T8O5surGAW04lO9fGer/pE= X-Gm-Message-State: AOJu0Yw21hCPtVdzUDwMW3CNBLFGA0VT9GLYreDW19kmV7q3qTMeT0sn Epe8fw8FAOv2g1JrqAjTWxZiclCnzdgF7CWmzVqxlodT2S7NMGJgiX98GuVqyE6CigIarvun/UC WlkgViIFLBZlm7mvuIdfDwhugQF7jsxl9HZrCl5ALz9bu7t1KbVZDEuCxyuzThrlTT05xo3xd X-Received: by 2002:a05:600c:4592:b0:41f:e10f:889a with SMTP id 5b1f17b1804b1-421562c6d2amr21085755e9.7.1717594157819; Wed, 05 Jun 2024 06:29:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH8S/eFoJca0oDq0Kl/wcJnKeKbyYEUHwH/ly+WvXJxKZaOzoXnKCDleFRN0P6XYSUGFm0DAw== X-Received: by 2002:a05:600c:4592:b0:41f:e10f:889a with SMTP id 5b1f17b1804b1-421562c6d2amr21085605e9.7.1717594157431; Wed, 05 Jun 2024 06:29:17 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:3100:19a8:d898:8e69:6aff? (p200300cbc706310019a8d8988e696aff.dip0.t-ipconnect.de. [2003:cb:c706:3100:19a8:d898:8e69:6aff]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158132f0fsm22662395e9.29.2024.06.05.06.29.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 06:29:17 -0700 (PDT) Message-ID: <84f81229-a0a8-41d5-a401-0d0628c64b3e@redhat.com> Date: Wed, 5 Jun 2024 15:29:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/memory_hotplug: Drop memblock_phys_free() call in try_remove_memory() To: Mike Rapoport , linux-mm@kvack.org Cc: Andrew Morton , Jonathan Cameron , Oscar Salvador , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.org References: <20240605082049.973242-1-rppt@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240605082049.973242-1-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240605_062924_966377_5AE3201C X-CRM114-Status: GOOD ( 20.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05.06.24 10:20, Mike Rapoport wrote: > From: Jonathan Cameron > > The call for memblock_phys_free() in try_remove_memory() does not balance > any call to memblock_alloc() (or memblock_reserve() for that matter). > > There are no memblock_reserve() calls in mm/memory_hotplug.c, no memblock > allocations possible after mm_core_init(), and even if memblock_add_node() > called from add_memory_resource() would need to allocate memory, that > memory would ba allocated from slab. > > The patch f9126ab9241f ("memory-hotplug: fix wrong edge when hot add a new > node") that introduced that call to memblock_free() does not provide > adequate description why that was required and tinkering with memblock in > the context of memory hotplug on x86 seems bogus because x86 never kept > memblock after boot anyway. > > Drop memblock_phys_free() call in try_remove_memory(). See my example regarding leftovers from previous bootmem allocations. But I don't think we'd encounter that situation often in practice. Maybe more likely to happen on ppc with very small memory blocks? No idea. Let's see if anything would really break Acked-by: David Hildenbrand > > Signed-off-by: Jonathan Cameron > [rppt: rewrite the commit message] > Signed-off-by: Mike Rapoport (IBM) > --- > mm/memory_hotplug.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 431b1f6753c0..e0d49f128e0d 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -2283,10 +2283,8 @@ static int __ref try_remove_memory(u64 start, u64 size) > remove_memory_blocks_and_altmaps(start, size); > } > > - if (IS_ENABLED(CONFIG_ARCH_KEEP_MEMBLOCK)) { > - memblock_phys_free(start, size); > + if (IS_ENABLED(CONFIG_ARCH_KEEP_MEMBLOCK)) > memblock_remove(start, size); > - } > > release_mem_region_adjustable(start, size); > -- Cheers, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel