From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60A91C433F5 for ; Tue, 15 Mar 2022 22:57:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-reply-to: Date:Subject:Cc:To:From:References:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bCnq1OBthAbFoXlAb3QfJPzH0eq4JWZ57h0dx0nbO3c=; b=eFIhnb7fPmsK0a gmsWKwbPlaMuEpPvNWEmUFFmaZT4F299irwcZh1iZYMPWRj+lnpCMEluvZSMYXKYpjGf9kg83iwf5 hbUY26FX+zV+86UsZdY0iDWJGvZYenDTNsvkkY9pbQ8LXWPMJn9J0FiOuRMSePuu/U+6xBgZrMmE3 dGZf33JEz/o8jleTkhzJvBAh2xitf/dWFFPEAsxSg8sN5w783K/zrHRoXJOTMOdpAqs0v0mCd9who v9BAUWswpnyi8dhTuxQ5pNrWfMM0Wm0l/gG2JUdDNWKszX1MOW7JzkY5j0bHnXU9YfwqYJgcLxtgo KW+QSnsp91n8O44c4dWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUG5d-00AnnG-6k; Tue, 15 Mar 2022 22:56:29 +0000 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUG5Z-00Anjv-2x for linux-arm-kernel@lists.infradead.org; Tue, 15 Mar 2022 22:56:26 +0000 Received: by mail-oi1-x229.google.com with SMTP id o83so921869oif.0 for ; Tue, 15 Mar 2022 15:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=ljhqCefXzcruXQp9WtlPDBfDUy90SHN1xf9SfOB4wXo=; b=JJdvfR6X7QbqEPUgushUKYa1RNBQkRRR4WC3wPNl5kIq/jo7YTlvg2icY93SRLQXUh /H3mr3foM2w4Zeg0j43gJ+lyqTZfkwfWNtS7hhqrgDZzg1uMGpAMthALWh/NvjFIn0uk z3f1NAhLXblGVwDuppexEX2ch+IXdxztXMB0CgXCRibvmSYeh9K1kwtyLMGeo6P19j1N Jtli/+ReQBAwDCc1T90MIaQrwJ+HgvzDdaWem43Q2c+fFy3/26A9/HhbRTJRjcCnbG5G EuQjWi2H+mQ7i+YNbP971nB8QNYJ9z541H61yb1PbWeBwslBmfI5P8ltP7wPBHkp0K1e VZCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=ljhqCefXzcruXQp9WtlPDBfDUy90SHN1xf9SfOB4wXo=; b=4MB4Y5gFnPNTHX8UI2QRSCnVngcLzKpWtRhKzqFh3E8mGEY3dUojMAItRMdWrIQEmD F+UGf17PUu++wCR+RLCUi1hIN9ElHtTojyRLWLX/4FagM77X5CkmQAyyc5k6YdaywvXV a1/7CMPLbFw7+evTl0RaawyvEU829fTbDENp00r2DTKPde0CksgjGLQaoIZNkDeG/rQi W+ZhqPxXoccXNzDw3J1g/y/2RacHZEyfN2YEfO6kFoAaYRSUJ+cBaRIVK0dyTzeMhXZG sXsyuX+P+ueZblh+5RU/mrSAlpS1x3mPtuxxzK8+2PA2L+06btGdLyy0YCCq7iYzW12D 4nRw== X-Gm-Message-State: AOAM53309l0kYGOK6fvmgMwMi7+63U3bq/hTx6hukVXCaNzJ3oBU7ZoS QHpbpXcGDb0DfvqK5ng4STeW3Q== X-Google-Smtp-Source: ABdhPJxBltnxj+cRdTc3QSEmr5cFA2sw31omFs/+72HwwBL1IWZvFZ6qtR1216vBiT4g5Njj0Zdmuw== X-Received: by 2002:aca:db03:0:b0:2da:363b:658b with SMTP id s3-20020acadb03000000b002da363b658bmr2763996oig.173.1647384983257; Tue, 15 Mar 2022 15:56:23 -0700 (PDT) Received: from linaro.org ([189.4.186.55]) by smtp.gmail.com with ESMTPSA id a19-20020a056808099300b002da1428db03sm247765oic.7.2022.03.15.15.56.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 15:56:22 -0700 (PDT) References: <20220225165923.1474372-1-broonie@kernel.org> <20220225165923.1474372-24-broonie@kernel.org> User-agent: mu4e 1.6.10; emacs 27.2 From: Thiago Jung Bauermann To: Mark Brown Cc: Catalin Marinas , Will Deacon , Marc Zyngier , Shuah Khan , Shuah Khan , Alan Hayward , Luis Machado , Salil Akerkar , Basant Kumar Dwivedi , Szabolcs Nagy , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org, kvmarm@lists.cs.columbia.edu Subject: Re: [PATCH v12 23/40] arm64/sme: Add ptrace support for ZA Date: Tue, 15 Mar 2022 18:51:36 -0300 In-reply-to: <20220225165923.1474372-24-broonie@kernel.org> Message-ID: <84v8werfn3.fsf@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220315_155625_186763_B6FC9464 X-CRM114-Status: GOOD ( 11.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, Just one trivial comment: Mark Brown writes: > +static int za_get(struct task_struct *target, > + const struct user_regset *regset, > + struct membuf to) > +{ > + struct user_za_header header; > + unsigned int vq; > + unsigned long start, end; > + > + if (!system_supports_sme()) > + return -EINVAL; > + > + /* Header */ > + memset(&header, 0, sizeof(header)); > + > + if (test_tsk_thread_flag(target, TIF_SME_VL_INHERIT)) > + header.flags |= ZA_PT_VL_INHERIT; > + > + header.vl = task_get_sme_vl(target); > + vq = sve_vq_from_vl(header.vl); > + header.max_vl = sme_max_vl(); > + header.max_size = ZA_PT_SIZE(vq); > + > + /* If ZA is not active there is only the header */ > + if (thread_za_enabled(&target->thread)) > + header.size = ZA_PT_SIZE(vq); > + else > + header.size = ZA_PT_ZA_OFFSET; > + > + membuf_write(&to, &header, sizeof(header)); > + > + BUILD_BUG_ON(ZA_PT_ZA_OFFSET != sizeof(header)); > + end = ZA_PT_ZA_OFFSET; > +; Stray semicolon. > + if (target == current) > + fpsimd_preserve_current_state(); > + > + /* Any register data to include? */ > + if (thread_za_enabled(&target->thread)) { > + start = end; > + end = ZA_PT_SIZE(vq); > + membuf_write(&to, target->thread.za_state, end - start); > + } > + > + /* Zero any trailing padding */ > + start = end; > + end = ALIGN(header.size, SVE_VQ_BYTES); > + return membuf_zero(&to, end - start); > +} -- Thanks, Thiago _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel