From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0875C3F2D8 for ; Tue, 3 Mar 2020 16:11:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 79FF92073D for ; Tue, 3 Mar 2020 16:11:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="pMFlZQVN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JvMOlYXW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 79FF92073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZLcuax+CvVDXP4BkSWMSo64CaPZKVAhVhIyfQ3KP/mo=; b=pMFlZQVNcgPq8U x1bkaVhJLxvPMJ5nHDEYQx8NHTBveC8S/CWIOHzAo29Ov8DcjLsOrT/u/Uv3aDlz0YI/hIAxDztxA 8n1cpfWFhrJ3KxTNdj4uMpp5S5ZtoRBqYgYKMT6bhH/KVWxLUhGSUYQ9CjdT1Y1nXQuv3i5vruZL/ cT4ucut1xO/FRWgl6B1SeglMECxSH/mOXMPcBtxHoNhQa1dSo/pg2J6S4ikoc7fK+UqRnH5iE9Cl4 VqSyu7e9DWtAfDpE4E1uYagRyMgKclKwLCWcoQ8IJ1FaIOqoC+UywM2T356lsskRQLoGws+pxU3AL 1Rg64gfZYOD3A135j0BA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9A8m-0007Re-UZ; Tue, 03 Mar 2020 16:11:28 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9A8k-0007Qc-0n; Tue, 03 Mar 2020 16:11:27 +0000 Received: by mail-wr1-x443.google.com with SMTP id v4so5056285wrs.8; Tue, 03 Mar 2020 08:11:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+SzpTWQT3Ru6kg4f8Uj442Z+FLl17Fjj2BOSrwBP2tA=; b=JvMOlYXWMq0Xw1p+AMSLlLQea6qJWe/imSAwECDX0rMvjouX6tXhiTzi6l9PrEOKZH mdkAi2TI7TwqRHeOSAeN4q9w+Mfvk/US67aBFw14KS0w9HiygV3cRD7xJ9z5VRS3PXBr 1jaA30b2hzUR0OE/6lXyX2IVnqwBLNuda+OJC4XozRGsax9OtpUhBPfs8c9xgxYWsIqA VuTKw5sjUPmNkpaU06pgtELNoVNP1YKm/LPYmN5gz9+5lVtFmcvVqJxFf5crA986u4HC RRz7ZOhDNXYl+enXW+x20gh545dfWhHil10Ywy6BIlDvrtAIwOqafQWOWpl3U18e7JhH mXOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+SzpTWQT3Ru6kg4f8Uj442Z+FLl17Fjj2BOSrwBP2tA=; b=ecnkHYaO4j8qHi6bx9JTJ1QqmvvNPv9erRwBd0rFoz/1mUBGRUThFHc4xUw+GBB+h+ /wVvEXB/nHaUDVgj1DbcRchxxXFwNtFllCjFmR+jgLZOdoSMXwyX6ofRbUxuK5AmU+ZJ 6FcNx5Gizo907QttVT7wIfS7tq2Dx6RQKY+7F6RGmO6ucoIHIy6MjwCh6xMqSDABP5eZ CYXNThcnrP7j6D2S0SYWpPxDrBrEJM20Sd0hM65yIt0xO0IXX116PAsGbjiUNvU6LIL0 ProxZYDDCeECCvPGCVx+jdOeKnHB9V5DJYcPuOYLyZOpzi5ukajB6+DC23xd3uMcc/ib o4Vg== X-Gm-Message-State: ANhLgQ33BxgBxT97KLJyllUd3pfWTxsq80OC/M2lh6gLAdY+OMP4jVHi jsjsW553jFVNN6lqu5dhWNE= X-Google-Smtp-Source: ADFU+vsxfAPm/x+IV3Wuxbup+iavPIjBhYZz58QDdng5ipw9V1mPOt2TMllv6EsxNgKf3ODQBhebjg== X-Received: by 2002:a5d:5743:: with SMTP id q3mr6227104wrw.135.1583251884664; Tue, 03 Mar 2020 08:11:24 -0800 (PST) Received: from [192.168.2.1] (ip51ccf9cd.speed.planet.nl. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id s5sm32669295wru.39.2020.03.03.08.11.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2020 08:11:23 -0800 (PST) Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro From: Johan Jonker To: Tobias Schramm , Rob Herring , Mark Rutland , Heiko Stuebner , Andy Yan References: <20200229144817.355678-1-t.schramm@manjaro.org> <20200229144817.355678-3-t.schramm@manjaro.org> Message-ID: <850e60b0-c260-c184-839f-93b064388e32@gmail.com> Date: Tue, 3 Mar 2020 17:11:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200303_081126_064326_A0D726BD X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Alexis Ballier , Katsuhiro Suzuki , linux-kernel@vger.kernel.org, Douglas Anderson , Kever Yang , Markus Reichl , linux-rockchip@lists.infradead.org, Matthias Kaehlcke , Jagan Teki , Nick Xie , Vivek Unune Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Add more reg = <..> On 3/3/20 4:37 PM, Johan Jonker wrote: > Hi Tobias, > > Some minor style issues. > This dts file contains a partition node. > Question for the maintainers (Heiko?): > Should that partition be included or not? [..] >> +&i2c4 { >> + i2c-scl-falling-time-ns = <20>; >> + i2c-scl-rising-time-ns = <600>; >> + status = "okay"; >> + >> + fusb0: fusb30x@22 { >> + compatible = "fcs,fusb302"; >> + reg = <0x22>; >> + fcs,int_n = <&gpio1 RK_PA2 GPIO_ACTIVE_HIGH>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&fusb0_int_gpio>; > >> + status = "okay"; > > Remove or else status below. > New nodes are already okay I think. > If insure check compiled flat dts output to see if it is still there. > >> + vbus-supply = <&vbus_typec>; >> + >> + connector { >> + compatible = "usb-c-connector"; >> + label = "USB-C"; >> + op-sink-microwatt = <1000000>; >> + power-role = "dual"; >> + sink-pdos = >> + ; >> + source-pdos = >> + ; >> + try-power-role = "sink"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { reg = <0>; >> + usbc_hs: endpoint { >> + remote-endpoint = >> + <&u2phy0_typec_hs>; >> + }; >> + }; >> + >> + port@1 { reg = <1>; >> + usbc_ss: endpoint { >> + remote-endpoint = >> + <&tcphy0_typec_ss>; >> + }; >> + }; >> + >> + port@2 { reg = <2>; >> + usbc_dp: endpoint { >> + remote-endpoint = >> + <&tcphy0_typec_dp>; >> + }; >> + }; >> + }; >> + }; >> + }; >> +}; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel