From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4B5ECFC5E7 for ; Thu, 10 Oct 2024 16:34:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xsDOOHnrvnPmEw4+tvRO9I3UEkiSIAIXntOFOHhTarY=; b=ZkbwR4Yfi4n2xOa62skRtC5eLw FQkKq7CsG6sg0cnsYVMHEcypPLx/Vy7cnnbqW1TPq6hCUEJ+du0zwG0DTsvDecbCMVa8F8lu5o0r9 D6ZHTxjuhOdiwhJzQ+TdhAbGNePaLjQqhpEjEHMJx79CoSjx30zIciljjC8/N5xlEdNMEse/Me2cQ l4C1bYotvdSYDaUBuo2mHbUfLHvuj+0mODfslyqPjjBFCdvRorAqhHXBRJKhQmqxSmxUartmXVAti 5HLMP9JYjErcZwQjV0fJggNCQgjhvLiYK2C0/pcUA1OIhj2bfm4lc8zOH9Kvk864zeC3/ehIhkbqj /n68eUlw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syw7b-0000000DXWh-232V; Thu, 10 Oct 2024 16:34:39 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syus4-0000000DHSH-1N7Q; Thu, 10 Oct 2024 15:14:33 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a9960371b62so116695266b.3; Thu, 10 Oct 2024 08:14:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728573270; x=1729178070; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=xsDOOHnrvnPmEw4+tvRO9I3UEkiSIAIXntOFOHhTarY=; b=T3Velof3Op5BH7Uzu/VeqnZU2V81Y/me8QwLsrw4sk09Mth29tQ+UREMuuPL+5+455 5E2hVgXpNzptGOfI5J32gtzhYCjW7V08yzBemE+Whq1bflG1Llv3QHb05n3VcoMubGbi /vus4ODrJHVpPqafJHaeAEPexNySC4ldkX5V7LzzcrJ4rRT1XdKJ/XIB0KD25foIegx5 pVFHsX2EVtblr3WUvTZC6JoDg6qcymeJvLosxpz2Vr0Go/ENlG+61rDUHqpFgaTEQhQ5 ZwaHTAh5mLwGR/S26kNZlXElriXlcwNMnRWfvj/K+pH18zdEBsEGluoMi6rojg5EUEoT KF9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728573270; x=1729178070; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xsDOOHnrvnPmEw4+tvRO9I3UEkiSIAIXntOFOHhTarY=; b=HscyUcl23DxR2u5BgURmqp20/JnIUmypHH8/mR/HUixWfSeJk+H4VquwUqjk3pzhsR 1ZG6nDoPG95b8WfNZoV3DY+klwMkXfkoDNNXLOx8UQ5dpuVuyCpco3mlqjppx8Vuzls0 Ljy06+BIBmOt5DjnaQsoxKeccS7OS0A9nV9qN33OpWguEoRgU0f1Wiu6rSA/cs4pva16 3WRZXrlUgW6DV7zxxm0xDNQpHmEq55HEe72SWInhXt+oQ31agTpy+gGC8N6XjFDABjAP sh3vwHLPEs/Utzw/0x3GslmCWltEGh+OhGUL1nBmofbgkKxjV50+UWwmH36AulfyIpB5 eFRw== X-Forwarded-Encrypted: i=1; AJvYcCUBc1Novpwns9mCNKVzawFnbEtuQi2ICuIfUQ4NTT/NXDRcuepn5qmylaGULweY0Y/XhlF007eyOdMPSYONHzvp@lists.infradead.org, AJvYcCWNtUW9uz5yhlImvkjdn2ssRxP8gOVUosemUus4hYEigrhAe+j7HEBFLNepP2sLP1Au1J53+2kXw7ZJ7Z3lAM4B9g==@lists.infradead.org X-Gm-Message-State: AOJu0Yy6DDowQ5t+k4mAVhi3Ko9Y3f4JTUyWJ1Cje1L2aMGRvJu6Cc41 YRH0CMb5EjSq6SqTv7u21rtHUATvIMvkPn8+/v3XzzvkuQIevYAf X-Google-Smtp-Source: AGHT+IEnKxIrxAqO2yMslPQVUsLZu3CEkdqhcXEM8psyFKKxqQu8lQa8q2OwwTsXhO/wcBSH9bwImw== X-Received: by 2002:a17:907:e267:b0:a7a:a892:8e05 with SMTP id a640c23a62f3a-a998d207690mr632663066b.33.1728573269978; Thu, 10 Oct 2024 08:14:29 -0700 (PDT) Received: from ?IPV6:2a02:3100:ac3e:8500:f101:eb49:ef42:3d5f? (dynamic-2a02-3100-ac3e-8500-f101-eb49-ef42-3d5f.310.pool.telefonica.de. [2a02:3100:ac3e:8500:f101:eb49:ef42:3d5f]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a99a80efb5bsm100519566b.192.2024.10.10.08.14.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Oct 2024 08:14:29 -0700 (PDT) Message-ID: <85184790-532b-46c2-9b67-2eb8d74a53f2@gmail.com> Date: Thu, 10 Oct 2024 17:14:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/9] hwmon: Add and use helper hwmon_visible_0444 To: Guenter Roeck , Tim Harvey , Jean Delvare , Xu Yilun , Tom Rix , Jonas Malaco , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Florian Fainelli , Michael Walle , Maximilian Luz , Ivor Wanders Cc: Broadcom internal kernel review list , "linux-hwmon@vger.kernel.org" , linux-rpi-kernel@lists.infradead.org, "linux-arm-kernel@lists.infradead.org" References: <3aecbfc5-e11b-4425-9c6b-88dac2d32945@gmail.com> <5ae4e8b9-1442-4764-9a16-db08d099a1e6@roeck-us.net> Content-Language: en-US From: Heiner Kallweit Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241010_081432_393398_E1726737 X-CRM114-Status: GOOD ( 22.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10.10.2024 16:31, Guenter Roeck wrote: > On 10/9/24 22:44, Heiner Kallweit wrote: >> On 10.10.2024 00:19, Guenter Roeck wrote: >>> On 10/9/24 13:02, Heiner Kallweit wrote: >>>> Several drivers simply return 0444 in their is_visible callback. >>>> Add a helper in hwmon core for this use case to avoid code duplication. >>>> >>>> There are more drivers outside drivers/hwmon which would benefit >>>> from this helper as well. >>>> >>>> Heiner Kallweit (9): >>>>     hwmon: Add helper hwmon_visible_0444 >>>>     hwmon: i5500_temp: Use new helper hwmon_visible_0444 >>>>     hwmon: surface_fan: Use new helper hwmon_visible_0444 >>>>     hwmon: sl28cpld: Use new helper hwmon_visible_0444 >>>>     hwmon: gsc: Use new helper hwmon_visible_0444 >>>>     hwmon: powerz: Use new helper hwmon_visible_0444 >>>>     hwmon: raspberrypi: Use new helper hwmon_visible_0444 >>>>     hwmon: intel-m10-bmc: Use new helper hwmon_visible_0444 >>>>     hwmon: nzxt-kraken2: Use new helper hwmon_visible_0444 >>>> >>>>    drivers/hwmon/gsc-hwmon.c           |  9 +-------- >>>>    drivers/hwmon/hwmon.c               |  7 +++++++ >>>>    drivers/hwmon/i5500_temp.c          |  8 +------- >>>>    drivers/hwmon/intel-m10-bmc-hwmon.c |  9 +-------- >>>>    drivers/hwmon/nzxt-kraken2.c        |  9 +-------- >>>>    drivers/hwmon/powerz.c              |  8 +------- >>>>    drivers/hwmon/raspberrypi-hwmon.c   |  8 +------- >>>>    drivers/hwmon/sl28cpld-hwmon.c      |  9 +-------- >>>>    drivers/hwmon/surface_fan.c         | 10 +--------- >>>>    include/linux/hwmon.h               |  2 ++ >>>>    10 files changed, 17 insertions(+), 62 deletions(-) >>>> >>> >>> I really don't want to add such hwmon-specific but at the same time >>> generic helpers. If such a helper is made available in the core kernel, >>> I'll be happy to accept patches using it, but otherwise please refrain >>> from submitting such patch series. >>> >> What would you consider a suited place, drivers/base or fs/sysfs or lib or .. ? >> For enum hwmon_sensor_types we have to include linux/hwmon.h. None of these >> places has any hwmon code, and I would expect concerns if generic core code >> includes subsystem headers. >> > > "There are more drivers outside drivers/hwmon which would benefit > from this helper as well" very clearly suggests that the function > is not hwmon specific. Yet, obviously it is if it requires a hwmon > include file. > What I was referring to is device drivers in other subsystems which expose e.g. thermal sensor data via hwmon API. > If this is hwmon specific, I'll want to see a different solution. > Instead of calling an exported function, hwmon drivers should set the > is_visible callback to a defined value, such as HWMON_VISIBLE_0444. > This could be an ERR_PTR() which is converted by the hwmon core. > This lets us add, for example, HWMON_VISIBLE_0644, and it avoids the > notion that the function could be called by non-hwmon drivers > (and the notion that it is a function in the first place). Instead > of calling the callback directly, the hwmon core would then have a > helper function which evaluates the pointer and either returns > a constant or calls the callback. > What goes in the same direction, but may be better/cleaner: We could add an umode_t parameter to struct hwmon_ops, and if it's non-zero then hwmon core interprets it as static visibility instead of calling is_visible(). > Guenter > Heiner