From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9DB6CD128A for ; Wed, 3 Apr 2024 12:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SPtBbwCwNvGDy4vdXU/74i+haQ0jN22lFE0aLEE1u6U=; b=NRVu82j3hAynT1 0sRNE6w6JsxVZL1/2mOp6vxPjWMaVsjOt/SIET1oASr8i47BJYWw5GhmKTSfBtig2lRt0BKYHKGBO pX76M8IMFuYQKDrYcJAs/c8zWpNCmvJMIZyuYmwkh/obcgVsd/mE3QPCDLL2yaZFpdGSCWGzHEvR2 n/i4JoQN5OwzJgfRzoQTC+XsBK9OoVWOXcxnjhymTZEZZALeYibHxD7RQvq7nGeOcZSri24AtxR5/ aITOT3OR8S4FO6trd2AA6CcWJthXKNW6TIoOT5JwjWhseeq+OC/zACa3mJn0E+EOsre8xf8Y3VFHI dFE//lpMMHiL4lZijl/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrzr0-0000000Fxd0-0N7U; Wed, 03 Apr 2024 12:36:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrzqx-0000000FxcP-1Fk7 for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 12:36:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3E0A81007; Wed, 3 Apr 2024 05:37:01 -0700 (PDT) Received: from [10.57.72.191] (unknown [10.57.72.191]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E6D6F3F64C; Wed, 3 Apr 2024 05:36:27 -0700 (PDT) Message-ID: <8519bb4c-e8b4-436c-bd3b-4a08e328a6ec@arm.com> Date: Wed, 3 Apr 2024 13:36:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/4] Update Energy Model after chip binning adjusted voltages Content-Language: en-US To: Dietmar Eggemann Cc: linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, rafael@kernel.org, linux-pm@vger.kernel.org, nm@ti.com, linux-samsung-soc@vger.kernel.org, daniel.lezcano@linaro.org, viresh.kumar@linaro.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, m.szyprowski@samsung.com, mhiramat@kernel.org, linux-kernel@vger.kernel.org References: <20240402155822.505491-1-lukasz.luba@arm.com> <045fa6db-4f76-46aa-85ba-c9e698c7e390@arm.com> From: Lukasz Luba In-Reply-To: <045fa6db-4f76-46aa-85ba-c9e698c7e390@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_053631_532905_973F7106 X-CRM114-Status: GOOD ( 19.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dietmar, On 4/3/24 13:07, Dietmar Eggemann wrote: > On 02/04/2024 17:58, Lukasz Luba wrote: >> Hi all, >> >> This is a follow-up patch aiming to add EM modification due to chip binning. >> The first RFC and the discussion can be found here [1]. >> >> It uses Exynos chip driver code as a 1st user. The EM framework has been >> extended to handle this use case easily, when the voltage has been changed >> after setup. On my Odroid-xu4 in some OPPs I can observe ~20% power difference. >> According to that data in driver tables it could be up to ~29%. >> >> This chip binning is applicable to a lot of SoCs, so the EM framework should >> make it easy to update. It uses the existing OPP and DT information to >> re-calculate the new power values. >> >> It has dependency on Exynos SoC driver tree. >> >> Changes: >> v4: >> - added asterisk in the comment section (test robot) >> - change the patch 2/4 header name and use 'Refactor' >> v3: >> - updated header description patch 2/4 (Dietmar) >> - removed 2 sentences from comment and adjusted in patch 3/4 (Dietmar) >> - patch 4/4 re-phrased code comment (Dietmar) >> - collected tags (Krzysztof, Viresh) >> v2: >> - removed 'ret' from error message which wasn't initialized (Christian) >> v1: >> - exported the OPP calculation function from the OPP/OF so it can be >> used from EM fwk (Viresh) >> - refactored EM updating function to re-use common code >> - added new EM function which can be used by chip device drivers which >> modify the voltage in OPPs >> RFC is at [1] >> >> Regards, >> Lukasz Luba >> >> [1] https://lore.kernel.org/lkml/20231220110339.1065505-1-lukasz.luba@arm.com/ >> >> Lukasz Luba (4): >> OPP: OF: Export dev_opp_pm_calc_power() for usage from EM >> PM: EM: Refactor em_adjust_new_capacity() >> PM: EM: Add em_dev_update_chip_binning() >> soc: samsung: exynos-asv: Update Energy Model after adjusting voltage >> >> drivers/opp/of.c | 17 +++-- >> drivers/soc/samsung/exynos-asv.c | 11 +++- >> include/linux/energy_model.h | 5 ++ >> include/linux/pm_opp.h | 8 +++ >> kernel/power/energy_model.c | 106 +++++++++++++++++++++++++------ >> 5 files changed, 122 insertions(+), 25 deletions(-) > > LGTM. > > Just two very minor things which I mentioned in the individual patches. > > Reviewed-by: Dietmar Eggemann > > > Thank you for the review. I will send the v5 with those. Regards, Lukasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel