From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EEF3C433FE for ; Tue, 22 Nov 2022 16:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OK5vAybKRrhXIzp+nP3er6vtK+PUa16ZnEGPIRG4AHk=; b=lfjRvImfphPZEw sbY4TfujzR52CWa85Ca9PvZlIaKDIN+tglD3KGUbDqEVLPl1f6b21z49lmpQrZGLEXEFl3oRmp1W8 2JoqpITDanseH2zDyMm5+2stXvFxEBS4ir+kZ8YAH2Ck1yWcbAwIrmaC4Cirlu5Qhmv/ORducm9LZ gZ3Y4yA+aBJsgOmmoPBcLWALEWQJZ6UxAXzTdHMOXl1KKwo8P/nW545owoaoas3CJcMwoxN2jejdy JPNxD3hyZkibL1k21TzD9uXbuOmWCaDjtHt35ebw9casGi5twQMX29ksrTAWjE0ewYDUp8Z1qGE62 r5lusnxkl7bO229iPZNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxW57-00AhUB-Kk; Tue, 22 Nov 2022 16:25:09 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxW54-00AhSR-0y; Tue, 22 Nov 2022 16:25:07 +0000 Received: by mail-wr1-x42e.google.com with SMTP id b12so11712095wrn.2; Tue, 22 Nov 2022 08:25:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KUbsY7ePXJlrYJo3GzHlSRELE0khC6HUiaH0TPVJCl0=; b=Kj9CGuLF/61MNCZIpbNvs1tlut/pgQKbQKT0FROY/5UN+RVaq7jj4LDtVm9MRVnC4m XDGlHX4uRVqDEr5FN/dSUwTGBB66AgF4FEUtd8/+B/dXUBxSy6XHkNhFSxJ2+GVcDmWI AejdaSGJI1DAvwArban9rukEJJV5APpSTEHqckbpwjtMJgSvDnFi8XPcGpFGvA+RUkBW /x1f7bC5z8WtHndKGx2ZGaKfdunOqlpgTSg5kqAd4YwzvJrDXEsz+yqOm4Y1zJ0lhO20 oN96JMfqZxucR/gzYyVndVXBSnVCvl0QAKBa2q6kUdA1yy1RxWhwp6RiacaTzsbQoo47 bt8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KUbsY7ePXJlrYJo3GzHlSRELE0khC6HUiaH0TPVJCl0=; b=hBtT65n7lozWn/sF/1hFdanqf6u/3To60rZvEnJFb6ystWlXGC97mmgWPZcGTplRON wIEZ5pmv2ycIQ/BnVFYst0Tkxu2sIYUloeKO1aAYdqrshyO8tQFrU6xrwLK06DbxRSaw e5sCa5n2do+NoyO7Z+4DQvIOjqDlUDKsr9WMX8Cuja8DQYDGTys1azXiLxQnaQbJrPo1 wEM9DYN0JvoovvV+IjElSPsnIuiW+u2DSk5NQOlgijwbdkZaqrgEeANlIa/yHoTAtuhx trzI/6c6OVf/rN3CMaZkR1lNzAUXp9Xs2+HufmdFZPI1gqK06dkMH9li6buDH6z+q+cc UgcA== X-Gm-Message-State: ANoB5pnJfvXydjdSB6bRuzLG1tHnCQta71yr+M2YMTGVbt1X1MRCPNMg 9aQxIBfLuKL2bYlVx9qRLhI= X-Google-Smtp-Source: AA0mqf4UmUVT3FkH3QYSEHLuTy5dEpoGCEYf+L+dfFyrESBGCCf5sf1IgYOyuYLsLsTco5qqeT/6ow== X-Received: by 2002:a5d:6051:0:b0:22f:da60:345 with SMTP id j17-20020a5d6051000000b0022fda600345mr14580850wrt.218.1669134302216; Tue, 22 Nov 2022 08:25:02 -0800 (PST) Received: from [192.168.0.25] ([37.222.251.204]) by smtp.gmail.com with ESMTPSA id a8-20020adffb88000000b002383fc96509sm14394702wrr.47.2022.11.22.08.24.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Nov 2022 08:25:00 -0800 (PST) Message-ID: <8549c4b4-bc0a-ab6d-dceb-e694af2e8148@gmail.com> Date: Tue, 22 Nov 2022 17:24:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v7 1/6] iommu/mediatek: Add platform_device_put for recovering the device refcnt Content-Language: en-US To: Yong Wu , Joerg Roedel , Will Deacon Cc: Robin Murphy , iommu@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , mingyuan.ma@mediatek.com, yf.wang@mediatek.com, libo.kang@mediatek.com, chengci.xu@mediatek.com, youlin.pei@mediatek.com, anan.sun@mediatek.com, xueqi.zhang@mediatek.com, Guenter Roeck , Dan Carpenter References: <20221018024258.19073-1-yong.wu@mediatek.com> <20221018024258.19073-2-yong.wu@mediatek.com> From: Matthias Brugger In-Reply-To: <20221018024258.19073-2-yong.wu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221122_082506_097173_60C3254B X-CRM114-Status: GOOD ( 20.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/10/2022 04:42, Yong Wu wrote: > Add platform_device_put to match with of_find_device_by_node. > > Meanwhile, I add a new variable "pcommdev" which is for smi common device. > Otherwise, "platform_device_put(plarbdev)" for smi-common dev may be not > readable. And add a checking for whether pcommdev is NULL. > > Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE") > Signed-off-by: Yong Wu > Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Matthias Brugger > --- > drivers/iommu/mtk_iommu.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 5a4e00e4bbbc..3189b585725f 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -1043,7 +1043,7 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m > struct mtk_iommu_data *data) > { > struct device_node *larbnode, *smicomm_node, *smi_subcomm_node; > - struct platform_device *plarbdev; > + struct platform_device *plarbdev, *pcommdev; > struct device_link *link; > int i, larb_nr, ret; > > @@ -1074,12 +1074,14 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m > } > if (!plarbdev->dev.driver) { > of_node_put(larbnode); > + platform_device_put(plarbdev); > return -EPROBE_DEFER; > } > data->larb_imu[id].dev = &plarbdev->dev; > > component_match_add_release(dev, match, component_release_of, > component_compare_of, larbnode); > + platform_device_put(plarbdev); > } > > /* Get smi-(sub)-common dev from the last larb. */ > @@ -1097,12 +1099,15 @@ static int mtk_iommu_mm_dts_parse(struct device *dev, struct component_match **m > else > smicomm_node = smi_subcomm_node; > > - plarbdev = of_find_device_by_node(smicomm_node); > + pcommdev = of_find_device_by_node(smicomm_node); > of_node_put(smicomm_node); > - data->smicomm_dev = &plarbdev->dev; > + if (!pcommdev) > + return -ENODEV; > + data->smicomm_dev = &pcommdev->dev; > > link = device_link_add(data->smicomm_dev, dev, > DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME); > + platform_device_put(pcommdev); > if (!link) { > dev_err(dev, "Unable to link %s.\n", dev_name(data->smicomm_dev)); > return -EINVAL; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel