From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBF20C4167B for ; Thu, 7 Dec 2023 08:42:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aGgzFUkBv+OoP0QovY2Ix6A5o4tf+D3DWCB8NTkGcA4=; b=rY1IX+NQd9SQSR hUASYqqBkjj/TO9ACqAsYJ5KXf1ltXgm+CjDpWu8Nxq/EMiyrCTbmOXV3eLjDgD+izWvmHt0nCeMS yy4/gbMQGbRBan9JM4hWu8VI5khJT1S4uavMLt++8Mm6jw3fCI4OUGuTC+WIAq1ZjL99ZgZZumMlr pZecLoHTYvXm5L3PzUQ9G2Y+u82emlboqXpFg2trnLtvBtllgHr5Ig/7ha3m3JKA7g5mdn/2f83ZU cX0pddqZUg92U0VKnRk9CHYDHp0j/DYK6B28ZHE/IkUD6obr078sRP7BnkDsLBfpoD4KAOHR7/6pP ZIy6FB4uddjlLpR0HQQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rB9x8-00CGE3-0B; Thu, 07 Dec 2023 08:41:50 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rB9x5-00CGDR-1e; Thu, 07 Dec 2023 08:41:48 +0000 Received: from [192.168.1.105] (unknown [103.251.226.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 25C39674; Thu, 7 Dec 2023 09:41:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1701938465; bh=93l+9CL07fUHXweF9htomsrCAQvCW+NUdbeYY60Y0hU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ssr8Lzq59teWKgbWcSKaCTt5hKewYBK/knFCQmPXH/+fSwmPFw+uoIcOMuEJ/wvyo hx8lmXjN/qFPjXdHgqHkUJWcW5m7Be49qtUn6VESn/hKESZh7VLDZfKSnzzoIy6F4o TmmVZInywWis1Ho7gZalFYWt3LzoKlJ6mClEhkl8= Message-ID: <855cd4ee-86db-ca46-ce91-17303941ff82@ideasonboard.com> Date: Thu, 7 Dec 2023 14:11:36 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 1/4] staging: vc04_services: Drop vchiq_log_error() in favour of dev_err To: Stefan Wahren , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , "Ricardo B . Marliere" References: <20231205084157.73819-1-umang.jain@ideasonboard.com> <20231205084157.73819-2-umang.jain@ideasonboard.com> <6a8566c0-bd26-4ec1-9f7d-d58bbed8411c@ideasonboard.com> <3920385c-3c10-471a-ba82-8e48ba34f6a5@gmx.net> Content-Language: en-US From: Umang Jain In-Reply-To: <3920385c-3c10-471a-ba82-8e48ba34f6a5@gmx.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231207_004147_690426_F092AB47 X-CRM114-Status: GOOD ( 14.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan On 12/7/23 3:04 AM, Stefan Wahren wrote: > Hi Umang, > > Am 06.12.23 um 06:27 schrieb Umang Jain: >> Hi Stefan >> >> On 12/6/23 1:02 AM, Stefan Wahren wrote: >>> Hi Umang, >>> >>> Am 05.12.23 um 09:41 schrieb Umang Jain: >>>> Drop vchiq_log_error() macro which wraps dev_dbg(). Introduce the >>>> usage >>>> of dev_err() directly. >>> sorry, i missed to review the last change. So the change won't be that >>> trivial. >> >> All the changes you said are valid and I have taken a note of it. >> >> However, I think it would best that if we can address them in a >> separate series on top of this (and I will do it). It would seem to be >> streamlined on top of this. > i would address the comments as separate patches and then finally > convert the trivial rest with such a patch within one series. This > avoids unnecessary changes and reviewes. But that's just my opinion. > Series is merged by Greg KH (Thank you). Do you have more comments on 3/4 and 4/4 or are they waiting on your review queue. Let me know so that I can prepare a follow up series in -one- go. thanks! > Best regards _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel