From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/9] omap: clocks: Add checks to see if enable/disable ops are supported
Date: Tue, 8 Feb 2011 08:55:52 +0530 [thread overview]
Message-ID: <85772086dbd5bbd435fe7779ded71b3b@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1102071846570.21991@utopia.booyaka.com>
> -----Original Message-----
> From: Paul Walmsley [mailto:paul at pwsan.com]
> Sent: Tuesday, February 08, 2011 7:18 AM
> To: Santosh Shilimkar
> Cc: linux-omap at vger.kernel.org; khilman at ti.com; b-cousson at ti.com;
rnayak at ti.com; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCH v2 4/9] omap: clocks: Add checks to see if
enable/disable ops are supported
>
> On Fri, 4 Feb 2011, Santosh Shilimkar wrote:
>
> > From: Rajendra Nayak <rnayak@ti.com>
> >
> > Check if enable/disable operations are supported for a given
> > clock node before attempting to call them.
> >
> > Signed-off-by: Rajendra Nayak <rnayak@ti.com>
> > ---
> > arch/arm/mach-omap2/clock.c | 14 +++++++++-----
> > 1 files changed, 9 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
> > index 2a2f152..5c08c18 100644
> > --- a/arch/arm/mach-omap2/clock.c
> > +++ b/arch/arm/mach-omap2/clock.c
> > @@ -261,7 +261,8 @@ void omap2_clk_disable(struct clk *clk)
> >
> > pr_debug("clock: %s: disabling in hardware\n", clk->name);
> >
> > - clk->ops->disable(clk);
> > + if (clk->ops && clk->ops->enable)
> > + clk->ops->disable(clk);
>
> Shouldn't that read:
>
> if (clk->ops && clk->ops->disable)
>
> ?
Oops.. I guess it should. Will fix that and repost.
>
>
> - Paul
next prev parent reply other threads:[~2011-02-08 3:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 9:58 [PATCH v2 0/9] omap4: prcm: Few dpll, clockdomain and powerdomain updates Santosh Shilimkar
2011-02-04 9:58 ` [PATCH v2 1/9] omap4: powerdomain: Add supported INACTIVE power state Santosh Shilimkar
2011-02-06 20:42 ` Paul Walmsley
2011-02-07 7:03 ` Santosh Shilimkar
2011-02-08 1:32 ` Paul Walmsley
2011-02-08 6:41 ` Santosh Shilimkar
2011-02-04 9:58 ` [PATCH v2 2/9] omap4: prcm: Fix the CPUx clockdomain offsets Santosh Shilimkar
2011-02-08 4:55 ` Paul Walmsley
2011-02-25 20:07 ` Paul Walmsley
2011-02-04 9:58 ` [PATCH v2 3/9] omap4: powerdomain: Use intended PWRSTS_* flags instead of values Santosh Shilimkar
2011-02-08 1:45 ` Paul Walmsley
2011-02-08 6:37 ` Santosh Shilimkar
2011-02-25 20:10 ` Paul Walmsley
2011-02-04 9:58 ` [PATCH v2 4/9] omap: clocks: Add checks to see if enable/disable ops are supported Santosh Shilimkar
2011-02-08 1:48 ` Paul Walmsley
2011-02-08 3:25 ` Rajendra Nayak [this message]
2011-02-04 9:59 ` [PATCH v2 5/9] omap: clocks: Add allow_idle/deny_idle support in clkops Santosh Shilimkar
2011-02-04 9:59 ` [PATCH v2 6/9] omap: dpll: Add allow_idle/deny_idle support for all DPLL's Santosh Shilimkar
2011-02-08 2:57 ` Paul Walmsley
2011-02-08 3:28 ` Rajendra Nayak
2011-02-08 3:40 ` Paul Walmsley
2011-02-08 4:17 ` Rajendra Nayak
2011-02-08 4:16 ` Paul Walmsley
2011-02-04 9:59 ` [PATCH v2 7/9] omap4: dpll: Add dpll api to control GATE_CTRL Santosh Shilimkar
2011-02-04 9:59 ` [PATCH v2 8/9] omap4: dpll: Enable auto gate control for all MX postdividers Santosh Shilimkar
2011-02-04 9:59 ` [PATCH v2 9/9] omap4: clockdomain: Fix the CPUx domain name Santosh Shilimkar
2011-02-08 4:58 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85772086dbd5bbd435fe7779ded71b3b@mail.gmail.com \
--to=rnayak@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).