From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 771D6C30653 for ; Thu, 4 Jul 2024 13:05:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2uPuMCUt+0PiW5wgXWRLYWMzfYRTfHb3fi4+BnRHVqA=; b=X00SxCRE0hsL/aPQVJO8wGraJS TUNOROgwvJZ4JCcrI8X1pwRIni2cBfYcbX6rf9xOFn4gba2Aac5pjW05rJ+1yp2ROeAqlrLAi2RT7 fMQniONjjVk5CcVfEjvbleV+TK6wEhhARu0lt/PiMrNaThycP60Z+fU9bAXzyqQwcO50b6dTkOpIX W/fD683RlmFRkey7kA0b3++toWo5Soqx6Ai62H9y/bAsJ3XrVQu7cbgTRtn1dKiclFrsDN7l/sUhJ 4kSpwamkwnUuFoZHOVUf/SWxDSNPQUKZGgIE0VwSZXAOyyY6HINJbdJdXkCGDXqA0eOTLwPfe+PQv udOAFgNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPM96-0000000DDLd-0Dqs; Thu, 04 Jul 2024 13:05:08 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sPM8s-0000000DDHV-0Eyn; Thu, 04 Jul 2024 13:04:55 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-58b447c511eso836389a12.2; Thu, 04 Jul 2024 06:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720098292; x=1720703092; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2uPuMCUt+0PiW5wgXWRLYWMzfYRTfHb3fi4+BnRHVqA=; b=NOueKwvFoEdyf0YH4zFjX8v4SQpK0hmxpELeG7T/pxLGKwRed4RkBv4OWmU4RPtv6Z SaFjBsogCaro58chsgcD5mI3V8bDAk4LjdM2/7NBDrlLSWq95/l9fwHOkHmqhF/u+OHg OrfeUSSKZgnANjH85DpKYS276noiF84BrqH4JMgCWJx8JmqNb8935gUCPk+peoA8CSfl +BGm6n1fq4x8Zp+fUXqKMUAGNUJomkrwdcHsjA5cfDryNiLy9EoT7ME9ljnpXR7ge8VN mzljeA3I+qDDxBzS68AO/M/vtTREJ9XB/PIY+OLoYB1/eEfBpcH8G/TA18c2oRwbxDuz pTlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720098292; x=1720703092; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2uPuMCUt+0PiW5wgXWRLYWMzfYRTfHb3fi4+BnRHVqA=; b=P29tawtfelpSGUHS/13dNNm+R1CsTPPPp+0yuB2vXPiqsacboixj84uS5zo2nHL+kX /8QqtSYXUVBrzNO4q3DZwLgZiO5RfCl5lmkHjhWryFx3GMJQ/B434JZ0YNgopYvNZwrR FUePJDcujMAaZHji2bdbonzNOJcPv/P+TTeaa7etRhr2wiwqjIYHB2UWPgoS8WgCBNmw E2Au7CRnwQsM9WbZt7uo+gTrbQ+Tu6lxLbSUin01VHqqKlKLxzuKwowWlnnaVMCvok8Q 2JNalq/ooFPvWbuc2fk0COkkGtKuAxowsqsCGcmkxIxB5QPS2pRudaRgP8x2l8q2haOJ 7daQ== X-Forwarded-Encrypted: i=1; AJvYcCXxBFTamTRogvc9gcYeKDP+sgGPa36+XX9HfMTYwn/1lRK/xF7p19+7TgdacByPls9Yftlkj5TjLAULGuu47dLYrlonf+ymqGSxfBu/YLJZao9Px/7C+ppGZ9/kzl85UaasKmtmoFk9ISL0nMGPDCif9f+Tfp7UYXk= X-Gm-Message-State: AOJu0YxRdvFVQqLDr4681e2cwq/s3XPLCwAsCxYXY35XphBXmwdgQ7+O PC/bNl7vsDHSQsLmYO6Paiv9yXwklNnPPL3LBcfvabLvVIrGAo0= X-Google-Smtp-Source: AGHT+IFZIcyALDt43Fk8aUWhime9uuJbu6aaRpQ6g07IxAblZfpNL/zdJWjjDDngZz0vSZjneaXhtQ== X-Received: by 2002:a17:906:1158:b0:a72:8d4f:6720 with SMTP id a640c23a62f3a-a77ba72b9dfmr113893666b.69.1720098291839; Thu, 04 Jul 2024 06:04:51 -0700 (PDT) Received: from ?IPV6:2a02:810b:f40:4600:ec22:4ef6:28e0:c5f3? ([2a02:810b:f40:4600:ec22:4ef6:28e0:c5f3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72aaf1bb6bsm595903366b.30.2024.07.04.06.04.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jul 2024 06:04:51 -0700 (PDT) Message-ID: <85e2ed16-47aa-498c-90a3-0910e5dd97f4@gmail.com> Date: Thu, 4 Jul 2024 15:04:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: rockchip: add rock5 itx board To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , linux-rockchip@lists.infradead.org, Diederik de Haas Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240703210524.776455-1-heiko@sntech.de> <4552794.8F6SAcFxjW@diego> <2c46dfb7-5ef3-494f-8cf1-413033e73412@gmail.com> <2004736.8hb0ThOEGa@diego> Content-Language: en-US From: Alex Bee In-Reply-To: <2004736.8hb0ThOEGa@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240704_060454_118126_53090589 X-CRM114-Status: GOOD ( 15.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 04.07.24 um 14:05 schrieb Heiko Stübner: > Am Donnerstag, 4. Juli 2024, 13:43:47 CEST schrieb Alex Bee: >> Am 04.07.24 um 12:05 schrieb Heiko Stübner: >>> Hi Diederik, >>> >>> Am Donnerstag, 4. Juli 2024, 11:38:51 CEST schrieb Diederik de Haas: >>>> Thanks for submitting this. A quick scan indicates it should work with a >>>> (recent) Debian kernel OOTB :-) >>>> >>>> On Wednesday, 3 July 2024 23:05:24 CEST Heiko Stuebner wrote: >>>>> +&sdhci { >>>>> + bus-width = <8>; >>>>> + no-sdio; >>>>> + no-sd; >>>>> + non-removable; >>>>> + max-frequency = <200000000>; >>>>> + mmc-hs400-1_8v; >>>>> + mmc-hs400-enhanced-strobe; >>>>> + mmc-hs200-1_8v; >>>>> + status = "okay"; >>>>> +}; >>>>> + >>>>> +&sdmmc { >>>>> + max-frequency = <200000000>; >>>>> + no-sdio; >>>>> + no-mmc; >>>>> + bus-width = <4>; >>>>> + cap-mmc-highspeed; >>>>> + cap-sd-highspeed; >>>>> + disable-wp; >>>>> + sd-uhs-sdr104; >>>>> + vmmc-supply = <&vcc_3v3_s3>; >>>>> + vqmmc-supply = <&vccio_sd_s0>; >>>>> + pinctrl-names = "default"; >>>>> + pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc_det>; >>>>> + status = "okay"; >>>>> +}; >>>>> + >>>>> +/* M.2 E-KEY */ >>>>> +&sdio { >>>>> + broken-cd; >>>>> + bus-width = <4>; >>>>> + cap-sdio-irq; >>>>> + disable-wp; >>>>> + keep-power-in-suspend; >>>>> + max-frequency = <150000000>; >>>>> + mmc-pwrseq = <&sdio_pwrseq>; >>>>> + no-sd; >>>>> + no-mmc; >>>>> + non-removable; >>>>> + pinctrl-names = "default"; >>>>> + pinctrl-0 = <&sdiom0_pins>; >>>>> + sd-uhs-sdr104; >>>>> + vmmc-supply = <&vcc3v3_ekey>; >>>>> + status = "okay"; >>>>> +}; >>>>> + >>>>> +&sfc { >>>>> + pinctrl-names = "default"; >>>>> + pinctrl-0 = <&fspim2_pins>; >>>>> + status = "okay"; >>>> Shouldn't those properties be sorted alphabetically? Or at least consistently? >>>> Note that the same issue is present on other places too, but I believe the >>>> above quoted part shows the issue enough. >>> The main sorting is >>> - compatible >>> - reg >>> [... alphabetically ...] >>> - status >>> >> Yeah ... that's always the question when adding new board files. Do it like >> "it's always been done" or re-sort the properties alphanumeric _everywhere_ >> which looks quite strange at times. If I'm getting the newly added dt >> coding style correctly common (subsystem?) properties should also be placed >> before vendor (driver?) specific ones. Yet I didn't see a board file which >> places 'regulator-max-microvolt' before 'regulator-min-microvolt'. So I >> guess it's fine if it's done consistently within the same file? > I always see it as a best-effort thing. If all regulator-* stuff is grouped > together it will be mostly fine. I'm not going to haggle over the sorting > of the 10th character of property names ;-) . > > (and of course reading min before max, is sort of more intuitive) > > And of course leaf-things (board dts) are less "important" than the core > nodes in soc devicetrees. > Great, thanks for sharing. Will (try) to follow in future. Alex >