From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B75C4CD13D8 for ; Sat, 31 Aug 2024 15:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2CEOjK3+I6m6XV07ddXyAN85PV8Q65Umk8iIBSqhSAg=; b=e0noPvjHUmCn/4oLx2tNqNDoax 1vMiyxY5lU2yYMCYkL0cza13QuEjPRhnJ/R+ju7ypSERjmbaEmtdip5iqs4zi34yMNArXwA636u89 UAcCWGs+6k1RcMmWw7vrPyJ2gr9mFzvr10PH40M0+8e+Lyw+o+vmFajHy1nBj/VTHyaxI20tziFzd auRnbl8Is7gHOfiHoYTDDarc9wielpCRL5/0QuMZDeh9fHEcqqB2oi0f4UjI1BR4fbGrKrLjHJUbI pU3D+NyZnm/5Gvskc7uAZJ8Vbf1sT42nJz61ucA8TBJdKCIsybyijmpZndxESO+FCPnzD1gijjCXm tF7rh2EQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1skQ5U-00000009aYb-0HJU; Sat, 31 Aug 2024 15:32:28 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1skQ4b-00000009aSu-2C18 for linux-arm-kernel@lists.infradead.org; Sat, 31 Aug 2024 15:31:35 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-42bb8cf8a5bso19779805e9.2 for ; Sat, 31 Aug 2024 08:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1725118291; x=1725723091; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2CEOjK3+I6m6XV07ddXyAN85PV8Q65Umk8iIBSqhSAg=; b=mZNQzU3BOpaeZe48VJesKZTHUZdwB8+5VQbA06ueEWlLADNwWXKvQ9RHyX+GWuyuEo 2I+zwi0Pxtog+m89+iECAoxnZl3Heleo6FxgE++TKr9p5VyxJ9TlDujIQav4MZBZdcMV 2OJ4VtmHy3S4AGMIsTU2S1XmNnqV+4IZ5opPaZuofjrKqX0x7xMbB0OG30gXhLO0vMXU Bm4qocOLcr2Etd5NYbyNjtMOwjktUwS89mi0A6Ah+R+dk2CGNe9W5wOoWKAhuOyLLIWR tb7DkDdigvKuRXsRmwQERJe0TlrN3rRezL3aRTzQv2S5oIczgCUOfLZGiH+B4125zF/c p+1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725118291; x=1725723091; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2CEOjK3+I6m6XV07ddXyAN85PV8Q65Umk8iIBSqhSAg=; b=wEk5jq/eE6aygtEraYumuhrAb1GgNtDlHuCVyGoL41M8hxfUZNW/+QoN5OQ2ger+QO t9YUBxkfQ+/mG32OUx6xiLGEP8JF9Y2uRZJ6fevgHsPGP7Mgz6/76bOQbZf5rarU3cis GfYWkUsJbp8lKUTNRK8uWKZEqApSkFuyrN+yqMhp/eMXSlHbwseqJlQ3WPiXQ65z59FY Knc+A1u3pbhSEeBTVb9doeIbjM2XHOuSk0EcFxydXU+GupjJ1+SCBV4VFJ8bnAnePGPg Qp+z5ta/G8k7otmfYNXwXYugxAAvepdGcVrxYnU6n17cr/ZLTeN6f8ou4UAVe3G/ppsT hOyw== X-Forwarded-Encrypted: i=1; AJvYcCWJARVMn42uEepqSHdL45HtvjzPXReueaeMKYrSwWAzNqQGecjH9S8/dkAeotJij20O4igYJZA93F9kLw5+qRSH@lists.infradead.org X-Gm-Message-State: AOJu0Yz5OZSSNXzukemadAn0ruuImbp1HKJlfd6TQ7YicCdkQMpJ8A+d /fnVs+lvADbvZWXXItf6Q6oyOdXTkmEFj2LlN4sFhcZOgq3lraVpGbs70Z9f2z2ayb2E1mlHqdc U X-Google-Smtp-Source: AGHT+IEtXhnWcJIqV3twT2kpt1vTDEto7JbVHcOrgywhbCWyeChW/zqbdIf9e/yto9DDK2RIMg4Zug== X-Received: by 2002:a05:600c:4455:b0:426:5cee:4abc with SMTP id 5b1f17b1804b1-42bb0262d4emr74545385e9.20.1725118291319; Sat, 31 Aug 2024 08:31:31 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6df0a4dsm78783175e9.12.2024.08.31.08.31.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Aug 2024 08:31:30 -0700 (PDT) Message-ID: <85f08de3-4718-43b8-abfc-7bc70dc8700f@tuxon.dev> Date: Sat, 31 Aug 2024 18:31:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 04/12] nvmem: microchip-otpc: Add SAM9X60 support Content-Language: en-US To: Christian Melki , Srinivas Kandagatla , "moderated list:MICROCHIP OTPC DRIVER" , open list , Nicolas Ferre References: <20240821105943.230281-1-ada@thorsis.com> <20240821105943.230281-5-ada@thorsis.com> <6a234b6b-ac4c-4fa8-8809-df56327f7b9c@tuxon.dev> <20240828-unworried-borough-b5738c8216f6@thorsis.com> From: claudiu beznea In-Reply-To: <20240828-unworried-borough-b5738c8216f6@thorsis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240831_083133_603536_C3BB757E X-CRM114-Status: GOOD ( 19.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Alexander, On 28.08.2024 11:09, Alexander Dahl wrote: > Hello Claudiu, > > Am Sat, Aug 24, 2024 at 06:53:53PM +0300 schrieb claudiu beznea: >> >> >> On 21.08.2024 13:59, Alexander Dahl wrote: >>> Register layout is almost identical to sama7g5 OTPC. >> >> Can you please mention some major differences? > > - SAMA7G5 has an additional bit SECURE in the OTPC Header Register > (OTPC_HR) not present on SAM9X60. > - SAMA7G5 has an additional register OTPC Secure Custom Address > Register (OTPC_SCAR) not present on SAM9X60. > - SAMA7G5 has an additional field SECDBG[7:0] in OTPC User Hardware > Configuration 0 Register (OTPC_UHC0R) not present on SAM9X60. > - SAMA7G5 has three additional bits (SCPGDIS, SCLKDIS, SCINVDIS) in > the OTPC User Hardware Configuration 1 Register (OTPC_UHC1R) not > present on SAM9X60. > > All are currently not used by the driver. > > Is adding this information to the commit message sufficient? More than enough. If you can do a summary of it would be better, I think. Thank you, Claudiu Beznea > > Greets > Alex > >> >>> >>> Signed-off-by: Alexander Dahl >>> --- >>> drivers/nvmem/microchip-otpc.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/nvmem/microchip-otpc.c b/drivers/nvmem/microchip-otpc.c >>> index bd3383eabdf6..b8ed7412dbca 100644 >>> --- a/drivers/nvmem/microchip-otpc.c >>> +++ b/drivers/nvmem/microchip-otpc.c >>> @@ -271,6 +271,7 @@ static int mchp_otpc_probe(struct platform_device *pdev) >>> >>> static const struct of_device_id __maybe_unused mchp_otpc_ids[] = { >>> { .compatible = "microchip,sama7g5-otpc", }, >>> + { .compatible = "microchip,sam9x60-otpc", }, >>> { }, >>> }; >>> MODULE_DEVICE_TABLE(of, mchp_otpc_ids);