From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27C46C4345F for ; Sun, 28 Apr 2024 02:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=G0FIh+CrQpDd8mrT+RPfetsZQxhYtHIheFr/iw2VSAk=; b=u48hIbYTIvjAjSnwcUdffIHdHE 0TUqGs4mQoadgwRJh46TEEBvj9ZZ96u4PTF8hXeZdrfhlLBrxklQvLS6NLSWeikPu93V17OQ8BrlM z7/REVuVN3i1RIgBctFrWJAXXHL+rpQjDRdvDwsxU871ZMRtHC2XS5Q5OZWBGwgq6LyUjAdbK5SnK ZKCXdyw9hUttbKLTb5s0kLZwFBa8lCaMWnhYC3NhGyNrFh1H3vuu0Fh9ZbrGHHh3ebCptPq2LztCd b1aoDmHX2PpO21kA1NJ5hgPTohE8vJzOXN+PAoIc3eNWWlRi2QXnSKiOOD3FOvpEP5WeLJV6PPMxL q8kLbLOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0u8o-0000000GdiM-23fk; Sun, 28 Apr 2024 02:19:46 +0000 Received: from [45.249.212.51] (helo=dggsgout11.his.huawei.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s0u8j-0000000GdhQ-31p9 for linux-arm-kernel@lists.infradead.org; Sun, 28 Apr 2024 02:19:43 +0000 Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4VRqsM47Kjz4f3m7L for ; Sun, 28 Apr 2024 10:19:19 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.112]) by mail.maildlp.com (Postfix) with ESMTP id EABA31A0568 for ; Sun, 28 Apr 2024 10:19:28 +0800 (CST) Received: from [10.174.178.55] (unknown [10.174.178.55]) by APP1 (Coremail) with SMTP id cCh0CgBnOBEusi1mIt2dLA--.32197S3; Sun, 28 Apr 2024 10:19:28 +0800 (CST) Subject: Re: [PATCH V3 1/2] iommu/arm-smmu-v3: Add support for ECMDQ register mode To: Tanmay Jagdale , will@kernel.org, robin.murphy@arm.com, joro@8bytes.org, nicolinc@nvidia.com, mshavit@google.com, baolu.lu@linux.intel.com, thunder.leizhen@huawei.com, set_pte_at@outlook.com, smostafa@google.com Cc: sgoutham@marvell.com, gcherian@marvell.com, jcm@jonmasters.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org References: <20240425144152.52352-1-tanmay@marvell.com> <20240425144152.52352-2-tanmay@marvell.com> From: "Leizhen (ThunderTown)" Message-ID: <85f8d4df-4e4b-0460-4e34-d38588f18639@huaweicloud.com> Date: Sun, 28 Apr 2024 10:19:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20240425144152.52352-2-tanmay@marvell.com> Content-Language: en-US X-CM-TRANSID: cCh0CgBnOBEusi1mIt2dLA--.32197S3 X-Coremail-Antispam: 1UD129KBjvJXoW7Aw13CF47GrW7Kry3XrW3GFg_yoW8Xrykpr 93Ka9rJFy8tF1xZw1FqF1UXF15tw1UJ3W8Gr4UGF93Xw18C34xur4UGw4Fy347Jry7Jr47 C34jqasrua1DJrUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvab4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7Mxk0xIA0c2IE e2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxV Aqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a 6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6x kF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv 67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyT uYvjxUo0eHDUUUU X-CM-SenderInfo: hwkx0vthuozvpl2kv046kxt4xhlfz01xgou0bp/ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240427_191942_088605_E5885166 X-CRM114-Status: GOOD ( 13.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024/4/25 22:41, Tanmay Jagdale wrote: > +static int arm_smmu_ecmdq_probe(struct arm_smmu_device *smmu) > +{ > + int ret, cpu; > + u32 i, nump, numq, gap; > + u32 reg, shift_increment; > + u64 offset; > + void __iomem *cp_regs, *cp_base; > + > + /* IDR6 */ > + reg = readl_relaxed(smmu->base + ARM_SMMU_IDR6); > + nump = 1 << FIELD_GET(IDR6_LOG2NUMP, reg); > + numq = 1 << FIELD_GET(IDR6_LOG2NUMQ, reg); > + smmu->nr_ecmdq = nump * numq; > + gap = ECMDQ_CP_RRESET_SIZE >> FIELD_GET(IDR6_LOG2NUMQ, reg); > + > + cp_regs = ioremap(smmu->iobase + ARM_SMMU_ECMDQ_CP_BASE, PAGE_SIZE); > + if (!cp_regs) > + return -ENOMEM; > + > + for (i = 0; i < nump; i++) { > + u64 val, pre_addr = 0; This is my mistake. The 'pre_addr' should be defined out of this 'for' loop. Or, you can remove all 'pre_addr' related statements, commercially available chips that have been tested cannot have such errors. > + > + val = readq_relaxed(cp_regs + 32 * i); > + if (!(val & ECMDQ_CP_PRESET)) { > + iounmap(cp_regs); > + dev_err(smmu->dev, "ecmdq control page %u is memory mode\n", i); > + return -EFAULT; > + } > + <--------------------------------------------- > + if (i && ((val & ECMDQ_CP_ADDR) != (pre_addr + ECMDQ_CP_RRESET_SIZE))) { | > + iounmap(cp_regs); | > + dev_err(smmu->dev, "ecmdq_cp memory region is not contiguous\n"); | > + return -EFAULT; | > + } | > + | > + pre_addr = val & ECMDQ_CP_ADDR; | <-------------------------------------------- feel free remove these > + } -- Regards, Zhen Lei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel