From: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: Linus Walleij <linusw@kernel.org>,
Michal Simek <michal.simek@amd.com>,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, saikrishna12468@gmail.com,
git@amd.com
Subject: Re: [PATCH] pinctrl: zynqmp: Ensure function names are NUL terminated
Date: Wed, 18 Nov 2026 14:08:16 +0530 [thread overview]
Message-ID: <85ff5be0-4fad-4d92-b9f3-2553c7c4365b@amd.com> (raw)
In-Reply-To: <20261117131616.0a631d5c@pumpkin>
Hi David,
On 11/17/2026 6:46 PM, David Laight wrote:
> On Tue, 17 Nov 2026 13:09:47 +0530
> Sai Krishna Potthuri <sai.krishna.potthuri@amd.com> wrote:
>
>> PM_QID_PINCTRL_GET_FUNCTION_NAME returns the function name in a fixed
>> 16-byte field and does not guarantee NUL termination. A 16-character
>> name fills the entire field.
>> The driver copies this field into a 16-byte buffer and subsequently
>> uses it as a C string. For a non-NUL-terminated name, string operations
>> can read past the end of the buffer into the adjacent groups pointer.
>>
>> Reserve an extra byte for the NUL terminator and explicitly terminate
>> the copied function name.
>>
>> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
>> ---
>> drivers/pinctrl/pinctrl-zynqmp.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-zynqmp.c b/drivers/pinctrl/pinctrl-zynqmp.c
>> index aba129ead04c..c778133fadc2 100644
>> --- a/drivers/pinctrl/pinctrl-zynqmp.c
>> +++ b/drivers/pinctrl/pinctrl-zynqmp.c
>> @@ -29,7 +29,11 @@
>>
>> #define ZYNQMP_PIN_PREFIX "MIO"
>> #define PINCTRL_GET_FUNC_NAME_RESP_LEN 16
>> -#define MAX_FUNC_NAME_LEN 16
>> +/*
>> + * Firmware returns the name in a fixed-size field and does not guarantee a
>> + * NUL terminator. Keep one extra byte for the NUL terminator.
>> + */
>> +#define MAX_FUNC_NAME_LEN (PINCTRL_GET_FUNC_NAME_RESP_LEN + 1)
>> #define MAX_GROUP_PIN 50
>> #define MAX_PIN_GROUPS 50
>> #define END_OF_FUNCTIONS "END_OF_FUNCTIONS"
>> @@ -650,6 +654,7 @@ static void zynqmp_pinctrl_get_function_name(u32 fid, char *name)
>> */
>> zynqmp_pm_query_data(qdata, payload);
>> memcpy(name, payload, PINCTRL_GET_FUNC_NAME_RESP_LEN);
>> + name[PINCTRL_GET_FUNC_NAME_RESP_LEN] = '\0';
>
> Too many constants....
> You might want to try embedding 'name' in a structure.
>
> Then, at least, you can use sizeof().
Ok, i will define the below structure
struct zynqmp_func_name {
char name[ZYNQMP_FUNC_NAME_LEN];
char nul;
};
and initialize them as below.
memcpy(fname->name, payload, sizeof(fname->name));
fname->nul = '\0';
Regards
Sai Krishna
>
> David
>
>
>> }
>>
>> static int zynqmp_pinctrl_get_num_functions(unsigned int *nfuncs)
>
next prev parent reply other threads:[~2026-11-18 8:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 7:39 [PATCH] pinctrl: zynqmp: Ensure function names are NUL terminated Sai Krishna Potthuri
2026-11-17 13:16 ` David Laight
2026-11-18 8:38 ` Sai Krishna Potthuri [this message]
2026-11-18 9:02 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85ff5be0-4fad-4d92-b9f3-2553c7c4365b@amd.com \
--to=sai.krishna.potthuri@amd.com \
--cc=david.laight.linux@gmail.com \
--cc=git@amd.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=saikrishna12468@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox