From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0F19C4167B for ; Mon, 4 Dec 2023 11:55:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kqu0t520AXp9WI6CKSkzvCdI5kbyYMMLstT+3eZNku0=; b=4UlJuihZE0+gfm I2lMO/zEzJ+oXLI/dlo+Y2MH3eH3UrdHwEnFjQFPlVYTf8XbAVEFxc4SUSk7Igthh7rTt5W9hO1Ve WfwXtIJF0NP1G7cDL62jS/sDscbk6ecuWj8o59DYlyoY2/3Ak/WxJdkrVe5Oa3l4zwx420/AkaiLe fUlbeJy0xy4e3GuavM82Gs6vgGBPIBhG3cjOpDCMl5e7YAzlEWUhIrizAMV7tkvFl6hw6cYVrxV0I s/Kj5B6Y6eFbTX+7awPRFoa+9dfpequbSvEtnSRPodD9b6ALYfGzUuyZnRUng4VI8MDqCc7A8iB8j EB6IhHCqIpZ5zfYjKpFg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA7Xh-003jHc-19; Mon, 04 Dec 2023 11:55:17 +0000 Received: from mta-64-228.siemens.flowmailer.net ([185.136.64.228]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rA7Xc-003jCL-0H for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2023 11:55:15 +0000 Received: by mta-64-228.siemens.flowmailer.net with ESMTPSA id 20231204115459447474995ea1b32b65 for ; Mon, 04 Dec 2023 12:55:00 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=florian.bezdeka@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc:References:In-Reply-To; bh=DeAVJVh1/dmfA7n8KCr9e65gohS5SL4YYZz1yRamMmo=; b=ph2h0h5jvGxuWKVsNS0TMd+fNjmiTxwfMkny+Ro6YD2+HKnOLi/CClvCRs5tLNpmSk0jh2 b2Xas1pUz9iB6dBJVNhJnkJ3JLnWbdX0OqFTVBA38AMksw93F1/n2DVd92g1cldYwMwE1iYt KYrV+sFm2RBFyevOjoDdSCwH2EABY=; Message-ID: <8602c88c98fd722db8e164a1520c56aebfa64db7.camel@siemens.com> Subject: Re: [xdp-hints] Re: [PATCH bpf-next v3 2/3] net: stmmac: add Launch Time support to XDP ZC From: Florian Bezdeka To: Jesper Dangaard Brouer , Song Yoong Siang , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev , Lorenzo Bianconi , Tariq Toukan , Willem de Bruijn , Maxime Coquelin , Andrii Nakryiko , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, bpf@vger.kernel.org, xdp-hints@xdp-project.net, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kselftest@vger.kernel.org Date: Mon, 04 Dec 2023 12:54:56 +0100 In-Reply-To: <43b01013-e78b-417e-b169-91909c7309b1@kernel.org> References: <20231203165129.1740512-1-yoong.siang.song@intel.com> <20231203165129.1740512-3-yoong.siang.song@intel.com> <43b01013-e78b-417e-b169-91909c7309b1@kernel.org> MIME-Version: 1.0 X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-68982:519-21489:flowmailer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_035512_380797_04C3ED42 X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2023-12-04 at 11:36 +0100, Jesper Dangaard Brouer wrote: > On 12/3/23 17:51, Song Yoong Siang wrote: > > This patch enables Launch Time (Time-Based Scheduling) support to XDP zero > > copy via XDP Tx metadata framework. > > > > Signed-off-by: Song Yoong Siang > > --- > > drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ > > As requested before, I think we need to see another driver implementing > this. > > I propose driver igc and chip i225. igc support would be really nice and highly appreciated. There are a lot of tests running here with that chip (i225/i226) / driver (igc) combination. Let me know if we can support somehow, testing included. > > The interesting thing for me is to see how the LaunchTime max 1 second > into the future[1] is handled code wise. One suggestion is to add a > section to Documentation/networking/xsk-tx-metadata.rst per driver that > mentions/documents these different hardware limitations. It is natural > that different types of hardware have limitations. This is a close-to > hardware-level abstraction/API, and IMHO as long as we document the > limitations we can expose this API without too many limitations for more > capable hardware. > > [1] > https://github.com/xdp-project/xdp-project/blob/master/areas/tsn/code01_follow_qdisc_TSN_offload.org#setup-code-driver-igb > > This stmmac driver and Intel Tiger Lake CPU must also have some limit on > how long into the future it will/can schedule packets? > > > People from xdp-hints list must make their voice hear if they want i210 > and igb driver support, because it have even-more hardware limitations, > see [1] (E.g. only TX queue 0 and 1 supports LaunchTime). BUT I know > some have this hardware in production and might be motivated to get a > functioning driver with this feature? i210 support would be nice, that would allow us to compare some test setups with different NICs. In addition it would simplify some test setups. For now, IMHO igc is more important. > > --Jesper _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel