From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEAE7CFD2F6 for ; Thu, 27 Nov 2025 16:31:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yeuPcBQz1VAPsG0Mk5ai/edW+CwSGXXXJyF6gkP8twQ=; b=bmn9/zLn6/0eMV/vrQpolRyFbp USgfrs04aFfKJZMZ1MG8pc+LdPKwk9wfJtOD4DUbXGrfiPw9bnTfa3NbIB+0WvmWzibl9PxDkn4xV 1ilDrosxi4uEK3hjQsPXkXooTd/RU16iOeSbp+BvGG7ua+81CghV64vrfYdQ0qSxJYVczJxF67+36 E0+Y+D8LQNrkgxET/8zEJ8ogyo9rpiZ6JrrCsyGUSr9G3LYuFjfcKR8ixiLnAyIepkpRovDxOB5Z7 6Wgm4gFI3cXUCxlRSVHQTvVGgw5OQPp53HSQAW+ZjXbbe1TGuAh9NKAFntevSJ7k8TqbGd4Vjakdx NnPV9EgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vOeuI-0000000Gvig-3J0K; Thu, 27 Nov 2025 16:31:46 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vOeuG-0000000GviH-11FG for linux-arm-kernel@lists.infradead.org; Thu, 27 Nov 2025 16:31:45 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id BF7AD43CBE; Thu, 27 Nov 2025 16:31:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 968DDC116C6; Thu, 27 Nov 2025 16:31:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764261102; bh=BzpKf6TaDfGEcv5xQUDvzVrEvwlIheOml6sgi2kK8GE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uSQ2zIvFyWE5zCCpX1ZOpduDuMUMPqI5uqwEmXW31axx2WN+omziufbhoCNNRYqKk kCHbd+9px1I3Gy0Z0EwR7N1cWo29FRbimMFCBlVnNEGOfkhwriXW3ivF6l3p6KVwE4 n2/J7TPgZGbUwJVs3vrfSfGG2FB1hokAVzkh0tPVgPPhJXhzpf1Yl7lQ7k/lKAfkmT /TsbyIeT226ubFQ/2VBXpea0huQZfLTIw8TuPCE9XFt/Izb+5nq+rlQEyqglgQ9CXD GCF/RVzyMnlk5f1Gpm8mfAjBwion35PrmLPPI2WycqC63aGtQlg0OC1lGxw6uhLJLl PmlfdjC/xqdBA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vOeuC-00000008qpN-13Mb; Thu, 27 Nov 2025 16:31:40 +0000 Date: Thu, 27 Nov 2025 16:31:39 +0000 Message-ID: <861pljqvx0.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Joey Gouly , Suzuki K Poulose , Zenghui Yu , Ben Horgan Subject: Re: [PATCH v2 2/5] KVM: arm64: Force trap of GMID_EL1 when the guest doesn't have MTE In-Reply-To: References: <20251126155951.1146317-1-maz@kernel.org> <20251126155951.1146317-3-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oupton@kernel.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, ben.horgan@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251127_083144_326006_DD8E494E X-CRM114-Status: GOOD ( 20.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 27 Nov 2025 06:37:13 +0000, Oliver Upton wrote: > > On Wed, Nov 26, 2025 at 03:59:48PM +0000, Marc Zyngier wrote: > > If our host has MTE, but the guest doesn't, make sure we set HCR_EL2.TID5 > > to force GMID_EL1 being trapped. > > > > Reviewed-by: Joey Gouly > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/kvm/sys_regs.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > > index 9e4c46fbfd802..2ca6862e935b5 100644 > > --- a/arch/arm64/kvm/sys_regs.c > > +++ b/arch/arm64/kvm/sys_regs.c > > @@ -5561,6 +5561,8 @@ static void vcpu_set_hcr(struct kvm_vcpu *vcpu) > > > > if (kvm_has_mte(vcpu->kvm)) > > vcpu->arch.hcr_el2 |= HCR_ATA; > > + else if (id_aa64pfr1_mte(read_sanitised_ftr_reg(SYS_ID_AA64PFR1_EL1))) > > This helper is ugly! You think? :D > > > + vcpu->arch.hcr_el2 |= HCR_TID5; > > How about setting the trap unconditionally when !kvm_has_mte()? Even in > the case of asymmetry we'd want GMID_EL1 to trap. Yup, that's a good point. I'll fix that. M. -- Without deviation from the norm, progress is not possible.