From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD60AC77B7A for ; Tue, 16 May 2023 16:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lIMRi8s1o936BaMs3NVullnhCDisi3ay04IqEWq+1KU=; b=hdkm+CO7od9TXF T2Uk/a1teHk7yqbYHVTwuM4OguSGRyG1mEYdmnKUrJh9q1gx4J3ZqNsondXaxrBIS5lJ7HuJBR3g6 2qFdtq8M//AvxC7etAz7prv1X86KcbRo3z5nCowl1+wIn3d4s/cIEKRzz4wrUipBLcSrq7NDxCu7t 4eKANSHAu/UpFgFgguKriwUqr/va5X4VuUyjoY9evThodWHUgwj9RFq7mAoP/avqyHgu9p4LkeRDU hz3La/spdoddYBaNlXAzf23+C4I8VbSis5UcHfNdNrWz6CUFDpzNpM2yjf81x4DPAls2zIR9mHWJ5 /1iDgX2sQahXfhVSJZog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyxGr-006QCk-07; Tue, 16 May 2023 16:11:29 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyxGo-006QCG-0W for linux-arm-kernel@lists.infradead.org; Tue, 16 May 2023 16:11:27 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A6B4461A21; Tue, 16 May 2023 16:11:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0B116C433D2; Tue, 16 May 2023 16:11:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684253485; bh=sItnS/W3hGMIZ8xDewgQMk1wOABe9uUE8aPZbDpdYH4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mp3kgNX75/0aXMztfEw6hScQAPI/gG6YBDfFxlRSMnpamgiyyXHsjRQItfs/2FIlZ WIkvnuYmwlTXV1DTkwHclveb6Pj+SNmbbbOJgYKr9aW0KTXrMohjkASRmvOM1ShtXo sCvLbhvCEsKFQCuNdcn4xw3yp36Yc/dh49BoEGhRJZtb0a0wwFnWctF6Czb0xANrVW 8uVZK+YPYkYTFX0nCl8Xede3+IgDMaw9Ys+q8zwkPno0birKeBU3viItWlJpikTsbk TH3WfhmabJtPdDXq5tCg4Ojvi6ELectmHMfdUn7AVjPJUDhsm11IXWxtzQgLIPgkzC TQEhJNxuOGwNg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pyxGk-00FbTf-Mu; Tue, 16 May 2023 17:11:22 +0100 Date: Tue, 16 May 2023 17:11:22 +0100 Message-ID: <861qjgmf2t.wl-maz@kernel.org> From: Marc Zyngier To: Jing Zhang Cc: KVM , KVMARM , ARMLinux , Oliver Upton , Will Deacon , Paolo Bonzini , James Morse , Alexandru Elisei , Suzuki K Poulose , Fuad Tabba , Reiji Watanabe , Raghavendra Rao Ananta Subject: Re: [PATCH v8 1/6] KVM: arm64: Move CPU ID feature registers emulation into a separate file In-Reply-To: <20230503171618.2020461-2-jingzhangos@google.com> References: <20230503171618.2020461-1-jingzhangos@google.com> <20230503171618.2020461-2-jingzhangos@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: jingzhangos@google.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, oupton@google.com, will@kernel.org, pbonzini@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, tabba@google.com, reijiw@google.com, rananta@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_091126_288883_4F4BA866 X-CRM114-Status: GOOD ( 21.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 03 May 2023 18:16:13 +0100, Jing Zhang wrote: > > Create a new file id_regs.c for CPU ID feature registers emulation code, > which are moved from sys_regs.c and tweak sys_regs code accordingly. > > No functional change intended. > > Signed-off-by: Jing Zhang > --- > arch/arm64/kvm/Makefile | 2 +- > arch/arm64/kvm/id_regs.c | 460 +++++++++++++++++++++++++++++++++++++ > arch/arm64/kvm/sys_regs.c | 464 ++++---------------------------------- > arch/arm64/kvm/sys_regs.h | 19 ++ > 4 files changed, 519 insertions(+), 426 deletions(-) > create mode 100644 arch/arm64/kvm/id_regs.c > > diff --git a/arch/arm64/kvm/Makefile b/arch/arm64/kvm/Makefile > index c0c050e53157..a6a315fcd81e 100644 > --- a/arch/arm64/kvm/Makefile > +++ b/arch/arm64/kvm/Makefile > @@ -13,7 +13,7 @@ obj-$(CONFIG_KVM) += hyp/ > kvm-y += arm.o mmu.o mmio.o psci.o hypercalls.o pvtime.o \ > inject_fault.o va_layout.o handle_exit.o \ > guest.o debug.o reset.o sys_regs.o stacktrace.o \ > - vgic-sys-reg-v3.o fpsimd.o pkvm.o \ > + vgic-sys-reg-v3.o fpsimd.o pkvm.o id_regs.o \ > arch_timer.o trng.o vmid.o emulate-nested.o nested.o \ > vgic/vgic.o vgic/vgic-init.o \ > vgic/vgic-irqfd.o vgic/vgic-v2.o \ > diff --git a/arch/arm64/kvm/id_regs.c b/arch/arm64/kvm/id_regs.c > new file mode 100644 > index 000000000000..96b4c43a5100 > --- /dev/null > +++ b/arch/arm64/kvm/id_regs.c > @@ -0,0 +1,460 @@ [...] I really wonder why we move this to another file. It only creates noise, and doesn't add much. Yes, the file is big. But now you need to expose all the internal machinery that was private until now. If you look at the global diffstat, this is "only" another 200 lines. I don't think this is worth the churn. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel