From: Marc Zyngier <maz@kernel.org>
To: Osama Abdelkader <osama.abdelkader@gmail.com>
Cc: oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com,
yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: arm64: add missing newline to sysreg init log
Date: Tue, 11 Nov 2025 09:49:03 +0000 [thread overview]
Message-ID: <86346kvr00.wl-maz@kernel.org> (raw)
In-Reply-To: <20251110211051.814728-1-osama.abdelkader@gmail.com>
On Mon, 10 Nov 2025 21:10:51 +0000,
Osama Abdelkader <osama.abdelkader@gmail.com> wrote:
>
> missing newline so the message is merged with follow-on logs
> the change only affects console output formatting, no behavioral impact.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
> arch/arm64/kvm/arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> index 870953b4a8a7..156cd1a6106e 100644
> --- a/arch/arm64/kvm/arm.c
> +++ b/arch/arm64/kvm/arm.c
> @@ -2845,7 +2845,7 @@ static __init int kvm_arm_init(void)
>
> err = kvm_sys_reg_table_init();
> if (err) {
> - kvm_info("Error initializing system register tables");
> + kvm_info("Error initializing system register tables\n");
> return err;
> }
>
Given that everything in kvm_sys_reg_table_init() already screams
badly when it fails, I don't see the point of an additional message,
and I'd rather remove it.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2025-11-11 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 21:10 [PATCH] KVM: arm64: add missing newline to sysreg init log Osama Abdelkader
2025-11-11 9:49 ` Marc Zyngier [this message]
2025-11-11 18:54 ` Osama Abdelkader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86346kvr00.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=joey.gouly@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osama.abdelkader@gmail.com \
--cc=oupton@kernel.org \
--cc=suzuki.poulose@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).