* [PATCH] KVM: arm64: add missing newline to sysreg init log
@ 2025-11-10 21:10 Osama Abdelkader
2025-11-11 9:49 ` Marc Zyngier
0 siblings, 1 reply; 3+ messages in thread
From: Osama Abdelkader @ 2025-11-10 21:10 UTC (permalink / raw)
To: maz, oupton, joey.gouly, suzuki.poulose, yuzenghui
Cc: linux-arm-kernel, kvmarm, linux-kernel, Osama Abdelkader
missing newline so the message is merged with follow-on logs
the change only affects console output formatting, no behavioral impact.
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
arch/arm64/kvm/arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
index 870953b4a8a7..156cd1a6106e 100644
--- a/arch/arm64/kvm/arm.c
+++ b/arch/arm64/kvm/arm.c
@@ -2845,7 +2845,7 @@ static __init int kvm_arm_init(void)
err = kvm_sys_reg_table_init();
if (err) {
- kvm_info("Error initializing system register tables");
+ kvm_info("Error initializing system register tables\n");
return err;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: arm64: add missing newline to sysreg init log
2025-11-10 21:10 [PATCH] KVM: arm64: add missing newline to sysreg init log Osama Abdelkader
@ 2025-11-11 9:49 ` Marc Zyngier
2025-11-11 18:54 ` Osama Abdelkader
0 siblings, 1 reply; 3+ messages in thread
From: Marc Zyngier @ 2025-11-11 9:49 UTC (permalink / raw)
To: Osama Abdelkader
Cc: oupton, joey.gouly, suzuki.poulose, yuzenghui, linux-arm-kernel,
kvmarm, linux-kernel
On Mon, 10 Nov 2025 21:10:51 +0000,
Osama Abdelkader <osama.abdelkader@gmail.com> wrote:
>
> missing newline so the message is merged with follow-on logs
> the change only affects console output formatting, no behavioral impact.
>
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
> arch/arm64/kvm/arm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> index 870953b4a8a7..156cd1a6106e 100644
> --- a/arch/arm64/kvm/arm.c
> +++ b/arch/arm64/kvm/arm.c
> @@ -2845,7 +2845,7 @@ static __init int kvm_arm_init(void)
>
> err = kvm_sys_reg_table_init();
> if (err) {
> - kvm_info("Error initializing system register tables");
> + kvm_info("Error initializing system register tables\n");
> return err;
> }
>
Given that everything in kvm_sys_reg_table_init() already screams
badly when it fails, I don't see the point of an additional message,
and I'd rather remove it.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] KVM: arm64: add missing newline to sysreg init log
2025-11-11 9:49 ` Marc Zyngier
@ 2025-11-11 18:54 ` Osama Abdelkader
0 siblings, 0 replies; 3+ messages in thread
From: Osama Abdelkader @ 2025-11-11 18:54 UTC (permalink / raw)
To: Marc Zyngier
Cc: oupton, joey.gouly, suzuki.poulose, yuzenghui, linux-arm-kernel,
kvmarm, linux-kernel
On Tue, Nov 11, 2025 at 09:49:03AM +0000, Marc Zyngier wrote:
> On Mon, 10 Nov 2025 21:10:51 +0000,
> Osama Abdelkader <osama.abdelkader@gmail.com> wrote:
> >
> > missing newline so the message is merged with follow-on logs
> > the change only affects console output formatting, no behavioral impact.
> >
> > Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> > ---
> > arch/arm64/kvm/arm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> > index 870953b4a8a7..156cd1a6106e 100644
> > --- a/arch/arm64/kvm/arm.c
> > +++ b/arch/arm64/kvm/arm.c
> > @@ -2845,7 +2845,7 @@ static __init int kvm_arm_init(void)
> >
> > err = kvm_sys_reg_table_init();
> > if (err) {
> > - kvm_info("Error initializing system register tables");
> > + kvm_info("Error initializing system register tables\n");
> > return err;
> > }
> >
>
> Given that everything in kvm_sys_reg_table_init() already screams
> badly when it fails, I don't see the point of an additional message,
> and I'd rather remove it.
>
> Thanks,
>
> M.
>
> --
> Without deviation from the norm, progress is not possible.
Thanks Marc. I just sent the patch to drop that message.
Thank you,
Osama
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-11 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-10 21:10 [PATCH] KVM: arm64: add missing newline to sysreg init log Osama Abdelkader
2025-11-11 9:49 ` Marc Zyngier
2025-11-11 18:54 ` Osama Abdelkader
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).