From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05646CCF9E3 for ; Tue, 11 Nov 2025 09:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Cqaxmihx5h27rQX77mbu6NSjP7ywzG6yw9rZQkPh/lY=; b=DoAqOQFtSqdZd0n5YnmmJupL8N Kz0OGOydFBkNei5FD0itAfAAZNXpUOc8E5nNJYMs9CnsP6OhIZJWIXPC+YAPUxQnyfvU4ZUQ7Hpz2 8XJMhiXO0pgLJz3L0SPttXMEUjeY2xvs8xQ1PF0bY6EOKnxO4Ft2shvPen/9SUv+viHZ1MNGRCfeh De6c2WwRnqWoTzgVRScEMP8FDwJpOnPnIr2K7usdL0FKQknY0EIUAGTmB0/hGJAT/FwhFdsMzosBN Oy9vto8/hyMgx9Cg7Je4jTv3Pw/tnZn+DYjCPEz2HjAABqFgvuhUlyQAMhN/KzyWn+C2fqYrIMFDR pB0Skk4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vIkzs-00000006sGy-41Ng; Tue, 11 Nov 2025 09:49:08 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vIkzr-00000006sGf-1Brm for linux-arm-kernel@lists.infradead.org; Tue, 11 Nov 2025 09:49:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 5C44661915; Tue, 11 Nov 2025 09:49:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB372C19421; Tue, 11 Nov 2025 09:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762854546; bh=n/kM1AzkAh+XotAdnnKzHeaD66yI0/no2z219kdImyI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HOeJ3RVZZB/4oSIYEvD8eHEipzvZOFaJqnkE42dmMFp+tB9OuzjLWz04+YM3z7R4U lcaEalhowL1o71cerk5eX47EHL+ajre+fi2UEyJi1xInplcb7+DTXcolqUX2R5nGjK 6MBMS9grqKVToRjoS/YeVP7uQixVgsoLfttes1N01Nh3coRsXQHPgvQXU4w4kWOnxq iTV9Sv5znQ/WVyipDX6Eh5zMTxj++G97cXGP2KglHW5b3TIN+Akg5PHoftE2jnkGiu Nq4Ktn6Go9uKbNUmiwWIpZYgET9XI++vRz/VbZK/uBooblkYrgAlMYga9XRb72DXVa aZdMFVmKrv7Fg== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vIkzn-00000004Alt-2bIR; Tue, 11 Nov 2025 09:49:03 +0000 Date: Tue, 11 Nov 2025 09:49:03 +0000 Message-ID: <86346kvr00.wl-maz@kernel.org> From: Marc Zyngier To: Osama Abdelkader Cc: oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: add missing newline to sysreg init log In-Reply-To: <20251110211051.814728-1-osama.abdelkader@gmail.com> References: <20251110211051.814728-1-osama.abdelkader@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: osama.abdelkader@gmail.com, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 10 Nov 2025 21:10:51 +0000, Osama Abdelkader wrote: > > missing newline so the message is merged with follow-on logs > the change only affects console output formatting, no behavioral impact. > > Signed-off-by: Osama Abdelkader > --- > arch/arm64/kvm/arm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 870953b4a8a7..156cd1a6106e 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -2845,7 +2845,7 @@ static __init int kvm_arm_init(void) > > err = kvm_sys_reg_table_init(); > if (err) { > - kvm_info("Error initializing system register tables"); > + kvm_info("Error initializing system register tables\n"); > return err; > } > Given that everything in kvm_sys_reg_table_init() already screams badly when it fails, I don't see the point of an additional message, and I'd rather remove it. Thanks, M. -- Without deviation from the norm, progress is not possible.