From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E100DC71133 for ; Wed, 11 Jun 2025 16:01:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: MIME-Version:References:In-Reply-To:Subject:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cDWVDs9vouKGYfDdQH1pyMLjADyTTF4whDNaey2nyMo=; b=br7WzxvJlAubGqQFFUJqjQhqQ9 vvacKkjLXddJyRdwG6tvHl1RmL/2wQy2HYEX355AQ8kYKBjcb+2/h8PoJgBuSeQSHX+sfutPoWeuQ Phymec1U1YVHep1ajKtXR59UQOHO1gS9EyYxF9lK5qMxAi7cB2xqO0h6ov6x+mMkci4BTgvGqRJOG DhutSUJ+gywjxF5FdGQEzOi2O7S+ax5peQCZMzeTHCxljZ7uH2X9bHs+JiuP1JDEkcnE70svu1CX6 QYdm7wF+eM4x/btaWJHpfkf8Ep3fIxWsGOBZUbln1b02Q7kv3h5f2GdK26OGhCHcmv4fURN0oo/nD Nujzr8Cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPNtD-0000000AXDy-35xu; Wed, 11 Jun 2025 16:01:23 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPKwf-00000009ss8-3mLQ for linux-arm-kernel@lists.infradead.org; Wed, 11 Jun 2025 12:52:47 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B1C4E5C5A18; Wed, 11 Jun 2025 12:50:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 069EEC4CEF5; Wed, 11 Jun 2025 12:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749646365; bh=xS5CjjPOWei09By745+NFla9rsFISSD/pc+6jDHaYFc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SzxtGcgjtlqJTLeJJj91O7ONtIXqWBzum2CK7b8fc734uTwS/L0Zf0mKIVTOccSzL JdQtSzMqQoMgbKJBdoxIy76e8rb1iOfHr8I4hnAH4f+U4v1OwR7b3vddxiQagtLau0 zr7mZY5sEIrdRYuVWjjLc9kYBN0zX13eHdUjYIbPJEvIQinHKxJg6aoHLQQuctZiRK Q/pF6itXmvvCicWAKSCZL/ChYpNfC6Ep8VKxq+mkkVg6UPn3JgEPNPXZ/t3y1E0JwM RJPhJHQ0j1t3ldqHeRZ5Izu+P6yiyaPvuLLarxg9pRTMRlEYdkF/DowSni9B5USMGs RHokKKcxx1rXQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uPKwc-005rNW-Jo; Wed, 11 Jun 2025 13:52:42 +0100 Date: Wed, 11 Jun 2025 13:52:41 +0100 Message-ID: <8634c6e8yu.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Subject: Re: [PATCH V3 2/2] KVM: selftests: Change MDSCR_EL1 register holding variables as uint64_t In-Reply-To: <9b378582-44eb-4fbb-a03a-40eb317daebd@arm.com> References: <20250610053128.4118784-1-anshuman.khandual@arm.com> <20250610053128.4118784-3-anshuman.khandual@arm.com> <864iwnedjk.wl-maz@kernel.org> <9b378582-44eb-4fbb-a03a-40eb317daebd@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, ada.coupriediaz@arm.com, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250611_055246_021699_273027F3 X-CRM114-Status: GOOD ( 26.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , kvm@vger.kernel.org, Catalin Marinas , linux-kernel@vger.kernel.org, Oliver Upton , Joey Gouly , linux-kselftest@vger.kernel.org, kvmarm@lists.linux.dev, Will Deacon , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 11 Jun 2025 04:45:10 +0100, Anshuman Khandual wrote: > > > > On 10/06/25 10:31 PM, Marc Zyngier wrote: > > On Tue, 10 Jun 2025 06:31:28 +0100, > > Anshuman Khandual wrote: > >> > >> Change MDSCR_EL1 register holding local variables as uint64_t that reflects > >> its true register width as well. > >> > >> Cc: Marc Zyngier > >> Cc: Oliver Upton > >> Cc: Joey Gouly > >> Cc: kvm@vger.kernel.org > >> Cc: kvmarm@lists.linux.dev > >> Cc: linux-kernel@vger.kernel.org > >> Cc: linux-kselftest@vger.kernel.org > >> Cc: linux-arm-kernel@lists.infradead.org > >> Reviewed-by: Ada Couprie Diaz > >> Signed-off-by: Anshuman Khandual > >> --- > >> tools/testing/selftests/kvm/arm64/debug-exceptions.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/tools/testing/selftests/kvm/arm64/debug-exceptions.c b/tools/testing/selftests/kvm/arm64/debug-exceptions.c > >> index c7fb55c9135b..e34963956fbc 100644 > >> --- a/tools/testing/selftests/kvm/arm64/debug-exceptions.c > >> +++ b/tools/testing/selftests/kvm/arm64/debug-exceptions.c > >> @@ -140,7 +140,7 @@ static void enable_os_lock(void) > >> > >> static void enable_monitor_debug_exceptions(void) > >> { > >> - uint32_t mdscr; > >> + uint64_t mdscr; > >> > >> asm volatile("msr daifclr, #8"); > >> > >> @@ -223,7 +223,7 @@ void install_hw_bp_ctx(uint8_t addr_bp, uint8_t ctx_bp, uint64_t addr, > >> > >> static void install_ss(void) > >> { > >> - uint32_t mdscr; > >> + uint64_t mdscr; > >> > >> asm volatile("msr daifclr, #8"); > >> > > > > Why change this in the place that matters *the least*? > > > > arch/arm64/kernel/debug-monitors.c is full of 32bit manipulation of > > this register, and that's only one example of it. So if you are going > > to change this, please do it fully, not as a random change in a random > > file. > > The first patch in this series changes mdscr system register to 64 bit > in the mentioned file (i.e arch/arm64/kernel/debug-monitors.c). Then please Cc me on the series, and not patches at random. Context matters. M. -- Without deviation from the norm, progress is not possible.