From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF27ECCF2C4 for ; Sat, 17 Oct 2026 17:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XLe8JXdyBEFFJmBvlr2WFTfY/8qS8WbugaiAG9OA1pU=; b=L7RQxebSbGM3jLaRFA4k2NsW4A HMr/5KBjtmlytY0sF3TYoQELxTYtNYFNqrDDjXAn5P6DNo9T6cz5nkuZ7ApaynUgA1fdu6mxnqPqw P01KFfljOBou5b3O9dnrKrMeDSQH5g1sBNWPz9HMW9Ju0WB1DpdPpCRqvV8mBIa2DWLPFoviDM/UM VspFfd0ajqMPxQUaJE3ouDrK37wLBJZiXMke0gOhJbNe7p+bos/PeRGM6bfX2KgUT4oALEN0CIZVG pkFa7Q2YROU6656JaUKcirRUpH9P5pS2oWRYTo3vlLzJDqXoBKVN8A1dQHHgMw/4BIb91Vi5x9ucp 3tAvQYCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI87U-00000004zO3-0X9S; Sat, 17 Oct 2026 17:22:56 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xI87T-00000004zNm-2552 for linux-arm-kernel@lists.infradead.org; Sat, 17 Oct 2026 17:22:55 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A5FA860AA5; Sat, 17 Oct 2026 17:22:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AE971F000C5; Sat, 17 Oct 2026 17:22:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1792257774; bh=XLe8JXdyBEFFJmBvlr2WFTfY/8qS8WbugaiAG9OA1pU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=E5994FI8BIFPq8T4RnDF1uGTb3Qi5ps6Tz8bl0HzJcqhSpsdnESC3rRCbEqiqlzd3 D+g9kZnc6xyHJ0lJX0qpuyzPVQCyYZFbaxNe3nVCRgO4OmqlyDF2dt5TZumGLDRQq/ C+hpENK60XsFem6BeNWdlx2GONT1H3Fp7N7jg365IWAWynkl5gFE26RfNpov9o4b+k cQnSbRuhwEXdPQlXJrG3YXU7YqNZJ/o4v+eUwTf5EyIrlVlDeq1oTCt24TKeOjJBFh HhVwij6rJhxG/0FD0So+1ijaJKJ6UeDyLwCWQxGtTrLHVwzUq3staINgjrGFyD06V+ PlRExEP7uWo6A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xI87P-000000048vp-3vWG; Sat, 17 Oct 2026 17:22:52 +0000 Date: Sat, 17 Oct 2026 18:22:51 +0100 Message-ID: <864iek1btg.wl-maz@kernel.org> From: Marc Zyngier To: Julian Braha Cc: mark.rutland@arm.com, lpieralisi@kernel.org, sudeep.holla@kernel.org, tglx@kernel.org, radu@rendec.net, vsethi@nvidia.com, sdonthineni@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW In-Reply-To: <20261014123539.2259230-1-julianbraha@gmail.com> References: <20261014123539.2259230-1-julianbraha@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: julianbraha@gmail.com, mark.rutland@arm.com, lpieralisi@kernel.org, sudeep.holla@kernel.org, tglx@kernel.org, radu@rendec.net, vsethi@nvidia.com, sdonthineni@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 14 Oct 2026 13:35:37 +0100, Julian Braha wrote: > > ARM_GIC_V3 currently selects HAVE_ARM_SMCCC_DISCOVERY without ensuring its > dependency, ARM_PSCI_FW, is met. > > Patch 1 of this series makes the select conditional on arm64, and patch 2 > adds stubs for arm32. > > --- > Julian Braha (2): > irqchip: gic-v3: fix unmet dependency on ARM_PSCI_FW > firmware: smccc: provide stubs when discovery is disabled > > drivers/irqchip/Kconfig | 2 +- > include/linux/arm-smccc.h | 7 +++++++ > 2 files changed, 8 insertions(+), 1 deletion(-) This hasn't been correctly tested, I'm afraid. The patches are in the wrong order, as applying patch #1 on its own will break a 32bit ARM build without PSCI (HAVE_ARM_SMCCC_DISCOVERY not selected, but the stubs that are supposed to save the day are in patch #2...): arm-linux-gnueabihf-ld: drivers/irqchip/irq-gic-v3.o: in function `gic_enable_quirk_nvidia_t241': /home/maz/hot-poop/arm-platforms/drivers/irqchip/irq-gic-v3.c:1816:(.text+0xb04): undefined reference to `arm_smccc_get_soc_id_version' make[2]: *** [scripts/Makefile.vmlinux:72: vmlinux.unstripped] Error 1 make[1]: *** [/home/maz/hot-poop/arm-platforms/Makefile:1387: vmlinux] Error 2 make: *** [Makefile:248: __sub-make] Error 2 With the patch ordering fixed and the whole thing applied to the same tree: Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.